Re: [webkit-dev] Can we show failing test list on waterfall?
Ryosuke Niwa írta: What if DRT was killed and there was no result.html? (e.g. if more than 20+ tests crash, we bail out early and there won't be result.html). old-run-webkit-tests always generates results.html even if DRT crashes. br, Ossy ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Can we show failing test list on waterfall?
On Apr 2, 2011, at 4:59 AM, Ryosuke Niwa wrote: > On Fri, Apr 1, 2011 at 2:54 PM, Adam Barth wrote: > Can we show the list of failing layout tests in buildbot's "waterfall" > display so we don't have to click through to the results.html file? > > Also, can we change the [view results] link so that it goes directly > to results.html instead of the directory listing? Personally, I > always click through to results.html because it's so much prettier > than the directory listing. > > What if DRT was killed and there was no result.html? (e.g. if more than 20+ > tests crash, we bail out early and there won't be result.html). We should write out results.html in that case, too. There's no reason not to. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Can we show failing test list on waterfall?
On Fri, Apr 1, 2011 at 2:54 PM, Adam Barth wrote: > > Can we show the list of failing layout tests in buildbot's "waterfall" > display so we don't have to click through to the results.html file? > > Also, can we change the [view results] link so that it goes directly > to results.html instead of the directory listing? Personally, I > always click through to results.html because it's so much prettier > than the directory listing. > What if DRT was killed and there was no result.html? (e.g. if more than 20+ tests crash, we bail out early and there won't be result.html). - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Can we show failing test list on waterfall?
Adam Barth írta: Cool. Looks like Ossy is going to write a patch. Yes sir, I filed a bug report, and uploaded the proposed patch: https://bugs.webkit.org/show_bug.cgi?id=57671 br, Ossy ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Can we show failing test list on waterfall?
On Fri, Apr 1, 2011 at 3:08 PM, Adam Roben wrote: > On Apr 1, 2011, at 5:54 PM, Adam Barth wrote: >> Can we show the list of failing layout tests in buildbot's "waterfall" >> display so we don't have to click through to the results.html file? > > How would they be displayed? There isn't much room on the waterfall fore more > information. For example, the downstream Chromium canaries just list the names of the first couple tests (without paths): [[ frame-programmatic-noresize.html ]] Even just the first dozen characters of the name would be helpful to see at-a-glance whether it's the same test failing on multiple bots. >> Also, can we change the [view results] link so that it goes directly >> to results.html instead of the directory listing? Personally, I >> always click through to results.html because it's so much prettier >> than the directory listing. > > That can be done by modifying > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg. Just search for > "view results". Cool. Looks like Ossy is going to write a patch. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Can we show failing test list on waterfall?
Hi Adam,
I think it is a good idea. I always check results.html too,
so I'd would be great if we had to click only once. ;)
It is a very simple patch to fix the url: (master.cfg)
-url =
self.build.getProperties().render(self.resultDirectory).replace("public_html/",
"/")
+url = self.build.getProperties().render(self.resultDirectory).replace("public_html/",
"/") + "/results.html"
I never checked Apache logs: error_log.txt and access_log.txt,
but they can be useful. If we modify the URL of "view result",
we should add URL's to results.html referencing these files.
If there isn't any objection against it, I'm going to upload a patch into
bugzilla.
br,
Ossy
Adam Barth írta:
Hi Bill,
Can we show the list of failing layout tests in buildbot's "waterfall"
display so we don't have to click through to the results.html file?
Also, can we change the [view results] link so that it goes directly
to results.html instead of the directory listing? Personally, I
always click through to results.html because it's so much prettier
than the directory listing.
I don't have any sense for whether those things are easy or hard, but
they'd make my life a little bit easier. If you point me in the right
direction, I can attempt to make the changes myself (but you should
also feel free to do them yourself if that's easier for you).
Thanks!
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Can we show failing test list on waterfall?
On Apr 1, 2011, at 5:54 PM, Adam Barth wrote: > Can we show the list of failing layout tests in buildbot's "waterfall" > display so we don't have to click through to the results.html file? How would they be displayed? There isn't much room on the waterfall fore more information. > Also, can we change the [view results] link so that it goes directly > to results.html instead of the directory listing? Personally, I > always click through to results.html because it's so much prettier > than the directory listing. That can be done by modifying Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg. Just search for "view results". -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Can we show failing test list on waterfall?
Hi Bill, Can we show the list of failing layout tests in buildbot's "waterfall" display so we don't have to click through to the results.html file? Also, can we change the [view results] link so that it goes directly to results.html instead of the directory listing? Personally, I always click through to results.html because it's so much prettier than the directory listing. I don't have any sense for whether those things are easy or hard, but they'd make my life a little bit easier. If you point me in the right direction, I can attempt to make the changes myself (but you should also feel free to do them yourself if that's easier for you). Thanks! Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
