Re: [webkit-dev] Clearing old reviews from the queue

[Dean Jackson]

> On 16 Feb 2020, at 17:46, Alexey Proskuryakov  wrote:
> 
> 
> 
>> 16 февр. 2020 г., в 7:52, Dean Jackson  написал(а):
>> 
>> Does anyone oppose clearing all review requests that are older than 6 
>> months? (or 1 year?)
> 
> Looking at ancient patches in the review queue, quite a few look like they 
> should still work (e.g. adding new tests). So said that we are not keeping up 
> with reviews, even for simple patches.

It is very sad.

> 
>> I tried to use the bugzilla API to do this, but I couldn't work out how to 
>> detect the attachment state properly. I looked at the source code for the 
>> queue page and it uses custom SQL :)
> 
> What were you trying to do, and how far did you get?

I started explaining to you where I failed, which caused me to read the 
documentation again, and I think I've now got it. I thought that the review 
status was kept in a side table, but it's not.

Basically I now have a script that:

- for each open bug
  - for each attachment
- if !is_patch, continue
- if is_obsolete, continue
- for each flag
  - if name is "r" and status is "?"
- if creation_time is older than 1 year
  - Set flag to r- and leave a "sorry we missed you" message
- if creator is "a...@webkit.org "
  - Set flag to r+

So, if we're happy with the 1 year timeout, I'll run this.

Dean

> 
> - Alexey
> 
>> (It's easy to do with the GitHub API)
>> 
>> Dean
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> 



smime.p7s
Description: S/MIME cryptographic signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Clearing old reviews from the queue

[Alexey Proskuryakov]

> 16 февр. 2020 г., в 7:52, Dean Jackson  написал(а):
> 
> Does anyone oppose clearing all review requests that are older than 6 months? 
> (or 1 year?)

Looking at ancient patches in the review queue, quite a few look like they 
should still work (e.g. adding new tests). So said that we are not keeping up 
with reviews, even for simple patches.

> I tried to use the bugzilla API to do this, but I couldn't work out how to 
> detect the attachment state properly. I looked at the source code for the 
> queue page and it uses custom SQL :)

What were you trying to do, and how far did you get?

- Alexey

> (It's easy to do with the GitHub API)
> 
> Dean
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Clearing old reviews from the queue

[Ryosuke Niwa]

Sounds reasonable to me although I’d suggest older than 1 year instead of 6
months since I don’t think 6 months is long enough to render a patch
completely obsolete in many cases.

- R. Niwa

On Sun, Feb 16, 2020 at 07:53 Dean Jackson  wrote:

> Does anyone oppose clearing all review requests that are older than 6
> months? (or 1 year?)
>
> I tried to use the bugzilla API to do this, but I couldn't work out how to
> detect the attachment state properly. I looked at the source code for the
> queue page and it uses custom SQL :)
>
> (It's easy to do with the GitHub API)
>
> Dean
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
-- 
- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Clearing old reviews from the queue

[Dean Jackson]

Does anyone oppose clearing all review requests that are older than 6 months? 
(or 1 year?)

I tried to use the bugzilla API to do this, but I couldn't work out how to 
detect the attachment state properly. I looked at the source code for the queue 
page and it uses custom SQL :)

(It's easy to do with the GitHub API)

Dean



smime.p7s
Description: S/MIME cryptographic signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev