The only time I've ever had an issue with committing is when I forgot to add
the file myself. The bot uses the same scripts that committers do. I think
it'd be worth your time to become comfortable with them. If nothing else,
so you can land fixes for when you break the build. It also frees up
The only time I've ever had an issue with committing is when I forgot to add
the file myself. The bot uses the same scripts that committers do. I think
it'd be worth your time to become comfortable with them. If nothing else,
so you can land fixes for when you break the build. It also frees up
On Thu, Feb 25, 2010 at 5:26 AM, Jeremy Orlow jor...@chromium.org wrote:
It also frees up the queue for those who need it.
A common misconception, but looking at the logs the commit-queue looks
to be no where near capacity. I believe it could commit every change
done to WebKit in a day and
I agree with Jeremy and David. If you are a committer you should try to land
patches on your own when you can. I mainly think this because it lets svn/git
blame work as intended instead of always blaming who ran the bot. Maybe we
should have a commit-...@webkit.org user?
On Feb 25, 2010, at
Also, I think that the argument that the (common) commit-queue breaks
annotate is not really accurate.
The commit-queue does change what user name it puts next to the line
in the default annotate view (in the command line)[1]. But the
username in that view is almost entirely useless (at least
Adam Barth pointed out that the commit queue has been blocked for
about 20 hours. Looking at the reason why:
editing/undo/undo-deleteWord.html - failed
editing/undo/undo-iframe-location-change.html - failed
If you have made changes in this area recently, could you please fix
these test failures?
Actually, it doesn't appear to be do to recent changes in this area. They
started failing after r55177 (
http://build.webkit.org/waterfall?last_time=1266975298), but that change is
unrelated to these test as far as I can tell.
I suspect it has to do with shuffling around of tests, so it just
On 24.02.2010, at 11:47, David Levin wrote:
Actually, it doesn't appear to be do to recent changes in this area.
They started failing after r55177 (http://build.webkit.org/waterfall?last_time=1266975298
), but that change is unrelated to these test as far as I can tell.
It looks unrelated,
On Wed, Feb 24, 2010 at 12:02 PM, Alexey Proskuryakov a...@webkit.org wrote:
On 24.02.2010, at 11:47, David Levin wrote:
Actually, it doesn't appear to be do to recent changes in this area. They
started failing after r55177
(http://build.webkit.org/waterfall?last_time=1266975298), but that
1. It looks like you are a committer, so you don't need to wait for the
commit queue to do this for you :)
2. But it still would be good to have this fixed. If you'd like to help move
this along, you can go to http://build.webkit.org/waterfall and find which
patch caused the test to start
I find http://build.webkit.org/console more useful.
In this case, looks like mitz's patch changed the test:
http://trac.webkit.org/changeset/55203
I'm glad to see more folks are watching the bots!
-eric
On Wed, Feb 24, 2010 at 3:48 PM, David Levin le...@chromium.org wrote:
1. It looks like
That test is kinda tricky. The change isn't necessarily wrong. But
the patch appears to have changed what the DOM tree looks like (at
least in order) and thus exposed bugs in our JS bindings where some
objects aren't being created with the proper prototype chains.
Our JS bindings get cached
On Wed, Feb 24, 2010 at 3:48 PM, David Levin le...@chromium.org wrote:
1. It looks like you are a committer, so you don't need to wait for the
commit queue to do this for you :)
Understood -- but I prefer to use the bots where possible. I've seen
multiple instances where the commit scripts
What is a possible resolution? Can we temporarily disable the test to
unblock the commit queue?
-Ken
On Wed, Feb 24, 2010 at 3:53 PM, Eric Seidel e...@webkit.org wrote:
That test is kinda tricky. The change isn't necessarily wrong. But
the patch appears to have changed what the DOM tree
On Feb 24, 2010, at 3:50 PM, Eric Seidel wrote:
I find http://build.webkit.org/console more useful.
In this case, looks like mitz's patch changed the test:
http://trac.webkit.org/changeset/55203
Sorry about the inconvenience. I will try to fix this shortly.
I'm glad to see more folks
15 matches
Mail list logo
