Re: [webkit-dev] DFG, inline functions compileing

2012-06-19 Thread Nare Karapetyan
If the object file is meant by a cfg IR dump, then yes. Assume that all of repeated compilations are okay, but then again going through all the passes of the optimizations in caller function probably does not make sense. Or I'm not right? -- You Rock! Your E-Mail Should Too! Signup Now at

Re: [webkit-dev] DFG, inline functions compileing

2012-06-19 Thread Nare Karapetyan
And I think You talk about JSC compiling, not about DFG JIT work. -- You Rock! Your E-Mail Should Too! Signup Now at Rock.com and get 4GB of Storage! http://connections.rock.com/user/displayUserRegisterPage.kickAction?as=116748STATUS=MAIN ___

Re: [webkit-dev] DFG, inline functions compileing

2012-06-19 Thread Filip Pizlo
On Jun 19, 2012, at 5:04 AM, Nare Karapetyan wrote: If the object file is meant by a cfg IR dump, then yes. Assume that all of repeated compilations are okay, but then again going through all the passes of the optimizations in caller function probably does not make sense. Or I'm not right?

Re: [webkit-dev] DFG, inline functions compileing

2012-06-17 Thread Zoltan Herczeg
Where are they compiled twice? If in the object file, than it is ok, since the compiler must provide a standalone function for even inline ones. It is needed if the function is passed as pointer. These extra functions should be thrown out by the linker in the final binary. Regards, Zoltan It's

Re: [webkit-dev] DFG, inline functions compileing

2012-06-17 Thread Filip Pizlo
I'm not talking about the C++ compiler compiling the DFG. I'm instead referring to the DFG compiling JS code. -Filip On Jun 17, 2012, at 1:06 AM, Zoltan Herczeg zherc...@webkit.org wrote: Where are they compiled twice? If in the object file, than it is ok, since the compiler must provide a

[webkit-dev] DFG, inline functions compileing

2012-06-16 Thread Nare Karapetyan
Why in DFG inline functions are optimized(compiled) more than once - one time itself and then in caller function's body? -- You Rock! Your E-Mail Should Too! Signup Now at Rock.com and get 4GB of Storage! http://connections.rock.com/user/displayUserRegisterPage.kickAction?as=116748STATUS=MAIN

Re: [webkit-dev] DFG, inline functions compileing

2012-06-16 Thread Filip Pizlo
It's a bug. It's not a show stopper but if you've got a fix, I'd encourage you to submit a patch. -Filip On Jun 16, 2012, at 1:01 PM, Nare Karapetyan n...@rock.com wrote: Why in DFG inline functions are optimized(compiled) more than once - one time itself and then in caller function's