Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-10 Thread Adam Barth
On Wed, Oct 10, 2012 at 12:04 AM, Maciej Stachowiak m...@apple.com wrote: On Oct 9, 2012, at 1:50 PM, Adam Barth aba...@webkit.org wrote: That raises the question of what the cache-size to hit-rate curve looks like. I don't think that's something we've ever measured for the MemoryCache, but

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-10 Thread Maciej Stachowiak
On Oct 10, 2012, at 8:49 AM, Adam Barth aba...@webkit.org wrote: On Wed, Oct 10, 2012 at 12:04 AM, Maciej Stachowiak m...@apple.com wrote: On Oct 9, 2012, at 1:50 PM, Adam Barth aba...@webkit.org wrote: That raises the question of what the cache-size to hit-rate curve looks like. I don't

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-10 Thread Geoffrey Garen
My guess is that frequency of hits on given cache items approximately follows a power law distribution, and therefore increasing cache size gives diminishing returns. FWIW, a few years back I did some in-depth data gathering on this score using real world websites. I found that, for encoded

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-09 Thread Adam Barth
On Mon, Oct 8, 2012 at 6:21 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 8, 2012, at 5:28 PM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 2:17 PM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 12:17 PM, Adam Barth aba...@webkit.org wrote: Would there be any

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-09 Thread Antti Koivisto
On Tue, Oct 9, 2012 at 4:21 AM, Maciej Stachowiak m...@apple.com wrote: One preliminary finding of ours is that different web pages fairly often load identical resource bodies from different URLs. We expect possible benefits from sharing the body data of resources in memory even if we cannot

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-09 Thread Adam Barth
On Tue, Oct 9, 2012 at 7:52 AM, Antti Koivisto koivi...@iki.fi wrote: On Tue, Oct 9, 2012 at 4:21 AM, Maciej Stachowiak m...@apple.com wrote: One preliminary finding of ours is that different web pages fairly often load identical resource bodies from different URLs. We expect possible benefits

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-09 Thread Antti Koivisto
On Tue, Oct 9, 2012 at 10:02 PM, Adam Barth aba...@webkit.org wrote: This is interesting data, but it seems to be related to whether we should make the MemoryCache content addressable rather than whether we should use shared memory to back the MemoryCache when there are multiple WebProcesses.

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-09 Thread Adam Barth
On Tue, Oct 9, 2012 at 12:17 PM, Antti Koivisto koivi...@iki.fi wrote: On Tue, Oct 9, 2012 at 10:02 PM, Adam Barth aba...@webkit.org wrote: This is interesting data, but it seems to be related to whether we should make the MemoryCache content addressable rather than whether we should use

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-09 Thread Maciej Stachowiak
On Oct 9, 2012, at 1:24 PM, Adam Barth aba...@webkit.org wrote: On Tue, Oct 9, 2012 at 12:17 PM, Antti Koivisto koivi...@iki.fi wrote: On Tue, Oct 9, 2012 at 10:02 PM, Adam Barth aba...@webkit.org wrote: This is interesting data, but it seems to be related to whether we should make the

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-09 Thread Adam Barth
On Tue, Oct 9, 2012 at 1:31 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 9, 2012, at 1:24 PM, Adam Barth aba...@webkit.org wrote: On Tue, Oct 9, 2012 at 12:17 PM, Antti Koivisto koivi...@iki.fi wrote: On Tue, Oct 9, 2012 at 10:02 PM, Adam Barth aba...@webkit.org wrote: This is

[webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
A bit of background: A few of us have been working on enhancing WebKit2's support for multiple WebProcesses. As part of this effort I'm working on https://bugs.webkit.org/show_bug.cgi?id=98537 - Add a NetworkProcess to WebKit2 One benefit of the NetworkProcess will be to have a single shared

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Jochen Eisinger
Hey, can you share your plan how to prioritize network requests in the network process? It's a long standing issue of the chromium port (and I believe the blackberry port is affected as well) that a ResourceRequest doesn't know whether it was created for e.g. an XHR or a main document load,

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Adam Barth
When we looked at whether we should add a shared memory cache to Chromium, we came to the conclusion that there wasn't much benefit to having a shared memory cache. In https://bugs.webkit.org/show_bug.cgi?id=98541#c4, you mentioned that you have data showing that a shared memory cache is a win.

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
On Oct 8, 2012, at 10:58 AM, Adam Barth aba...@webkit.org wrote: When we looked at whether we should add a shared memory cache to Chromium, we came to the conclusion that there wasn't much benefit to having a shared memory cache. In https://bugs.webkit.org/show_bug.cgi?id=98541#c4, you

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
On Oct 8, 2012, at 10:52 AM, Jochen Eisinger joc...@chromium.org wrote: Hey, can you share your plan how to prioritize network requests in the network process? … We currently work around that issue by adding a TargetType to ResourceRequest which is however a layering violation which

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Adam Barth
On Mon, Oct 8, 2012 at 11:14 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 10:58 AM, Adam Barth aba...@webkit.org wrote: When we looked at whether we should add a shared memory cache to Chromium, we came to the conclusion that there wasn't much benefit to having a shared memory

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Alexey Proskuryakov
08.10.2012, в 11:23, Brady Eidson beid...@apple.com написал(а): On a slightly different note it seems reasonable to me that a WebCore ResourceRequest have target-type/priority-type information attached to it. I don't know if doing that has come up in the past and different conclusions we

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
On Oct 8, 2012, at 11:24 AM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:14 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 10:58 AM, Adam Barth aba...@webkit.org wrote: When we looked at whether we should add a shared memory cache to Chromium, we came to the

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Adam Barth
On Mon, Oct 8, 2012 at 11:49 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 11:24 AM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:14 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 10:58 AM, Adam Barth aba...@webkit.org wrote: When we looked at

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
On Oct 8, 2012, at 12:17 PM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:49 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 11:24 AM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:14 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Adam Barth
On Mon, Oct 8, 2012 at 2:17 PM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 12:17 PM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:49 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 11:24 AM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Maciej Stachowiak
On Oct 8, 2012, at 5:28 PM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 2:17 PM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 12:17 PM, Adam Barth aba...@webkit.org wrote: Would there be any design or implementation constraints on WebCore? For example, would