Re: [webkit-dev] Does anyone still use the TestFailures app?

2012-11-06 Thread Thiago Marcos P. Santos
On Mon, Nov 5, 2012 at 10:21 PM, Dirk Pranke  wrote:

> http://build.webkit.org/TestFailures/
>
> I think Adam Roben was working on this a year or so ago. It appears to
> be broken at the moment (it's likely that I broke it, in fact), but
> before I spend much time fixing it I thought I'd check.
>
> I've never actually used it myself, so I'm not sure what all it was
> supposed to do; it looks like it overlaps in functionality some with
> the flakiness dashboard, but was probably written before the flakiness
> dashboard worked with the build.webkit.org bots and everyone was
> converted to using NRWT.
>
> If anyone is still using it (or would if it was actually working) in
> preference to the flakiness dashboard, can you let me know why?
> Ideally I'd like to get rid of it and roll any good features it had
> into the flakiness dashboard, but I'm happy to fix it and/or keep it
> around if it does other things I'm not aware of or if people are still
> using it.
>
> Cheers,
>
> -- Dirk
>

I use it a lot. First stop when it is my gardening day.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Does anyone still use the TestFailures app?

2012-11-05 Thread Ojan Vafai
I agree. The question is what uses does TestFailures support that
garden-o-matic doesn't? I haven't used it much, so I don't have a sense of
what features garden-o-matic is missing.

The flakiness dashboard isn't really meant for figuring out what tests are
currently failing. But, if you have a specific test you want to quickly
lookup, you can append the test name to
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=.
It's been on my TODO list for a while to make it by default load a simpler
page that lets you just put in a test name instead of loading the data for
a random bot.


On Mon, Nov 5, 2012 at 12:52 PM, Simon Fraser wrote:

> I use it from time to time, but I think we really need merge it with
> garden-o-matic; they do much of the same stuff.
>
> Simon
>
> On Nov 5, 2012, at 12:21 PM, Dirk Pranke  wrote:
>
> > http://build.webkit.org/TestFailures/
> >
> > I think Adam Roben was working on this a year or so ago. It appears to
> > be broken at the moment (it's likely that I broke it, in fact), but
> > before I spend much time fixing it I thought I'd check.
> >
> > I've never actually used it myself, so I'm not sure what all it was
> > supposed to do; it looks like it overlaps in functionality some with
> > the flakiness dashboard, but was probably written before the flakiness
> > dashboard worked with the build.webkit.org bots and everyone was
> > converted to using NRWT.
> >
> > If anyone is still using it (or would if it was actually working) in
> > preference to the flakiness dashboard, can you let me know why?
> > Ideally I'd like to get rid of it and roll any good features it had
> > into the flakiness dashboard, but I'm happy to fix it and/or keep it
> > around if it does other things I'm not aware of or if people are still
> > using it.
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Does anyone still use the TestFailures app?

2012-11-05 Thread Eric Seidel
Entertainingly, Adam taught me to reach GOM through TestFailures:
http://build.webkit.org/TestFailures/garden-o-matic.html

On Mon, Nov 5, 2012 at 12:52 PM, Simon Fraser  wrote:
> I use it from time to time, but I think we really need merge it with 
> garden-o-matic; they do much of the same stuff.
>
> Simon
>
> On Nov 5, 2012, at 12:21 PM, Dirk Pranke  wrote:
>
>> http://build.webkit.org/TestFailures/
>>
>> I think Adam Roben was working on this a year or so ago. It appears to
>> be broken at the moment (it's likely that I broke it, in fact), but
>> before I spend much time fixing it I thought I'd check.
>>
>> I've never actually used it myself, so I'm not sure what all it was
>> supposed to do; it looks like it overlaps in functionality some with
>> the flakiness dashboard, but was probably written before the flakiness
>> dashboard worked with the build.webkit.org bots and everyone was
>> converted to using NRWT.
>>
>> If anyone is still using it (or would if it was actually working) in
>> preference to the flakiness dashboard, can you let me know why?
>> Ideally I'd like to get rid of it and roll any good features it had
>> into the flakiness dashboard, but I'm happy to fix it and/or keep it
>> around if it does other things I'm not aware of or if people are still
>> using it.
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Does anyone still use the TestFailures app?

2012-11-05 Thread Simon Fraser
I use it from time to time, but I think we really need merge it with 
garden-o-matic; they do much of the same stuff.

Simon

On Nov 5, 2012, at 12:21 PM, Dirk Pranke  wrote:

> http://build.webkit.org/TestFailures/
> 
> I think Adam Roben was working on this a year or so ago. It appears to
> be broken at the moment (it's likely that I broke it, in fact), but
> before I spend much time fixing it I thought I'd check.
> 
> I've never actually used it myself, so I'm not sure what all it was
> supposed to do; it looks like it overlaps in functionality some with
> the flakiness dashboard, but was probably written before the flakiness
> dashboard worked with the build.webkit.org bots and everyone was
> converted to using NRWT.
> 
> If anyone is still using it (or would if it was actually working) in
> preference to the flakiness dashboard, can you let me know why?
> Ideally I'd like to get rid of it and roll any good features it had
> into the flakiness dashboard, but I'm happy to fix it and/or keep it
> around if it does other things I'm not aware of or if people are still
> using it.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Does anyone still use the TestFailures app?

2012-11-05 Thread Dirk Pranke
On Mon, Nov 5, 2012 at 12:47 PM, Osztrogonac Csaba  wrote:
> Hi,
>
> We use it and http://build.webkit.sed.hu/TestFailures/ for gardening,
> it is the first step we usually do if determining who broke what about
> the waterfall isn't trivial.
>
> On http://build.webkit.sed.hu/TestFailures/ we use a very old copy
> of test failures and it still works fine.
>
> Dirk Pranke írta:
>
>> http://build.webkit.org/TestFailures/
>>
>> I think Adam Roben was working on this a year or so ago. It appears to
>> be broken at the moment (it's likely that I broke it, in fact), but
>> before I spend much time fixing it I thought I'd check.
>
>
> It works for me more or less, but I got strange link names:
> http/tests/security/cross-origin-plugin-private-browsing-toggled.html:
> [object DocumentFragment]
>
> Maybe one of the garden-o-matic patches broke it somehow.
>
>
>> I've never actually used it myself, so I'm not sure what all it was
>> supposed to do; it looks like it overlaps in functionality some with
>> the flakiness dashboard, but was probably written before the flakiness
>> dashboard worked with the build.webkit.org bots and everyone was
>> converted to using NRWT.
>
>
>> If anyone is still using it (or would if it was actually working) in
>> preference to the flakiness dashboard, can you let me know why?
>
> We still use it, because it is very simple, it works almost always,
> it isn't hakced day by day and its output is very very simple. We
> get the result - which revision broke a given test, which are the
> related bug reports - with _one_ click on the name of the slave.
>
> It is more complicated to do same thing on flakiness dashboard:
> - select webkit.org from group
> - select a given slave
> - select "tests with wrong expectations"
> - (unselect flaky)
> - find manually the last good revision for test by test
>   but it is _impossible_ if the breakage is too old
>
>
>> Ideally I'd like to get rid of it and roll any good features it had
>> into the flakiness dashboard, but I'm happy to fix it and/or keep it
>> around if it does other things I'm not aware of or if people are still
>> using it.
>
>
> Please don't remove this good and simple tool, we use it day by day.
>

Thanks, Ossy! I guess I'll figure out how to fix it and go from there :).

-- Dirk
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Does anyone still use the TestFailures app?

2012-11-05 Thread Osztrogonac Csaba

Hi,

We use it and http://build.webkit.sed.hu/TestFailures/ for gardening,
it is the first step we usually do if determining who broke what about
the waterfall isn't trivial.

On http://build.webkit.sed.hu/TestFailures/ we use a very old copy
of test failures and it still works fine.

Dirk Pranke írta:

http://build.webkit.org/TestFailures/

I think Adam Roben was working on this a year or so ago. It appears to
be broken at the moment (it's likely that I broke it, in fact), but
before I spend much time fixing it I thought I'd check.


It works for me more or less, but I got strange link names:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html: [object 
DocumentFragment]

Maybe one of the garden-o-matic patches broke it somehow.


I've never actually used it myself, so I'm not sure what all it was
supposed to do; it looks like it overlaps in functionality some with
the flakiness dashboard, but was probably written before the flakiness
dashboard worked with the build.webkit.org bots and everyone was
converted to using NRWT.



If anyone is still using it (or would if it was actually working) in
preference to the flakiness dashboard, can you let me know why?

We still use it, because it is very simple, it works almost always,
it isn't hakced day by day and its output is very very simple. We
get the result - which revision broke a given test, which are the
related bug reports - with _one_ click on the name of the slave.

It is more complicated to do same thing on flakiness dashboard:
- select webkit.org from group
- select a given slave
- select "tests with wrong expectations"
- (unselect flaky)
- find manually the last good revision for test by test
  but it is _impossible_ if the breakage is too old


Ideally I'd like to get rid of it and roll any good features it had
into the flakiness dashboard, but I'm happy to fix it and/or keep it
around if it does other things I'm not aware of or if people are still
using it.


Please don't remove this good and simple tool, we use it day by day.

br,
Ossy
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Does anyone still use the TestFailures app?

2012-11-05 Thread Dirk Pranke
http://build.webkit.org/TestFailures/

I think Adam Roben was working on this a year or so ago. It appears to
be broken at the moment (it's likely that I broke it, in fact), but
before I spend much time fixing it I thought I'd check.

I've never actually used it myself, so I'm not sure what all it was
supposed to do; it looks like it overlaps in functionality some with
the flakiness dashboard, but was probably written before the flakiness
dashboard worked with the build.webkit.org bots and everyone was
converted to using NRWT.

If anyone is still using it (or would if it was actually working) in
preference to the flakiness dashboard, can you let me know why?
Ideally I'd like to get rid of it and roll any good features it had
into the flakiness dashboard, but I'm happy to fix it and/or keep it
around if it does other things I'm not aware of or if people are still
using it.

Cheers,

-- Dirk
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev