Re: [webkit-dev] EFL and GTK on Darwin
On Feb 11, 2014, at 12:29 AM, Žan Doberšek wrote: > Hi. > > On Mon, Feb 10, 2014 at 6:30 PM, Dan Bernstein wrote: > Hi everyone, and especially EFL and GTK contributors! > > In preparation for changing PLATFORM(MAC) to be false when building for iOS, > I have been reviewing usage of PLATFORM(MAC) throughout our codebase. Some of > these uses are really about targeting the Darwin OS. However, I could not > simply replace PLATFORM(MAC) with OS(DARWIN), because the latter also > encompasses the EFL and GTK platforms when building for Darwin (which the > former does not). Therefore, thus far I have replaced relevant instances of > PLATFORM(MAC) with (OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK)). > > Just to be clear, this is about code that's not appropriate to guard with > PLATFORM(COCOA)? Yup. > > > This is ugly and seems like a waste of time, so I was wondering: > > 1. Is there a configuration of the EFL port that actually builds for Darwin? > > 2. Is there a configuration of the GTK port that actually builds for Darwin? > > Yes, this configuration is supported by the GTK port through the MacPorts > project. Jeremy Huddleston regularly upstreams modifications to properly > support building the GTK port on Darwin. > > > 3. If such configuration(s) exist, would it be OK for them to use Darwin when > building for Darwin? > > This could be possible, but it depends really on the code in question. Jeremy > would probably be the best candidate to exactly tell you whether the new code > is viable to use for the GTK port on Darwin. > > > If the answer to 1 and 2 is no, or if the answer to 3 is yes, then I will > simply use OS(DARWIN) to replace PLATFORM(MAC) where that is the intent, and, > depending on the answers to 1 and 2, update the EFL and GTK build systems to > include the Darwin-based implementations where needed. > > Thanks! > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EFL and GTK on Darwin
Hi. On Mon, Feb 10, 2014 at 6:30 PM, Dan Bernstein wrote: > Hi everyone, and especially EFL and GTK contributors! > > In preparation for changing PLATFORM(MAC) to be false when building for > iOS, I have been reviewing usage of PLATFORM(MAC) throughout our > codebase. Some of these uses are really about targeting the Darwin OS. > However, I could not simply replace PLATFORM(MAC) with OS(DARWIN), > because the latter also encompasses the EFL and GTK platforms when building > for Darwin (which the former does not). Therefore, thus far I have replaced > relevant instances of PLATFORM(MAC) with (OS(DARWIN) && !PLATFORM(EFL) && > !PLATFORM(GTK)). > Just to be clear, this is about code that's not appropriate to guard with PLATFORM(COCOA)? > This is ugly and seems like a waste of time, so I was wondering: > > 1. Is there a configuration of the EFL port that actually builds for > Darwin? > > 2. Is there a configuration of the GTK port that actually builds for > Darwin? > Yes, this configuration is supported by the GTK port through the MacPorts project. Jeremy Huddleston regularly upstreams modifications to properly support building the GTK port on Darwin. > > 3. If such configuration(s) exist, would it be OK for them to use Darwin > when building for Darwin? > This could be possible, but it depends really on the code in question. Jeremy would probably be the best candidate to exactly tell you whether the new code is viable to use for the GTK port on Darwin. > > If the answer to 1 and 2 is no, or if the answer to 3 is yes, then I will > simply use OS(DARWIN) to replace PLATFORM(MAC) where that is the intent, > and, depending on the answers to 1 and 2, update the EFL and GTK build > systems to include the Darwin-based implementations where needed. > > Thanks! > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EFL and GTK on Darwin
On Mon, Feb 10, 2014 at 06:30:52PM -0800, Dan Bernstein wrote: > 2. Is there a configuration of the GTK port that actually builds for > Darwin? I have never tried it myself, but it works as far as I know, and there seems to be someone from Apple working on it: https://bugs.webkit.org/show_bug.cgi?id=126492 We've been trying to help him integrate all the necessary fixes to make the upstream code build in Darwin. If renaming PLATFORM(MAC) with OS(DARWIN) breaks something else we can use that meta-bug to track those problems. Berto ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EFL and GTK on Darwin
Hello Dan, >> 1. Is there a configuration of the EFL port that actually builds for Darwin? Unfortunately(?), AFAIK, WebKit EFL port doesn't support Darwin OS yet. Gyuyoung. On Tue, Feb 11, 2014 at 11:30 AM, Dan Bernstein wrote: > Hi everyone, and especially EFL and GTK contributors! > > In preparation for changing PLATFORM(MAC) to be false when building for > iOS, I have been reviewing usage of PLATFORM(MAC) throughout our > codebase. Some of these uses are really about targeting the Darwin OS. > However, I could not simply replace PLATFORM(MAC) with OS(DARWIN), > because the latter also encompasses the EFL and GTK platforms when building > for Darwin (which the former does not). Therefore, thus far I have replaced > relevant instances of PLATFORM(MAC) with (OS(DARWIN) && !PLATFORM(EFL) && > !PLATFORM(GTK)). > > This is ugly and seems like a waste of time, so I was wondering: > > 1. Is there a configuration of the EFL port that actually builds for > Darwin? > > 2. Is there a configuration of the GTK port that actually builds for > Darwin? > > 3. If such configuration(s) exist, would it be OK for them to use Darwin > when building for Darwin? > > If the answer to 1 and 2 is no, or if the answer to 3 is yes, then I will > simply use OS(DARWIN) to replace PLATFORM(MAC) where that is the intent, > and, depending on the answers to 1 and 2, update the EFL and GTK build > systems to include the Darwin-based implementations where needed. > > Thanks! > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] EFL and GTK on Darwin
Hi everyone, and especially EFL and GTK contributors! In preparation for changing PLATFORM(MAC) to be false when building for iOS, I have been reviewing usage of PLATFORM(MAC) throughout our codebase. Some of these uses are really about targeting the Darwin OS. However, I could not simply replace PLATFORM(MAC) with OS(DARWIN), because the latter also encompasses the EFL and GTK platforms when building for Darwin (which the former does not). Therefore, thus far I have replaced relevant instances of PLATFORM(MAC) with (OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK)). This is ugly and seems like a waste of time, so I was wondering: 1. Is there a configuration of the EFL port that actually builds for Darwin? 2. Is there a configuration of the GTK port that actually builds for Darwin? 3. If such configuration(s) exist, would it be OK for them to use Darwin when building for Darwin? If the answer to 1 and 2 is no, or if the answer to 3 is yes, then I will simply use OS(DARWIN) to replace PLATFORM(MAC) where that is the intent, and, depending on the answers to 1 and 2, update the EFL and GTK build systems to include the Darwin-based implementations where needed. Thanks! ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
