Re: [webkit-dev] ENABLE(PAGE_POPUP) in WebCore

2013-05-20 Thread Anders Carlsson
On May 20, 2013, at 5:00 AM, Carlos Garcia Campos wrote: > El lun, 20-05-2013 a las 10:51 +0200, arvid2.nils...@gmail.com escribió: >> Hi there! >> >> >> This seems like a very reasonable request, the popups (used by the >> BlackBerry port to implement various pickers) seem to be mostly a >> W

Re: [webkit-dev] ENABLE(PAGE_POPUP) in WebCore

2013-05-20 Thread Carlos Garcia Campos
8:36 PM > To: WebKit Development > Subject: [webkit-dev] ENABLE(PAGE_POPUP) in WebCore > > > Hi everyone, > > I was looking at the PagePopup code and it seems to be BlackBerry > specific. Furthermore, it seems to only be called from inside > BlackBerry WebKit. > > Woul

Re: [webkit-dev] ENABLE(PAGE_POPUP) in WebCore

2013-05-20 Thread arvid2 . nilsson
Hi there!This seems like a very reasonable request, the popups (used by the BlackBerry port to implement various pickers) seem to be mostly a WebKit concern, and we don't really seem to use any of the PAGE_POPUP related plumbing in WebCore.BR,/Arvid

[webkit-dev] ENABLE(PAGE_POPUP) in WebCore

2013-05-19 Thread Anders Carlsson
Hi everyone, I was looking at the PagePopup code and it seems to be BlackBerry specific. Furthermore, it seems to only be called from inside BlackBerry WebKit. Would it be possible to just move the code into WebKit/blackberry instead? I think someone with access to a BlackBerry build environmen