Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-15 Thread Adam Barth
Thanks for the feedback thus far. I'm going to start working on some of the changes I perceive as less controversial. Please feel free to comment on bugs or reply to this thread if you have additional thoughts. The meta bug for this work is https://bugs.webkit.org/show_bug.cgi?id=68012. Adam

Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-15 Thread Adam Barth
On Wed, Sep 14, 2011 at 11:06 PM, Darin Fisher wrote: > On Wed, Sep 14, 2011 at 3:40 PM, Adam Barth wrote: >> >> I've updated the spreadsheet of all ENABLE flags to match TOT (as of >> this afternoon): >> >> https://docs.google.com/spreadsheet/ccc?key=0AlC4tS7Ao1fIdHFVNUpFSDBudEF5WGM3WDNzQjI3Ync&

Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-15 Thread Adam Barth
On Sep 15, 2011 12:56 AM, "Simon Hausmann" wrote: > > On Thursday, September 15, 2011 12:40:41 AM ext Adam Barth wrote: > [...] > > == Always Disable (Delete Code) == > > > > ENABLE(ICONDATABASE) ??? > > Hmm, I see Mac, Qt and EFL use the icon database in WebCore/loader/icon to retrieve > favicons

Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-14 Thread noam . rosenthal
On Sep 15, 2011, at 3:25 AM, ext Adam Barth wrote: > I wonder if we should combine all the flags that are disabled only to > reduce binary size. One thing that can be done, is to combine them in the build-bot level, like the --minimal flag in build-webkit. Combining flags to something cryptic li

Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-14 Thread Darin Fisher
On Wed, Sep 14, 2011 at 3:40 PM, Adam Barth wrote: > I've updated the spreadsheet of all ENABLE flags to match TOT (as of > this afternoon): > > > https://docs.google.com/spreadsheet/ccc?key=0AlC4tS7Ao1fIdHFVNUpFSDBudEF5WGM3WDNzQjI3Ync&authkey=CJCDiooK&hl=en_US#gid=0 > > I've gone through the lis

Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-14 Thread Adam Barth
I wonder if we should combine all the flags that are disabled only to reduce binary size. Adam On Wed, Sep 14, 2011 at 5:21 PM, Loïc Yhuel wrote: > Do we know what would be the code size increase due to enabling all these > flags ? > Library size can be a constraint on embedded systems. > > ENA

Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-14 Thread Loïc Yhuel
Do we know what would be the code size increase due to enabling all these flags ? Library size can be a constraint on embedded systems. ENABLE(INSPECTOR) : On many embedded systems, it won't be used (except during development), and would be blocked by the firewall or stubbed for security reaso

Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-14 Thread Adam Barth
On Wed, Sep 14, 2011 at 4:14 PM, Ryosuke Niwa wrote: > On Wed, Sep 14, 2011 at 3:40 PM, Adam Barth wrote: >> >> ENABLE(SVG_ANIMATION) => Gated on ENABLE(SVG) >> ENABLE(SVG_AS_IMAGE) => Gated on ENABLE(SVG) >> ENABLE(SVG_DOM_OBJC_BINDINGS) => Gated on ENABLE(SVG) >> ENABLE(SVG_FONTS) => Gated on E

Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-14 Thread Ryosuke Niwa
On Wed, Sep 14, 2011 at 3:40 PM, Adam Barth wrote: > > ENABLE(SVG_ANIMATION) => Gated on ENABLE(SVG) > ENABLE(SVG_AS_IMAGE) => Gated on ENABLE(SVG) > ENABLE(SVG_DOM_OBJC_BINDINGS) => Gated on ENABLE(SVG) > ENABLE(SVG_FONTS) => Gated on ENABLE(SVG) > I think Eric is planning to get rid of these fl

Re: [webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-14 Thread James Robinson
== Always Enable == > > ENABLE(DETAILS) ??? > ENABLE(DOM_STORAGE) > ENABLE(EVENTSOURCE) > ENABLE(INSPECTOR) ??? > ENABLE(METER_TAG) > ENABLE(OFFLINE_WEB_APPLICATIONS) > ENABLE(PROGRESS_TAG) > ENABLE(SVG_ANIMATION) => Gated on ENABLE(SVG) > ENABLE(SVG_AS_IMAGE) => Gated on ENABLE(SVG) > ENABLE(SVG_

[webkit-dev] ENABLE flag cleanup strawman proposal

2011-09-14 Thread Adam Barth
I've updated the spreadsheet of all ENABLE flags to match TOT (as of this afternoon): https://docs.google.com/spreadsheet/ccc?key=0AlC4tS7Ao1fIdHFVNUpFSDBudEF5WGM3WDNzQjI3Ync&authkey=CJCDiooK&hl=en_US#gid=0 I've gone through the list and marked some of them that we might want to change, listed be