Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-12-03 Thread Ryosuke Niwa
Great. I've completed the survey. - R. Niwa On Mon, Dec 2, 2019 at 5:19 PM Aakash Jain wrote: > There were multiple ideas discussed in this thread. I would like to gather > more data about what do most people prefer. I have sent out a short survey > in

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-12-02 Thread Aakash Jain
There were multiple ideas discussed in this thread. I would like to gather more data about what do most people prefer. I have sent out a short survey in https://lists.webkit.org/pipermail/webkit-dev/2019-December/030980.html

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-05 Thread Devin Rousso
Hi, I may be alone here, but I actually found build/test(s) failure emails to be super useful. The part that I did not find useful was that each time a build/test(s) would fail on a particular platform, there would be two comments/emails, which furthermore split the useful information into

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-05 Thread Alexey Proskuryakov
> 4 нояб. 2019 г., в 1:37 PM, Ryosuke Niwa написал(а): > > > On Mon, Nov 4, 2019 at 9:40 AM Alexey Proskuryakov > wrote: > > Can you elaborate on that, how exactly is e-mailing on first failure useful > to reviewers? > > Getting rid of Bugzilla comments was one of

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-04 Thread Ryosuke Niwa
On Mon, Nov 4, 2019 at 9:40 AM Alexey Proskuryakov wrote: > > Can you elaborate on that, how exactly is e-mailing on first failure > useful to reviewers? > > Getting rid of Bugzilla comments was one of the goals of EWS rewrite, > based on engineering feedback about noise in bugs and in e-mail,

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-04 Thread Alexey Proskuryakov
Can you elaborate on that, how exactly is e-mailing on first failure useful to reviewers? Getting rid of Bugzilla comments was one of the goals of EWS rewrite, based on engineering feedback about noise in bugs and in e-mail, and I wholeheartedly agree with this feedback. So I think that

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-03 Thread Maciej Stachowiak
I think they are useful to actual and potential reviewers. Direct email to the patch author is not something anyone can Cc themselves on, and is not archived, so seems like a strictly worse form of communication. > On Nov 2, 2019, at 9:34 AM, Alexey Proskuryakov wrote: > > > My preference

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-02 Thread Alexey Proskuryakov
My preference is still e-mailing the patch author directly (possibly, also having an option to opt in for anyone). Bugzilla comments will always be irrelevant for most people CC'ed on the bug, and they are almost always undesirable to keep within the discussion flow. - Alexey > 1 нояб. 2019

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-01 Thread Aakash Jain
Sounds good. I prefer the single comment when the first failure occur. That way notification would be sent as soon as the first failure happens. I'll implement that (assuming it's acceptable to everyone). Thanks Aakash > On Nov 1, 2019, at 8:35 PM, Maciej Stachowiak wrote: > > > How about

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-01 Thread Maciej Stachowiak
How about only a single comment when the first failure occurs? (Or else when all bots pass, if there is never a failure.) This should help the author, the reviewer, and anyone else cc’d, without being too spammy. > On Nov 1, 2019, at 5:20 PM, Aakash Jain wrote: > > Hi Ryosuke, > > Many

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-01 Thread Aakash Jain
Hi Ryosuke, Many people didn't like the noise by the EWS comments, and we removed the comments as per previous discussion in: https://lists.webkit.org/pipermail/webkit-dev/2019-June/030683.html. I agree with your point that having some kind of notification might be useful. I proposed some