Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2021-06-09 Thread David Bokan via webkit-dev
+1 that this seems like a really nice fit for text fragments, even if it's only to reuse the text-matching implementation. By way of an update, Chrome is rolling out a "copy-link-to-text" context menu item (a built-in version of the earlier discussed extension):

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2021-06-09 Thread Thomas Steiner via webkit-dev
On Wed, Jun 9, 2021 at 6:27 PM Megan Gardner wrote: > We are store the explicite range/position information in the associated > note, and also use text matching as a fallback. > Thanks for responding! Any desire to adopt the Text Fragment syntax ( https://web.dev/text-fragments/) for the

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2021-06-09 Thread Megan Gardner via webkit-dev
We are store the explicite range/position information in the associated note, and also use text matching as a fallback. Megan Gardner > On Jun 8, 2021, at 2:24 AM, Thomas Steiner via webkit-dev > wrote: > > Hi all, > > Seems like Quick Notes, announced at WWDC2021 (deep-link: >

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2021-06-08 Thread Thomas Steiner via webkit-dev
Hi all, Seems like Quick Notes, announced at WWDC2021 (deep-link: https://youtu.be/0TD96VTf0Xs?t=2832), implements the behavior of Text Fragments, including the highlighting part and the disambiguation of duplicate texts (see my screencast https://youtu.be/4MzxJGZvt1Y). I fail to reverse-engineer

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2021-01-07 Thread David Bokan via webkit-dev
Post-holiday ping. On Mon, Nov 23, 2020 at 8:44 PM David Bokan wrote: > Friendly ping - have the above changes addressed the concerns? > > On Mon, Nov 16, 2020 at 6:57 PM David Bokan wrote: > >> Hey Maciej/Ryosuke, >> >> I've updated the spec to be more precise around stripping the fragment >>

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-11-23 Thread David Bokan via webkit-dev
Friendly ping - have the above changes addressed the concerns? On Mon, Nov 16, 2020 at 6:57 PM David Bokan wrote: > Hey Maciej/Ryosuke, > > I've updated the spec to be more precise around stripping the fragment > directive. Specifically, section 3.3.1 >

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-11-20 Thread Rune Lillesveen via webkit-dev
Hi, Blink now has an intent to ship[1] for the `::target-text` selector as specified in css-pseudo[2] which supports styling the text fragment highlight. [1] https://groups.google.com/a/chromium.org/g/blink-dev/c/yN2lrq67a1c/m/_Giqh2g_AwAJ [2]

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-11-16 Thread David Bokan via webkit-dev
Hey Maciej/Ryosuke, I've updated the spec to be more precise around stripping the fragment directive. Specifically, section 3.3.1 is fleshed out and makes the implications explicit, via examples, about how various

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-11-11 Thread David Bokan via webkit-dev
Thanks Maciej, that's helpful feedback. I'll work on the spec text to clarify all these cases and circle back when that's done. On Sun, Nov 1, 2020 at 8:24 PM Maciej Stachowiak wrote: > > > On Oct 30, 2020, at 1:40 PM, David Bokan wrote: > > Hi Ryosuke, > > Would just like to clarify one

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-11-01 Thread Maciej Stachowiak
> On Oct 30, 2020, at 1:40 PM, David Bokan wrote: > > Hi Ryosuke, > > Would just like to clarify one point. > > On Fri, Sep 25, 2020 at 12:42 PM David Bokan > wrote: > [Sorry, meant to reply-all] > > On Fri, Sep 25, 2020 at 1:25 AM Ryosuke Niwa

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-10-30 Thread David Bokan
Hi Ryosuke, Would just like to clarify one point. On Fri, Sep 25, 2020 at 12:42 PM David Bokan wrote: > [Sorry, meant to reply-all] > > On Fri, Sep 25, 2020 at 1:25 AM Ryosuke Niwa wrote: > >> >> On Thu, Sep 24, 2020 at 8:19 AM David Bokan wrote: >> >>> Can you clarify what question you’re

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-25 Thread David Bokan
[Sorry, meant to reply-all] On Fri, Sep 25, 2020 at 1:25 AM Ryosuke Niwa wrote: > > On Thu, Sep 24, 2020 at 8:19 AM David Bokan wrote: > >> Can you clarify what question you’re looking to have answered? Are you >>> asking for a new standards position in light of the replies below? >>> >> >>

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-24 Thread Ryosuke Niwa
On Thu, Sep 24, 2020 at 8:19 AM David Bokan wrote: > Can you clarify what question you’re looking to have answered? Are you >> asking for a new standards position in light of the replies below? >> > > There are two specific points: > > - As I understand it, HTML requires multi-vendor interest

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-24 Thread David Bokan
On Wed, Sep 23, 2020 at 3:20 AM Ryosuke Niwa wrote: > > On Fri, Sep 18, 2020 at 7:35 AM David Bokan wrote: > >> Friendly ping to get an answer here. >> >> Do my answers above address those points or is there anything else I can >> clarify? >> >> Thanks, >> David >> >> On Mon, Aug 31, 2020 at

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-24 Thread David Bokan
> > Can you clarify what question you’re looking to have answered? Are you > asking for a new standards position in light of the replies below? > There are two specific points: - As I understand it, HTML requires multi-vendor interest to merge changes to specs. Is Apple's position sufficient

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-24 Thread Maciej Stachowiak
Can you clarify what question you’re looking to have answered? Are you asking for a new standards position in light of the replies below? - Maciej > On Sep 18, 2020, at 7:35 AM, David Bokan wrote: > > Friendly ping to get an answer here. > > Do my answers above address those points or is

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-23 Thread Ryosuke Niwa
On Fri, Sep 18, 2020 at 7:35 AM David Bokan wrote: > Friendly ping to get an answer here. > > Do my answers above address those points or is there anything else I can > clarify? > > Thanks, > David > > On Mon, Aug 31, 2020 at 1:42 PM David Bokan wrote: > >> [sending (again, sorry) from correct

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-18 Thread David Bokan
Friendly ping to get an answer here. Do my answers above address those points or is there anything else I can clarify? Thanks, David On Mon, Aug 31, 2020 at 1:42 PM David Bokan wrote: > [sending (again, sorry) from correct e-mail] > > I think Nick's replies >

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-08-31 Thread David Bokan
[sending (again, sorry) from correct e-mail] I think Nick's replies mostly still apply, some updated answers to those questions. (1) We’re concerned about compatibility issues in a world where some > browsers support this

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-08-31 Thread Darin Adler
> On Aug 31, 2020, at 9:33 AM, David Bokan wrote: > > We've made lots of improvements to the spec, notably around issues raised in > Mozilla's standards-position > . Do you think those improvements address Maciej’s concerns from last

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-08-31 Thread David Bokan
[Sending from correct account this time and on root thread] Hello WebKit-dev, Bumping this thread to give/get an update. Text-fragments shipped in Chrome M80. We've made lots of improvements to the spec, notably around issues raised in Mozilla's standards-position

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2019-12-13 Thread Maciej Stachowiak
> On Dec 11, 2019, at 12:48 PM, Nick Burris wrote: > > Hi Maciej, > Thanks for the reply! David's away this week, my responses are inline: > (1) We’re concerned about compatibility issues in a world where some browsers > support this but not all. Aware browsers will strip `:~:`, but unaware

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2019-12-11 Thread Nick Burris
Hi Maciej, Thanks for the reply! David's away this week, my responses are inline: (1) We’re concerned about compatibility issues in a world where some browsers support this but not all. Aware browsers will strip `:~:`, but unaware browsers won’t. I saw that on the blink-dev ItS thread, it was

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2019-12-11 Thread Maciej Stachowiak
Hi David, Apple folks have discussed this internally. In general, we think this is useful functionality to expose. Some points of feedback (let me know if any of these should be filed as an issue against the spec): (1) We’re concerned about compatibility issues in a world where some browsers

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2019-12-10 Thread Frédéric Wang
On 02/12/2019 21:22, David Bokan wrote: > Hello webkit-dev, > > I'd like to solicit feedback as well as an official position from > Webkit on our proposal for the text fragment > directive: https://github.com/WICG/ScrollToTextFragment. > > In summary: this is a feature that allows authors and

[webkit-dev] Feedback on Blink's text fragment directive proposal

2019-12-02 Thread David Bokan
Hello webkit-dev, I'd like to solicit feedback as well as an official position from Webkit on our proposal for the text fragment directive: https://github.com/WICG/ScrollToTextFragment. In summary: this is a feature that allows authors and users to craft URLs to pages and specify a snippet of