[webkit-dev] Frame and FrameView references

2008-02-29 Thread Artem Ananiev
Hi, all, I have noticed the following strange code in Frame class: Frame::~Frame() { setView(0); ... if (d-m_view) { d-m_view-hide(); d-m_view-clearFrame(); } ... } It is clear that the latter statements are never executed as d-m_view is always NULL

Re: [webkit-dev] Frame and FrameView references

2008-02-29 Thread Darin Adler
On Feb 29, 2008, at 4:25 AM, Artem Ananiev wrote: setView(0); ... if (d-m_view) { d-m_view-hide(); d-m_view-clearFrame(); } Good catch. This is all dead code and should be replaced with an assertion: ASSERT(!d-m_view); How this situation is