Re: [webkit-dev] Fwd: Using WebKit's markup as facility of Chrome's DOM serializer

2008-11-21 Thread Darin Adler
On Nov 21, 2008, at 1:21 AM, Johnny Ding wrote: OK, How about my first step is creating a new class to hold all parameters current for mark-up code. After then I will incrementally implement above 5 feature one by one. Is it workable? Thanks. Yes, I think it would be good for you to star

Re: [webkit-dev] Fwd: Using WebKit's markup as facility of Chrome's DOM serializer

2008-11-21 Thread Johnny Ding
2008/11/20 Darin Adler <[EMAIL PROTECTED]> > On Nov 20, 2008, at 6:47 AM, Johnny Ding wrote: > > Now should I file a new bug on https://bugs.webkit.org/ for improving >> markup, then write the patch and send to you (plus someone else I should >> involve) for review? Is that a right process? >> >

Re: [webkit-dev] Fwd: Using WebKit's markup as facility of Chrome's DOM serializer

2008-11-20 Thread Geoffrey Garen
Now should I file a new bug on https://bugs.webkit.org/ for improving markup, then write the patch and send to you (plus someone else I should involve) for review? Is that a right process? Yes, that's right. But you shouldn't target the patches at a specific person for review unless it's a

Re: [webkit-dev] Fwd: Using WebKit's markup as facility of Chrome's DOM serializer

2008-11-20 Thread Darin Adler
On Nov 20, 2008, at 9:32 AM, Darin Adler wrote: On Nov 20, 2008, at 6:47 AM, Johnny Ding wrote: Now should I file a new bug on https://bugs.webkit.org/ for improving markup, then write the patch and send to you (plus someone else I should involve) for review? Is that a right process? Yes,

Re: [webkit-dev] Fwd: Using WebKit's markup as facility of Chrome's DOM serializer

2008-11-20 Thread Darin Adler
On Nov 20, 2008, at 6:47 AM, Johnny Ding wrote: Now should I file a new bug on https://bugs.webkit.org/ for improving markup, then write the patch and send to you (plus someone else I should involve) for review? Is that a right process? Yes, that's right. But you shouldn't target the patche

Re: [webkit-dev] Fwd: Using WebKit's markup as facility of Chrome's DOM serializer

2008-11-20 Thread Johnny Ding
Hi Darin, Thanks very much for your comments. I am glad I have chance to introduce those features into WebKit. MarkupClient interface is the interface for markup extensibility. Also all those five features will be implemented inside Markup, But I think each of them have different request. For feat

Re: [webkit-dev] Fwd: Using WebKit's markup as facility of Chrome's DOM serializer

2008-11-19 Thread Darin Adler
On Nov 18, 2008, at 12:45 AM, Johnny Ding wrote: For adding above features to markup. I think we can define a abstract class called MarkupClient I think it's fine to add a client interface to make the markup machinery extensible. But the five features you're talking about above seem to al

[webkit-dev] Fwd: Using WebKit's markup as facility of Chrome's DOM serializer

2008-11-18 Thread Johnny Ding
Hello Everyone, This is Johnny from Google Beijing office. I had implemented the DomSerializer for Chrome. Now as Darin discussed with you guys before, we decide to use WebKit's markup as facility of Chrome's DOM serializer. I am very glad that I can continue working on it with you WebKit-develope