Re: [webkit-dev] Have EWS compile patches that are review+ once it is done with the ones that are review?
Yeah, the problem with that is: def fetch_patches_from_pending_commit_list(self): return sum([self._fetch_bug(bug_id).reviewed_patches() for bug_id in self.fetch_bug_ids_from_pending_commit_list()], []) which means each EWS bot is going to poll ~90 bugs every 2 minutes. For each bug, it's going to hit the bug page and the attachment page for a total of 16 queries per second... IMHO, we're better off moving the list of patches to process to AppEngine. In that model, we'll have one query every thirty seconds on bugs.webkit.org for the whole EWS, no matter how many bots we have. Adam On Fri, Sep 24, 2010 at 11:44 AM, Eric Seidel wrote: > On Fri, Sep 24, 2010 at 11:42 AM, Eric Seidel wrote: >> https://bugs.webkit.org/show_bug.cgi?id=35460 >> >> On Fri, Sep 24, 2010 at 10:25 AM, Darin Adler wrote: >>> It’s not great that if I review a patch that means it won’t get EWS >>> results. Maybe the EWS could be changed to test out “review+” patches once >>> it gets done with all the “review?” patches? >>> >>> Is that practical? >>> >>> -- Darin >>> >>> ___ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> >> > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Have EWS compile patches that are review+ once it is done with the ones that are review?
On Fri, Sep 24, 2010 at 11:42 AM, Eric Seidel wrote: > https://bugs.webkit.org/show_bug.cgi?id=35460 > > On Fri, Sep 24, 2010 at 10:25 AM, Darin Adler wrote: >> It’s not great that if I review a patch that means it won’t get EWS results. >> Maybe the EWS could be changed to test out “review+” patches once it gets >> done with all the “review?” patches? >> >> Is that practical? >> >> -- Darin >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Have EWS compile patches that are review+ once it is done with the ones that are review?
On Fri, Sep 24, 2010 at 10:59 AM, Adam Barth wrote: > Eric and I have slowly been making progress on this problem. The > underlying issue is that there does seem to be a bugzilla query for *doesn't > quite the right set of things (Eric knows the details here). To make > this work, we're shifting the list of patches to analyze over to our > AppEngine instance. So far, we've moved the commit-queue to this > model, which lets us run three instances of the commit-queue in > parallel, making it more of a "commit-cluster." > > Moving the EWS over to this model is probably one or two days more > work. Hopefully that should be done sometime next week. > > Adam > > > On Fri, Sep 24, 2010 at 10:25 AM, Darin Adler wrote: >> It’s not great that if I review a patch that means it won’t get EWS results. >> Maybe the EWS could be changed to test out “review+” patches once it gets >> done with all the “review?” patches? >> >> Is that practical? >> >> -- Darin >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Have EWS compile patches that are review+ once it is done with the ones that are review?
Eric and I have slowly been making progress on this problem. The underlying issue is that there does seem to be a bugzilla query for quite the right set of things (Eric knows the details here). To make this work, we're shifting the list of patches to analyze over to our AppEngine instance. So far, we've moved the commit-queue to this model, which lets us run three instances of the commit-queue in parallel, making it more of a "commit-cluster." Moving the EWS over to this model is probably one or two days more work. Hopefully that should be done sometime next week. Adam On Fri, Sep 24, 2010 at 10:25 AM, Darin Adler wrote: > It’s not great that if I review a patch that means it won’t get EWS results. > Maybe the EWS could be changed to test out “review+” patches once it gets > done with all the “review?” patches? > > Is that practical? > > -- Darin > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Have EWS compile patches that are review+ once it is done with the ones that are review?
If they are r+'ed, there is a big change that they are soon to become committed, so maybe they should get even more priority? Kenneth On Fri, Sep 24, 2010 at 2:25 PM, Darin Adler wrote: > It’s not great that if I review a patch that means it won’t get EWS results. > Maybe the EWS could be changed to test out “review+” patches once it gets > done with all the “review?” patches? > > Is that practical? > > -- Darin > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > -- Kenneth Rohde Christiansen Technical Lead / Senior Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org http://codeposts.blogspot.com ﹆﹆﹆ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Have EWS compile patches that are review+ once it is done with the ones that are review?
It’s not great that if I review a patch that means it won’t get EWS results. Maybe the EWS could be changed to test out “review+” patches once it gets done with all the “review?” patches? Is that practical? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
