Re: [webkit-dev] Help with review of EFL CMake patches?

2010-05-07 Thread Patrick Roland Gansterer
Hi, The idea of a Options${PORT} file is to put only the port-specific checks and defaults there. When we now have a CMake buildsystem we can get rid of port-thinking. We can switch to has-feature-thinking. You should check for different features instead of doing sth for a spezial port. E.g.

Re: [webkit-dev] Help with review of EFL CMake patches?

2010-05-07 Thread Gustavo Sverzut Barbieri
On Fri, May 7, 2010 at 5:50 AM, Patrick Roland Gansterer par...@paroga.com wrote: Hi, The idea of a Options${PORT} file is to put only the port-specific checks and defaults there. When we now have a CMake buildsystem we can get rid of port-thinking. We can switch to has-feature-thinking.

Re: [webkit-dev] Help with review of EFL CMake patches?

2010-05-06 Thread Leandro Pereira
Patrick, On Mon, May 3, 2010 at 6:09 PM, Patrick Roland Gansterer par...@paroga.com wrote: (...) but there a some parts which are not good for a general buildsystem. E.g. INCLUDE(Options${PORT}) doesn't support different ports well, since ports share some parts. (There some other points too;

Re: [webkit-dev] Help with review of EFL CMake patches?

2010-05-04 Thread Gustavo Sverzut Barbieri
Just a friendly ping, if someone could help us get this merged, say it. If you see a big blocker after my last comment, say it. Meanwhile, Leandro is working on generic webkit option, to be more generic than my initial {ADD,DEL}_FEATURE(). BR, On Mon, May 3, 2010 at 6:32 PM, Gustavo Sverzut

[webkit-dev] Help with review of EFL CMake patches?

2010-05-03 Thread Gustavo Sverzut Barbieri
Hi all, As some of you know, the EFL port is almost all merged, we just lack a build system in SVN by now. We initially started with automake, sharing with GTK, but it was quite slow and the Gtk guys had the willing to get it clean before any changes were made, in order to avoid it to get worse.

Re: [webkit-dev] Help with review of EFL CMake patches?

2010-05-03 Thread Adam Treat
Bill, could you look over these CMake files and give it an informal review? On Monday 03 May 2010 02:37:22 pm Gustavo Sverzut Barbieri wrote: Hi all, As some of you know, the EFL port is almost all merged, we just lack a build system in SVN by now. We initially started with automake,

Re: [webkit-dev] Help with review of EFL CMake patches?

2010-05-03 Thread Patrick Roland Gansterer
Hi, the file from Gustavo are mainly for the EFL port. It's not a general buildsystem and some parts are not real CMake style in the moment. I did some cleanup for the JavaScriptCore files already, but for the WebCore and WebKit parts it is a bigger task. As I already wrote at [1] I will help

Re: [webkit-dev] Help with review of EFL CMake patches?

2010-05-03 Thread Gustavo Sverzut Barbieri
On Mon, May 3, 2010 at 5:21 PM, Patrick Roland Gansterer par...@paroga.com wrote: Hi, the file from Gustavo are mainly for the EFL port. It's not a general buildsystem and some parts are not real CMake style in the moment. I did some cleanup for the JavaScriptCore files already, but for the

Re: [webkit-dev] Help with review of EFL CMake patches?

2010-05-03 Thread Patrick Roland Gansterer
Hi, On Mon, 3 May 2010 17:33:45 -0300, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Did you see this new version? Leandro did the work on top of yours. However he removed the .h from the source list, he did it before he read that it may be useful to get some IDE to show it. If

Re: [webkit-dev] Help with review of EFL CMake patches?

2010-05-03 Thread Gustavo Sverzut Barbieri
On Mon, May 3, 2010 at 6:09 PM, Patrick Roland Gansterer par...@paroga.com wrote: Hi, On Mon, 3 May 2010 17:33:45 -0300, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Did you see this new version?  Leandro did the work on top of yours. However he removed the .h from the source