Re: [webkit-dev] Javascript window.open handling in GTK
Thanks Gustavo! I applied the patch and after some additional code changes in GtkLauncher it works. Actually pretty well!! :) I had a much less sophisticated version in my tree. One thing missing right now is window.close() from what I can see. Did you leave that out intentionally? I guess we need a similar signal in ChromeClient::closeWindowSoon() for that, e.g. close-web-view. -Bernd -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gustavo Noronha Silva Sent: Friday, October 03, 2008 2:24 AM To: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Javascript window.open handling in GTK On Wed, 2008-10-01 at 15:18 -0700, Weber, Bernd wrote: Playing around with the code for a while now I found that, at least in the GTK implementation, window.open(), close(), etc is not implemented. Can anyone explain to me why this is not implemented? Maybe because of security concerns? Wouldn't it be better to have a setting defined that restricts this feature instead of not implementing it at all?! I think mostly because code has not been written or has not been reviewed/commited yet. I think what you are trying to do will probably be helped by these: https://bugs.webkit.org/show_bug.cgi?id=19130 https://bugs.webkit.org/show_bug.cgi?id=16401 See you, -- Gustavo Noronha Silva [EMAIL PROTECTED] GNOME contributor: http://www.gnome.org/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev - This message (including any attachments) may contain confidential information intended for a specific individual and purpose. If you are not the intended recipient, delete this message. If you are not the intended recipient, disclosing, copying, distributing, or taking any action based on this message is strictly prohibited. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Javascript window.open handling in GTK
On Wed, 2008-10-01 at 15:18 -0700, Weber, Bernd wrote: Playing around with the code for a while now I found that, at least in the GTK implementation, window.open(), close(), etc is not implemented. Can anyone explain to me why this is not implemented? Maybe because of security concerns? Wouldn’t it be better to have a setting defined that restricts this feature instead of not implementing it at all?! I think mostly because code has not been written or has not been reviewed/commited yet. I think what you are trying to do will probably be helped by these: https://bugs.webkit.org/show_bug.cgi?id=19130 https://bugs.webkit.org/show_bug.cgi?id=16401 See you, -- Gustavo Noronha Silva [EMAIL PROTECTED] GNOME contributor: http://www.gnome.org/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Javascript window.open handling in GTK
Hi, Playing around with the code for a while now I found that, at least in the GTK implementation, window.open(), close(), etc is not implemented. Can anyone explain to me why this is not implemented? Maybe because of security concerns? Wouldn't it be better to have a setting defined that restricts this feature instead of not implementing it at all?! Anyway I did my own implementation in ChromeClientGtk.cpp that actually works ok so far. However in order to make it really nice and proof I need to get a handle to the parent webview that originally started this new window. I didn't find a way yet on how to get this information down there. Can someone give me a pointer on where I can get his information from?! Main reason actually is that the parent window has to be refreshed when the child window closes. Also I want to have a safety check in the close function if the calling instance is the top level webview. Thanks! -Bernd - This message (including any attachments) may contain confidential information intended for a specific individual and purpose. If you are not the intended recipient, delete this message. If you are not the intended recipient, disclosing, copying, distributing, or taking any action based on this message is strictly prohibited.___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
