Re: [webkit-dev] LayoutTest failures on Windows due to fonts/metric (yet again, any update?)
On Apr 6, 2011, at 3:11 PM, Pere Martir wrote: > On Wed, Apr 6, 2011 at 11:50 PM, Adam Roben wrote: >> It's possible that you need the fonts from a specific version of Mac OS X. I >> don't know what version that would be, though. > > What if I want to submit a patch and I am working on Windows ? > Switching to Mac OS X is my best option ? I am not currently working > on any Windows specific issue, but I wonder that how the others submit > the windows-port patches without first passing all regression tests ? > > Maybe --tolerance can be allowed ? The --tolerance option controls the failure threshold for pixel tests (where two images are compared); it has no effect on the render tree comparison, where the actual results are required to be identical to the expected results. > > Is it possible to contact who setup the Windows build slaves ? > >> It is a known issue that it's so hard to get correct test results on >> Windows. I don't think we have a bug filed about it. > > Should I submit one since I have all artifacts - test logs, fonts > which fail the tests, etc. > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] LayoutTest failures on Windows due to fonts/metric (yet again, any update?)
On Wed, Apr 6, 2011 at 11:50 PM, Adam Roben wrote: > It's possible that you need the fonts from a specific version of Mac OS X. I > don't know what version that would be, though. What if I want to submit a patch and I am working on Windows ? Switching to Mac OS X is my best option ? I am not currently working on any Windows specific issue, but I wonder that how the others submit the windows-port patches without first passing all regression tests ? Maybe --tolerance can be allowed ? Is it possible to contact who setup the Windows build slaves ? > It is a known issue that it's so hard to get correct test results on Windows. > I don't think we have a bug filed about it. Should I submit one since I have all artifacts - test logs, fonts which fail the tests, etc. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] LayoutTest failures on Windows due to fonts/metric (yet again, any update?)
On Apr 6, 2011, at 7:43 AM, Pere Martir wrote:
> I am working on Windows and I am planning to submit some patches
> (plugin loading) but I have problem make all regression tests
> (run-webkit-tests) pass without unmodified code.
>
> I followed all the instructions:
>
> http://trac.webkit.org/wiki/BuildingOnWindows#Font-metric-relatedfailures
>
> but as it warned, I saw "metric-related failures".
>
> And recently aroben just told me on IRC that I may still have
> difference in the metrics so that I suppose that this problem has not
> be resolved.
>
> The most related posts that I could find in this list is kinda old.
> * Eric Seidel, Oct 2008 - http://markmail.org/message/ihjhh4dre2ztu6v4
> * Darin Adler, Apr 2009 - http://markmail.org/message/wsnz67kqm7l7mtk6
>
> However, on WebKit BuildBot I saw that Windows release and debug build
> are both "green". I don't see the option "--tolerance" specified.
> There must be some tricks of setting up the machine. Any clue please ?
>
> @@ -1,15 +1,15 @@
> layer at (0,0) size 800x600
> RenderView at (0,0) size 800x600
> -layer at (0,0) size 800x70
> - RenderBlock {HTML} at (0,0) size 800x70
> -RenderBody {BODY} at (8,8) size 784x54
> - RenderText {#text} at (0,0) size 770x36
> +layer at (0,0) size 800x79
> + RenderBlock {HTML} at (0,0) size 800x79
> +RenderBody {BODY} at (8,8) size 784x63
> + RenderText {#text} at (0,0) size 770x41
>
> (full result of 2 failures attached)
>
> One thing may make he difference. In my MacBook, I found *almost all*
> fonts listed in:
>
> https://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp#L319
>
> except "Times *.ttf". I did find "Times New Roman8.ttf" so that I
> renamed the later.
>
It's possible that you need the fonts from a specific version of Mac OS X. I
don't know what version that would be, though.
It is a known issue that it's so hard to get correct test results on Windows. I
don't think we have a bug filed about it.
-Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] LayoutTest failures on Windows due to fonts/metric (yet again, any update?)
I am working on Windows and I am planning to submit some patches
(plugin loading) but I have problem make all regression tests
(run-webkit-tests) pass without unmodified code.
I followed all the instructions:
http://trac.webkit.org/wiki/BuildingOnWindows#Font-metric-relatedfailures
but as it warned, I saw "metric-related failures".
And recently aroben just told me on IRC that I may still have
difference in the metrics so that I suppose that this problem has not
be resolved.
The most related posts that I could find in this list is kinda old.
* Eric Seidel, Oct 2008 - http://markmail.org/message/ihjhh4dre2ztu6v4
* Darin Adler, Apr 2009 - http://markmail.org/message/wsnz67kqm7l7mtk6
However, on WebKit BuildBot I saw that Windows release and debug build
are both "green". I don't see the option "--tolerance" specified.
There must be some tricks of setting up the machine. Any clue please ?
@@ -1,15 +1,15 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x70
- RenderBlock {HTML} at (0,0) size 800x70
-RenderBody {BODY} at (8,8) size 784x54
- RenderText {#text} at (0,0) size 770x36
+layer at (0,0) size 800x79
+ RenderBlock {HTML} at (0,0) size 800x79
+RenderBody {BODY} at (8,8) size 784x63
+ RenderText {#text} at (0,0) size 770x41
(full result of 2 failures attached)
One thing may make he difference. In my MacBook, I found *almost all*
fonts listed in:
https://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp#L319
except "Times *.ttf". I did find "Times New Roman8.ttf" so that I
renamed the later.
layout-test-results.tar.gz
Description: GNU Zip compressed data
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
