Re: [webkit-dev] Line breaking

2010-10-31 Thread Xianzhu Wang
Hi, Adam,

I have recently worked on several issues about line breaking. Glad to hear
your plans. Actually I'm a bit tired of waiting for responses about the
issues (and about some other 'old' layout bugs). Your involvement would
greatly help resolve them.

What I have done on these issues are as follows. Hope these information will
be useful for you.

1) https://bugs.webkit.org/show_bug.cgi?id=37698: I wrote a test to generate
line breaking matrix for each browser. However, the test can't reflect some
stateful behaviors of some browsers. The patch extends the original ASCII
line breaking rule dealing with line-breaking only after '?' and hyphen to a
full line breaking matrix to allow line breaking after ')', '}' and ']'. The
patch has been landed.

2) https://bugs.webkit.org/show_bug.cgi?id=20677: I created a simple patch
that disallows line-breaking between a digit and a hyphen. Waiting for
review and/or responses.

3) https://bugs.webkit.org/show_bug.cgi?id=37543

I think fixing 2) and 3) might need a refactory to the line breaking code.
The break_lines.cpp looks weird because of its non-standard filename and
because it inserts a pure C functional layer into OO code. It causes
difficulties to implement a stateful line-breaking algorithm. For ICU
implementation, break_lines.cpp also causes many unnecessary ubrk_setText()
calls. My thought is to move the logic in break_lines.cpp down into the
implementations of TextBreakIterator, so that the interface could be
stateful.

Please let me know if I could be any help.

Thanks,
Xianzhu

2010/10/29 Adam Barth aba...@webkit.org

 In looking at a bunch of web compat bugs filed in the Chromium bug
 tracker, it seems like WebKit's line breaking behavior is a major
 source of compatibility problems.  I'm currently writing a test suite
 to reverse engineer the line breaking behavior of other browsers.  I'm
 not familiar with the history of WebKit's line breaking behavior.  Who
 would be a good person to talk with about these issues?

 Thanks,
 Adam
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Line breaking

2010-10-29 Thread Adam Barth
In looking at a bunch of web compat bugs filed in the Chromium bug
tracker, it seems like WebKit's line breaking behavior is a major
source of compatibility problems.  I'm currently writing a test suite
to reverse engineer the line breaking behavior of other browsers.  I'm
not familiar with the history of WebKit's line breaking behavior.  Who
would be a good person to talk with about these issues?

Thanks,
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Line breaking

2010-10-29 Thread David Hyatt
Pick me! Pick me!

On Oct 29, 2010, at 1:54 AM, Adam Barth wrote:

 In looking at a bunch of web compat bugs filed in the Chromium bug
 tracker, it seems like WebKit's line breaking behavior is a major
 source of compatibility problems.  I'm currently writing a test suite
 to reverse engineer the line breaking behavior of other browsers.  I'm
 not familiar with the history of WebKit's line breaking behavior.  Who
 would be a good person to talk with about these issues?
 
 Thanks,
 Adam
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Line breaking

2010-10-29 Thread Adam Barth
Ok, you asked for it.  :)

Adam


On Fri, Oct 29, 2010 at 12:16 AM, David Hyatt hy...@apple.com wrote:
 Pick me! Pick me!

 On Oct 29, 2010, at 1:54 AM, Adam Barth wrote:

 In looking at a bunch of web compat bugs filed in the Chromium bug
 tracker, it seems like WebKit's line breaking behavior is a major
 source of compatibility problems.  I'm currently writing a test suite
 to reverse engineer the line breaking behavior of other browsers.  I'm
 not familiar with the history of WebKit's line breaking behavior.  Who
 would be a good person to talk with about these issues?

 Thanks,
 Adam
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev