Re: [webkit-dev] MathML layout refactor proposal

2015-12-29 Thread Frédéric WANG
Hi Dave, Thank you for your message. It's good to see that you are still interested in what's happening in WebKit MathML. I believe we agree with the goals you state, however most of your claims on flexbox VS a separate renderer class seemed to be assumptions you made 3 years ago. People

Re: [webkit-dev] MathML layout refactor proposal

2015-12-28 Thread Alejandro Garcia Castro
Hi Dave, thanks very much for your comments and feedback, this information is great to document the whole design process of the code. I agree with the goals you are pointing out, actually I think the change to use flexbox was a good option to try at that point. But currently considering the

Re: [webkit-dev] MathML layout refactor proposal

2015-12-22 Thread Dave Barton
Since I was the one who changed RenderMathMLBlock to derive from RenderFlexibleBox instead of RenderBlock back in 2012, I thought I should reply to the recent question on it and give my reasons for doing so.1. Ideally, we want most webkit developers to not even have to think about MathML. If you

Re: [webkit-dev] MathML layout refactor proposal

2015-12-22 Thread dbarton
2nd try - hopefully as raw text, not an html attachment this time: Since I was the one who changed RenderMathMLBlock to derive from RenderFlexibleBox instead of RenderBlock back in 2012, I thought I should reply to the recent question on it and give my reasons for doing so. 1. Ideally, we want

Re: [webkit-dev] MathML layout refactor proposal

2015-12-14 Thread Ryosuke Niwa
Hi Alex, I think this refactoring makes a lot of sense. This is very close to what I wanted to do with MathML four years ago so I'm very happy to hear that you're taking the initiative here. - R. Niwa On Wed, Dec 9, 2015 at 3:35 AM, Alejandro Garcia Castro wrote: > > Hi, > >

Re: [webkit-dev] MathML layout refactor proposal

2015-12-14 Thread Zalan Bujtas
It’s great to hear that MathML is getting some proper cleanup. I think the proposal sounds good and I am looking forward to the patches. Minor observation: I noticed that, since MathML block is no longer a flexbox, but it still needs some of the flexbox functionality, the following pattern has

Re: [webkit-dev] MathML layout refactor proposal

2015-12-14 Thread Frédéric WANG
Le 14/12/2015 19:39, Zalan Bujtas a écrit : > It’s great to hear that MathML is getting some proper cleanup. I think the > proposal sounds good and I am looking forward to the patches. > > Minor observation: I noticed that, since MathML block is no longer a flexbox, > but it still needs some of

Re: [webkit-dev] MathML layout refactor proposal

2015-12-14 Thread Alejandro Garcia Castro
On Mon, Dec 14, 2015 at 08:03:12PM +0100, Frédéric WANG wrote: > Le 14/12/2015 19:39, Zalan Bujtas a écrit : > > It’s great to hear that MathML is getting some proper cleanup. I think the > > proposal sounds good and I am looking forward to the patches. > > > > Minor observation: I noticed that,

Re: [webkit-dev] MathML layout refactor proposal

2015-12-14 Thread Javier Fernandez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 12/14/2015 08:03 PM, Frédéric WANG wrote: > Le 14/12/2015 19:39, Zalan Bujtas a écrit : >> It’s great to hear that MathML is getting some proper cleanup. I >> think the proposal sounds good and I am looking forward to the >> patches. >> >>

Re: [webkit-dev] MathML layout refactor proposal

2015-12-10 Thread Myles C. Maxfield
I can't comment for the rest of the team, but I am very excited to see this!  -- Myles > On Dec 9, 2015, at 3:35 AM, Alejandro Garcia Castro wrote: > > > Hi, > > In the last months we have been working on refactoring the MathML > layout code to make it more maintainable,

[webkit-dev] MathML layout refactor proposal

2015-12-09 Thread Alejandro Garcia Castro
Hi, In the last months we have been working on refactoring the MathML layout code to make it more maintainable, because in the current point fixing issues or adding new features has been too complex. We have reached the point where we think we have to discuss whether this work makes sense and