Re: [webkit-dev] More thoughts on cleaning up the root directory
On Dec 29, 2010, at 9:35 PM, Adam Barth wrote: > On Mon, Dec 27, 2010 at 1:28 PM, Adam Barth wrote: >> On Mon, Dec 27, 2010 at 1:25 PM, Darin Adler wrote: >>> On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe wrote: > Can someone also elaborate on why "Sources" was chosen as the top-level > directory name rather than "Source"? "Source code" is a mass noun so it's > unclear why the abbreviated form of "source" would be pluralized in this > manner. Referring to source code as "source" appears to be very common, > but I've never encountered "sources" used in this manner. It reads very > awkwardly to me. That's just the name that Darin used in his email proposing the new layout. If folks would prefer Source, now is a good time to make that change because there's only a handful of directories there now. >>> >>> I like Source better. >> >> Okiedokes. > > Some further thoughts: > > 1) Xcode seems to use the term "Sources" to describe a collection of > source files. > 2) There seems to be something called > AppleInternal/Sources/JavaScriptCore (possibly only on Windows). > 3) We have a notion of DerivedSources. > > Would using "Sources" be more consistent with these terms? I'd still keep it singular. I don't think it is a matter of great import either way though. - Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
On Mon, Dec 27, 2010 at 1:28 PM, Adam Barth wrote: > On Mon, Dec 27, 2010 at 1:25 PM, Darin Adler wrote: >> On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: >>> On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe wrote: Can someone also elaborate on why "Sources" was chosen as the top-level directory name rather than "Source"? "Source code" is a mass noun so it's unclear why the abbreviated form of "source" would be pluralized in this manner. Referring to source code as "source" appears to be very common, but I've never encountered "sources" used in this manner. It reads very awkwardly to me. >>> >>> That's just the name that Darin used in his email proposing the new layout. >>> If folks would prefer Source, now is a good time to make that change >>> because there's only a handful of directories there now. >> >> I like Source better. > > Okiedokes. Some further thoughts: 1) Xcode seems to use the term "Sources" to describe a collection of source files. 2) There seems to be something called AppleInternal/Sources/JavaScriptCore (possibly only on Windows). 3) We have a notion of DerivedSources. Would using "Sources" be more consistent with these terms? Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
> I filed a meta bug for tracking the layering violation. > https://bugs.webkit.org/show_bug.cgi?id=51662 > It would be great if anyone added dependent bugs for this. There is a bug about it ( https://bugs.webkit.org/show_bug.cgi?id=21354 ) and it already has a better-filed dependency list. -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
On Mon, Dec 27, 2010 at 7:17 PM, Maciej Stachowiak wrote: > > On Dec 27, 2010, at 1:11 PM, Sam Weinig wrote: > > > > On Mon, Dec 27, 2010 at 11:14 AM, Adam Barth wrote: > >> > Is it really a good idea to move platform out of WebCore? Lots of stuff >> > there seems quite WebCore related. >> >> There seem to be a couple people who aren't sold on moving platform >> out of WebCore. It sounds like we should hold off on doing that and >> discuss it separately down the road. >> >> On Mon, Dec 27, 2010 at 2:47 AM, Hajime Morita >> wrote: >> >> Platform/ (was WebCore/platform) >> > I'd like to keep platform directory under WebCore if there is no strong >> reason. >> >> Ok. I think different people have slightly different ideas about what >> should go into this folder. That sounds like a complex topic that we >> might need to discuss more later. >> >> > I think moving Platform out from WebCore is great long term goal, but right > now, there is simply too many layering violations for it to be feasible. For > those curious, the intent is for nothing in Platform to be dependent on > anything else in WebCore (eg. dom, html, rendering, loader), so something > like platform/qt/RenderThemeQt.cpp would be considered a layering violation. > There are bugs filed on many of these violations, but the work has not be > completed. > > > Indeed, that's the reason I suggested to Adam that we should move platform > out of WebCore eventually. It would make the layering intent more clear and > would let us enforce the layering by making it a compile-time error to > depend on other parts of WebCore inside the platform directory. > fwiw, this change https://bugs.webkit.org/attachment.cgi?id=73254&action=prettypatch if/when finished would help a lot with enforcing it. (The enforcement in there is likely too aggressive as previously discussed). > However, I don't think we should make this change part of the initial > reorg. It's something we could do down the line once we have had time to fix > up more of the layering violations. Note: we could also whitelist specific > files with known layering violations if we want to make this change before > we eliminate all layering violations. > > Regards, > Maciej > > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
On Dec 27, 2010, at 1:11 PM, Sam Weinig wrote: > > > On Mon, Dec 27, 2010 at 11:14 AM, Adam Barth wrote: > > Is it really a good idea to move platform out of WebCore? Lots of stuff > > there seems quite WebCore related. > > There seem to be a couple people who aren't sold on moving platform > out of WebCore. It sounds like we should hold off on doing that and > discuss it separately down the road. > > On Mon, Dec 27, 2010 at 2:47 AM, Hajime Morita wrote: > >> Platform/ (was WebCore/platform) > > I'd like to keep platform directory under WebCore if there is no strong > > reason. > > Ok. I think different people have slightly different ideas about what > should go into this folder. That sounds like a complex topic that we > might need to discuss more later. > > > I think moving Platform out from WebCore is great long term goal, but right > now, there is simply too many layering violations for it to be feasible. For > those curious, the intent is for nothing in Platform to be dependent on > anything else in WebCore (eg. dom, html, rendering, loader), so something > like platform/qt/RenderThemeQt.cpp would be considered a layering violation. > There are bugs filed on many of these violations, but the work has not be > completed. Indeed, that's the reason I suggested to Adam that we should move platform out of WebCore eventually. It would make the layering intent more clear and would let us enforce the layering by making it a compile-time error to depend on other parts of WebCore inside the platform directory. However, I don't think we should make this change part of the initial reorg. It's something we could do down the line once we have had time to fix up more of the layering violations. Note: we could also whitelist specific files with known layering violations if we want to make this change before we eliminate all layering violations. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
On Dec 27, 2010, at 12:04 AM, Adam Barth wrote: > Here's a snapshot of my current thinking on where the files and > folders currently in the top-level directory might go. > > There are a bunch of build-system related files that are currently in > the root. I'm not sure whether we should leave them in there or move > them into Sources somewhere. I'm tempted to put them into Sources so > that Sources is self-contained package of all the stuff you need to > build WebKit. That said, having a top-level Makefile that kicks off > the whole process also seems reasonable. > > Examples/ > PerformanceTests/ > PageLoad/ (was PageLoadTests) > SunSpider/ > HTMLParser/ (was WebCore/benchmarks/parser) > RegressionTests/ (was LayoutTests) > manual/ (was WebCore/manual-tests) I would suggest putting manual/ under a separate directory, to reduce potential confusion from having content in there that is not run automated. Also, perhaps JavaScriptCore/tests should be moved out of JavaScriptCore. > Sources/ > automake/ > cmake/ > JavaScriptCore/ > JavaScriptGlue/ > Platform/ (was WebCore/platform) > WebCore/ > WebKit/ > WebKit2/ > WTF/ (was JavaScriptCore/wtf) > ThirdParty/ >ANGLE/ >+ Contents WebKitLibraries > Tools/ > Websites/ > .gitattributes > .gitignore > ChangeLog > Makefile > Makefile.shared > > == UNSURE == > autogen.sh > Android.mk > common.pri > cmakeconfig.h.cmake > CMakeLists.txt > configure.ac > GNUmakefile.am > wscript > DerivedSources.pro > WebKit.pri > WebKit.pro I think it would be fine to leave any build files at top level that are necessary to build any given port with a conventional build command at top level. Otherwise move to subdirectories. I don't know which ones this is true for. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
> I think moving Platform out from WebCore is great long term goal, but right > now, there is simply too many layering violations for it to be feasible. For > those curious, the intent is for nothing in Platform to be dependent on > anything else in WebCore (eg. dom, html, rendering, loader), so something > like platform/qt/RenderThemeQt.cpp would be considered a layering violation. > There are bugs filed on many of these violations, but the work has not be > completed. Got it. Thank you for the explanation. I filed a meta bug for tracking the layering violation. https://bugs.webkit.org/show_bug.cgi?id=51662 It would be great if anyone added dependent bugs for this. Regards. -- morrita ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
On Mon, Dec 27, 2010 at 1:25 PM, Darin Adler wrote: > On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: >> On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe wrote: >>> Can someone also elaborate on why "Sources" was chosen as the top-level >>> directory name rather than "Source"? "Source code" is a mass noun so it's >>> unclear why the abbreviated form of "source" would be pluralized in this >>> manner. Referring to source code as "source" appears to be very common, but >>> I've never encountered "sources" used in this manner. It reads very >>> awkwardly to me. >> >> That's just the name that Darin used in his email proposing the new layout. >> If folks would prefer Source, now is a good time to make that change because >> there's only a handful of directories there now. > > I like Source better. Okiedokes. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: > On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe wrote: >> Can someone also elaborate on why "Sources" was chosen as the top-level >> directory name rather than "Source"? "Source code" is a mass noun so it's >> unclear why the abbreviated form of "source" would be pluralized in this >> manner. Referring to source code as "source" appears to be very common, but >> I've never encountered "sources" used in this manner. It reads very >> awkwardly to me. > > That's just the name that Darin used in his email proposing the new layout. > If folks would prefer Source, now is a good time to make that change because > there's only a handful of directories there now. I like Source better. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
On Mon, Dec 27, 2010 at 11:14 AM, Adam Barth wrote: > > Is it really a good idea to move platform out of WebCore? Lots of stuff > > there seems quite WebCore related. > > There seem to be a couple people who aren't sold on moving platform > out of WebCore. It sounds like we should hold off on doing that and > discuss it separately down the road. > > On Mon, Dec 27, 2010 at 2:47 AM, Hajime Morita wrote: > >> Platform/ (was WebCore/platform) > > I'd like to keep platform directory under WebCore if there is no strong > reason. > > Ok. I think different people have slightly different ideas about what > should go into this folder. That sounds like a complex topic that we > might need to discuss more later. > > I think moving Platform out from WebCore is great long term goal, but right now, there is simply too many layering violations for it to be feasible. For those curious, the intent is for nothing in Platform to be dependent on anything else in WebCore (eg. dom, html, rendering, loader), so something like platform/qt/RenderThemeQt.cpp would be considered a layering violation. There are bugs filed on many of these violations, but the work has not be completed. -Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
Got it. I didn't notice that manual was a sub directory. Kenneth On Mon, Dec 27, 2010 at 8:14 PM, Adam Barth wrote: > Thanks fora ll your feedback. Responses inline. > > On Mon, Dec 27, 2010 at 2:06 AM, Kenneth Rohde Christiansen > wrote: > > So we have PerformanceTests, RegressionTests and manual. Why not > > ManualTests? > > My thought process was that these are manual regression tests, just > like the HTTP tests are HTTP regression tests (and are handled > specially by run-webkit-tests). ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
Thanks fora ll your feedback. Responses inline. On Mon, Dec 27, 2010 at 2:06 AM, Kenneth Rohde Christiansen wrote: > So we have PerformanceTests, RegressionTests and manual. Why not > ManualTests? My thought process was that these are manual regression tests, just like the HTTP tests are HTTP regression tests (and are handled specially by run-webkit-tests). > Is it really a good idea to move platform out of WebCore? Lots of stuff > there seems quite WebCore related. There seem to be a couple people who aren't sold on moving platform out of WebCore. It sounds like we should hold off on doing that and discuss it separately down the road. On Mon, Dec 27, 2010 at 2:47 AM, Hajime Morita wrote: >> Platform/ (was WebCore/platform) > I'd like to keep platform directory under WebCore if there is no strong > reason. Ok. I think different people have slightly different ideas about what should go into this folder. That sounds like a complex topic that we might need to discuss more later. On Mon, Dec 27, 2010 at 3:58 AM, Patrick Gansterer wrote: > Adam Barth: >> There are a bunch of build-system related files that are currently in >> the root. I'm not sure whether we should leave them in there or move >> them into Sources somewhere. I'm tempted to put them into Sources so >> that Sources is self-contained package of all the stuff you need to >> build WebKit. That said, having a top-level Makefile that kicks off >> the whole process also seems reasonable. > > If we keep a top level Makefile we also need to keep all "== UNSURE ==" files. > IMHO it's better to move all build related stuff into Sources. Then you only > need the Sources directory to build WebKit. That makes sense to me. >> PerformanceTests/ >> PageLoad/ (was PageLoadTests) >> SunSpider/ >> HTMLParser/ (was WebCore/benchmarks/parser) > > A XML parser benchmark will land soon (bug 51612), so "Parser" might be a > better name instead of "HTMLParser". Ok. :) On Mon, Dec 27, 2010 at 4:49 AM, Zoltan Herczeg wrote: > Like it. I only have a few questions: > > * Where would the build (WebKitBuild) directory would go? Perhaps a Build/ > would fit in the root directory. Yes. I have a patch ready to land that renames WebKitBuild to Build. Landing that patch is slightly tricky because it requires a buildbot master restart. > * Some manual-tests belong to the regression tests, and some are belong to > the performance test. Would be good to separate them. Interesting. I might need some help figuring out which are which. > * I think the build related files could go to Sources/ (no need an extra > level) Ok. Several other folks have commented with the same perspective. On Mon, Dec 27, 2010 at 10:19 AM, Mark Rowe wrote: > WebKitLibraries contains precompiled binaries rather than source code. > Mixing source and precompiled binaries under the Sources directory will > make it difficult to make the necessary changes down the road to allow > removing the forwarding headers mechanism. We should keep the two types of > content separate. Maybe we should rename WebKitLibraries to Libraries and leave it in the root directory? I'm not sure I fully understand the coupling between where the libraries are and the forwarding headers, but I believe you. :) On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe wrote: > Can someone also elaborate on why "Sources" was chosen as the top-level > directory name rather than "Source"? "Source code" is a mass noun so it's > unclear why the abbreviated form of "source" would be pluralized in this > manner. Referring to source code as "source" appears to be very common, but > I've never encountered "sources" used in this manner. It reads very > awkwardly to me. That's just the name that Darin used in his email proposing the new layout. If folks would prefer Source, now is a good time to make that change because there's only a handful of directories there now. Traditionally, in other open-source projects, other folks call this directory "src". For example, that's what Cassandra uses: http://svn.apache.org/viewvc/cassandra/trunk/src/ However, using a real English word seems more aligned with WebKit's no-abbreviation culture. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
On 2010-12-27, at 10:19, Mark Rowe wrote: > > On 2010-12-27, at 00:04, Adam Barth wrote: > >> Here's a snapshot of my current thinking on where the files and >> folders currently in the top-level directory might go. >> >> There are a bunch of build-system related files that are currently in >> the root. I'm not sure whether we should leave them in there or move >> them into Sources somewhere. I'm tempted to put them into Sources so >> that Sources is self-contained package of all the stuff you need to >> build WebKit. That said, having a top-level Makefile that kicks off >> the whole process also seems reasonable. >> >> Examples/ >> PerformanceTests/ >> PageLoad/ (was PageLoadTests) >> SunSpider/ >> HTMLParser/ (was WebCore/benchmarks/parser) >> RegressionTests/ (was LayoutTests) >> manual/ (was WebCore/manual-tests) >> Sources/ >> automake/ >> cmake/ >> JavaScriptCore/ >> JavaScriptGlue/ >> Platform/ (was WebCore/platform) >> WebCore/ >> WebKit/ >> WebKit2/ >> WTF/ (was JavaScriptCore/wtf) > >> ThirdParty/ >>ANGLE/ >>+ Contents WebKitLibraries > > WebKitLibraries contains precompiled binaries rather than source code. > Mixing source and precompiled binaries under the Sources directory will make > it difficult to make the necessary changes down the road to allow removing > the forwarding headers mechanism. We should keep the two types of content > separate. Can someone also elaborate on why "Sources" was chosen as the top-level directory name rather than "Source"? "Source code" is a mass noun so it's unclear why the abbreviated form of "source" would be pluralized in this manner. Referring to source code as "source" appears to be very common, but I've never encountered "sources" used in this manner. It reads very awkwardly to me. Thanks, - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
On 2010-12-27, at 00:04, Adam Barth wrote: > Here's a snapshot of my current thinking on where the files and > folders currently in the top-level directory might go. > > There are a bunch of build-system related files that are currently in > the root. I'm not sure whether we should leave them in there or move > them into Sources somewhere. I'm tempted to put them into Sources so > that Sources is self-contained package of all the stuff you need to > build WebKit. That said, having a top-level Makefile that kicks off > the whole process also seems reasonable. > > Examples/ > PerformanceTests/ > PageLoad/ (was PageLoadTests) > SunSpider/ > HTMLParser/ (was WebCore/benchmarks/parser) > RegressionTests/ (was LayoutTests) > manual/ (was WebCore/manual-tests) > Sources/ > automake/ > cmake/ > JavaScriptCore/ > JavaScriptGlue/ > Platform/ (was WebCore/platform) > WebCore/ > WebKit/ > WebKit2/ > WTF/ (was JavaScriptCore/wtf) > ThirdParty/ >ANGLE/ >+ Contents WebKitLibraries WebKitLibraries contains precompiled binaries rather than source code. Mixing source and precompiled binaries under the Sources directory will make it difficult to make the necessary changes down the road to allow removing the forwarding headers mechanism. We should keep the two types of content separate. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
Like it. I only have a few questions: * Where would the build (WebKitBuild) directory would go? Perhaps a Build/ would fit in the root directory. * Some manual-tests belong to the regression tests, and some are belong to the performance test. Would be good to separate them. * I think the build related files could go to Sources/ (no need an extra level) Regards, Zoltan > Here's a snapshot of my current thinking on where the files and > folders currently in the top-level directory might go. > > There are a bunch of build-system related files that are currently in > the root. I'm not sure whether we should leave them in there or move > them into Sources somewhere. I'm tempted to put them into Sources so > that Sources is self-contained package of all the stuff you need to > build WebKit. That said, having a top-level Makefile that kicks off > the whole process also seems reasonable. > > Examples/ > PerformanceTests/ > PageLoad/ (was PageLoadTests) > SunSpider/ > HTMLParser/ (was WebCore/benchmarks/parser) > RegressionTests/ (was LayoutTests) > manual/ (was WebCore/manual-tests) > Sources/ > automake/ > cmake/ > JavaScriptCore/ > JavaScriptGlue/ > Platform/ (was WebCore/platform) > WebCore/ > WebKit/ > WebKit2/ > WTF/ (was JavaScriptCore/wtf) > ThirdParty/ > ANGLE/ > + Contents WebKitLibraries > Tools/ > Websites/ > .gitattributes > .gitignore > ChangeLog > Makefile > Makefile.shared > > == UNSURE == > autogen.sh > Android.mk > common.pri > cmakeconfig.h.cmake > CMakeLists.txt > configure.ac > GNUmakefile.am > wscript > DerivedSources.pro > WebKit.pri > WebKit.pro > > In this layout, I haven't merged PerformanceTests and RegressionTests > for two reasons. First, the natural name, Tests, conflicts with > tab-completing Tools. Second, folks so commonly access the current > LayoutTests directory that it seems a bit inefficient to place it > another level lower in the directory hierarchy. > > Comments welcome, of course. :) > > Adam > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
Hi, also thank you for leading the reorg. Adam Barth: > Here's a snapshot of my current thinking on where the files and > folders currently in the top-level directory might go. > > There are a bunch of build-system related files that are currently in > the root. I'm not sure whether we should leave them in there or move > them into Sources somewhere. I'm tempted to put them into Sources so > that Sources is self-contained package of all the stuff you need to > build WebKit. That said, having a top-level Makefile that kicks off > the whole process also seems reasonable. If we keep a top level Makefile we also need to keep all "== UNSURE ==" files. IMHO it's better to move all build related stuff into Sources. Then you only need the Sources directory to build WebKit. > Sources/ > automake/ > cmake/ > JavaScriptCore/ > JavaScriptGlue/ > Platform/ (was WebCore/platform) If you move WebCore/platform into Sources, you should also move all the platform stuff of WTF into this directory. I don't think this is a good idea, because this leads to WTF and WebCore namespace in one directory and that's confusing. Also the fact, that not all of the code in WebCore/platform is platform dependent, is a point against this move. > PerformanceTests/ > PageLoad/ (was PageLoadTests) > SunSpider/ > HTMLParser/ (was WebCore/benchmarks/parser) A XML parser benchmark will land soon (bug 51612), so "Parser" might be a better name instead of "HTMLParser". - Patrick ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
Hi, thank you for leading the reorg. > Sources/ > automake/ > cmake/ > JavaScriptCore/ > JavaScriptGlue/ > Platform/ (was WebCore/platform) I'd like to keep platform directory under WebCore if there is no strong reason. Classes under WebCore/platform have WebCore namespace, and the boundary between platform/ and rest of WebCore isn't clear for me. (For example, there is rendering/RenderThemeMac.mm and platform/qt/RenderThemeQt.cpp) We also often change platform and non-platform classes at the same time, that implies these tight coupling. So having these classes under same top directory will make the changelog more readable. Regards. -- morrita > WebCore/ > WebKit/ > WebKit2/ > WTF/ (was JavaScriptCore/wtf) > ThirdParty/ > ANGLE/ > + Contents WebKitLibraries > Tools/ > Websites/ > .gitattributes > .gitignore > ChangeLog > Makefile > Makefile.shared > > == UNSURE == > autogen.sh > Android.mk > common.pri > cmakeconfig.h.cmake > CMakeLists.txt > configure.ac > GNUmakefile.am > wscript > DerivedSources.pro > WebKit.pri > WebKit.pro > > In this layout, I haven't merged PerformanceTests and RegressionTests > for two reasons. First, the natural name, Tests, conflicts with > tab-completing Tools. Second, folks so commonly access the current > LayoutTests directory that it seems a bit inefficient to place it > another level lower in the directory hierarchy. > > Comments welcome, of course. :) > > Adam > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > -- morrita ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] More thoughts on cleaning up the root directory
So we have PerformanceTests, RegressionTests and manual. Why not ManualTests? Is it really a good idea to move platform out of WebCore? Lots of stuff there seems quite WebCore related. Cheers Kenneth On Mon, Dec 27, 2010 at 9:04 AM, Adam Barth wrote: > Here's a snapshot of my current thinking on where the files and > folders currently in the top-level directory might go. > > There are a bunch of build-system related files that are currently in > the root. I'm not sure whether we should leave them in there or move > them into Sources somewhere. I'm tempted to put them into Sources so > that Sources is self-contained package of all the stuff you need to > build WebKit. That said, having a top-level Makefile that kicks off > the whole process also seems reasonable. > > Examples/ > PerformanceTests/ > PageLoad/ (was PageLoadTests) > SunSpider/ > HTMLParser/ (was WebCore/benchmarks/parser) > RegressionTests/ (was LayoutTests) > manual/ (was WebCore/manual-tests) > Sources/ > automake/ > cmake/ > JavaScriptCore/ > JavaScriptGlue/ > Platform/ (was WebCore/platform) > WebCore/ > WebKit/ > WebKit2/ > WTF/ (was JavaScriptCore/wtf) > ThirdParty/ >ANGLE/ >+ Contents WebKitLibraries > Tools/ > Websites/ > .gitattributes > .gitignore > ChangeLog > Makefile > Makefile.shared > > == UNSURE == > autogen.sh > Android.mk > common.pri > cmakeconfig.h.cmake > CMakeLists.txt > configure.ac > GNUmakefile.am > wscript > DerivedSources.pro > WebKit.pri > WebKit.pro > > In this layout, I haven't merged PerformanceTests and RegressionTests > for two reasons. First, the natural name, Tests, conflicts with > tab-completing Tools. Second, folks so commonly access the current > LayoutTests directory that it seems a bit inefficient to place it > another level lower in the directory hierarchy. > > Comments welcome, of course. :) > > Adam > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > -- Kenneth Rohde Christiansen Senior Engineer Application and Service Frameworks, Nokia Danmark A/S Phone +45 4093 0598 / E-mail kenneth.christiansen at gmail.com http://codeposts.blogspot.com ﹆﹆﹆ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] More thoughts on cleaning up the root directory
Here's a snapshot of my current thinking on where the files and folders currently in the top-level directory might go. There are a bunch of build-system related files that are currently in the root. I'm not sure whether we should leave them in there or move them into Sources somewhere. I'm tempted to put them into Sources so that Sources is self-contained package of all the stuff you need to build WebKit. That said, having a top-level Makefile that kicks off the whole process also seems reasonable. Examples/ PerformanceTests/ PageLoad/ (was PageLoadTests) SunSpider/ HTMLParser/ (was WebCore/benchmarks/parser) RegressionTests/ (was LayoutTests) manual/ (was WebCore/manual-tests) Sources/ automake/ cmake/ JavaScriptCore/ JavaScriptGlue/ Platform/ (was WebCore/platform) WebCore/ WebKit/ WebKit2/ WTF/ (was JavaScriptCore/wtf) ThirdParty/ ANGLE/ + Contents WebKitLibraries Tools/ Websites/ .gitattributes .gitignore ChangeLog Makefile Makefile.shared == UNSURE == autogen.sh Android.mk common.pri cmakeconfig.h.cmake CMakeLists.txt configure.ac GNUmakefile.am wscript DerivedSources.pro WebKit.pri WebKit.pro In this layout, I haven't merged PerformanceTests and RegressionTests for two reasons. First, the natural name, Tests, conflicts with tab-completing Tools. Second, folks so commonly access the current LayoutTests directory that it seems a bit inefficient to place it another level lower in the directory hierarchy. Comments welcome, of course. :) Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
