Re: [webkit-dev] Moving to Python 3

2019-10-09 Thread Philippe Normand
Hi folks, Now that Catalina is released, can we move on to some of the proposed changes discussed in this thread? Philippe On Fri, 2019-07-12 at 12:18 -0700, Jonathan Bedard wrote: > Hello WebKit developers, > > Now that the Catalina developer seeds are available, it is official > that the new

Re: [webkit-dev] Moving to Python 3

2019-07-16 Thread Darin Adler
> On Jul 16, 2019, at 12:46 PM, Alexey Proskuryakov wrote: > > - They shouldn't make it excessively difficult to do WebKit engineering on > older versions of macOS. > > "Excessively" is not clearly defined, but it seems obvious that there is a > tradeoff between tools work difficulty, and

Re: [webkit-dev] Moving to Python 3

2019-07-16 Thread Alexey Proskuryakov
> 15 июля 2019 г., в 23:04, Fujii Hironori > написал(а): > > > On Sun, Jul 14, 2019 at 7:44 AM Ryosuke Niwa > wrote: > > I don’t think anyone is arguing that we’d eventually need to move to Python3. > I’m arguing that it’s not okay to require random WebKit

Re: [webkit-dev] Moving to Python 3

2019-07-16 Thread Konstantin Tokarev
16.07.2019, 14:33, "Guillaume Emont" : > Quoting Fujii Hironori (2019-07-16 08:04:09) >>  On Sun, Jul 14, 2019 at 7:44 AM Ryosuke Niwa wrote: >> >>  I don’t think anyone is arguing that we’d eventually need to move to >>  Python3. I’m arguing that it’s not okay to require random WebKit

Re: [webkit-dev] Moving to Python 3

2019-07-16 Thread Guillaume Emont
Quoting Fujii Hironori (2019-07-16 08:04:09) > > On Sun, Jul 14, 2019 at 7:44 AM Ryosuke Niwa wrote: > > > I don’t think anyone is arguing that we’d eventually need to move to > Python3. I’m arguing that it’s not okay to require random WebKit > contributor to know some obscure

Re: [webkit-dev] Moving to Python 3

2019-07-16 Thread Fujii Hironori
On Sun, Jul 14, 2019 at 7:44 AM Ryosuke Niwa wrote: > > I don’t think anyone is arguing that we’d eventually need to move to > Python3. I’m arguing that it’s not okay to require random WebKit > contributor to know some obscure python insanity to install Python 3, or > have a script that installs

Re: [webkit-dev] Moving to Python 3

2019-07-14 Thread Michael Catanzaro
On Sat, Jul 13, 2019 at 9:26 PM, Maciej Stachowiak wrote: Can you clarify why this is needed? Well it just wouldn't seem very kosher to use a virtualenv for the serious work of performing real distro builds, right? In contrast to developer scripts for developer convenience, where I'd say

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Adrien Destugues
>I don’t think anyone is arguing that we’d eventually need to move to >Python3. I’m arguing that it’s not okay to require random WebKit >contributor to know some obscure python insanity to install Python 3, >or >have a script that installs Python 3 and breaks all other python >scripts in >the

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Maciej Stachowiak
> On Jul 13, 2019, at 7:26 PM, Maciej Stachowiak wrote: > > > >> On Jul 13, 2019, at 4:14 PM, Michael Catanzaro wrote: >> >> On Sat, Jul 13, 2019 at 6:02 PM, Maciej Stachowiak wrote: >>> This is exactly what virtualenvs can do. And this is how we should do it >>> IMO, even for systems

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Maciej Stachowiak
> On Jul 13, 2019, at 4:14 PM, Michael Catanzaro wrote: > > On Sat, Jul 13, 2019 at 6:02 PM, Maciej Stachowiak wrote: >> This is exactly what virtualenvs can do. And this is how we should do it >> IMO, even for systems that natively have some version of Python 3. > > I guess that's fine for

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Ryosuke Niwa
On Sat, Jul 13, 2019 at 4:14 PM Michael Catanzaro wrote: > On Sat, Jul 13, 2019 at 6:02 PM, Maciej Stachowiak > wrote: > > This is exactly what virtualenvs can do. And this is how we should do > > it IMO, even for systems that natively have some version of Python 3. > > I guess that's fine for

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Michael Catanzaro
On Sat, Jul 13, 2019 at 6:02 PM, Maciej Stachowiak wrote: This is exactly what virtualenvs can do. And this is how we should do it IMO, even for systems that natively have some version of Python 3. I guess that's fine for everything not required by the CMake build, e.g. build-webkit and

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Maciej Stachowiak
> On Jul 13, 2019, at 3:44 PM, Ryosuke Niwa wrote: > >  > > >> On Fri, Jul 12, 2019 at 11:22 PM Jonathan Bedard wrote: >> I would agree that if we move to Python 3, we need a script which installs >> Python 3 in an impossible to mess-up way on Mojave and High Sierra. >> >> I don’t think

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Ryosuke Niwa
On Fri, Jul 12, 2019 at 11:22 PM Jonathan Bedard wrote: > I would agree that if we move to Python 3, we need a script which installs > Python 3 in an impossible to mess-up way on Mojave and High Sierra. > > I don’t think the clang comparison is fair here. Python 2 is officially > deprecated in

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Jonathan Bedard
I would agree that if we move to Python 3, we need a script which installs Python 3 in an impossible to mess-up way on Mojave and High Sierra. I don’t think the clang comparison is fair here. Python 2 is officially deprecated in 2020, we can’t expect security updates to the language or any

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Maciej Stachowiak
> On Jul 12, 2019, at 3:23 PM, Ryosuke Niwa wrote: > >  >> On Fri, Jul 12, 2019 at 1:04 PM Jonathan Bedard wrote: > >> >> > On Jul 12, 2019, at 12:49 PM, Michael Catanzaro >> > wrote: >> > >> > On Fri, Jul 12, 2019 at 2:18 PM, Jonathan Bedard wrote: >> >> The trouble I foresee us

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Ryosuke Niwa
On Fri, Jul 12, 2019 at 7:03 PM Michael Catanzaro wrote: > On Fri, Jul 12, 2019 at 5:22 PM, Ryosuke Niwa wrote: > > I frequently do WebKit development in older versions of macOS to > > diagnose old OS specific regressions, and having to install Python 3 > > each time I install an old OS is too

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Michael Catanzaro
On Fri, Jul 12, 2019 at 5:22 PM, Ryosuke Niwa wrote: I frequently do WebKit development in older versions of macOS to diagnose old OS specific regressions, and having to install Python 3 each time I install an old OS is too much of a trouble. I understand it would be a hassle. :/ But please

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Ryosuke Niwa
On Fri, Jul 12, 2019 at 1:04 PM Jonathan Bedard wrote: > > > On Jul 12, 2019, at 12:49 PM, Michael Catanzaro > wrote: > > > > On Fri, Jul 12, 2019 at 2:18 PM, Jonathan Bedard > wrote: > >> The trouble I foresee us encountering with any scheme which attempts a > conversion which retains both

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Jonathan Bedard
> On Jul 12, 2019, at 1:07 PM, Keith Rollin wrote: > >> On Jul 12, 2019, at 13:37, Tim Horton wrote: >> >> See "Migrating to the common subset of Python 2 and 3” — you define >> different iteritems() helpers in the two cases. Seems pretty reasonable to >> me. > > I did something like this

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Jonathan Bedard
> On Jul 12, 2019, at 12:49 PM, Michael Catanzaro wrote: > > On Fri, Jul 12, 2019 at 2:18 PM, Jonathan Bedard wrote: >> The trouble I foresee us encountering with any scheme which attempts a >> conversion which retains both Python 2.7 and Python 3 compatibility is code >> like this: > > Is

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Adrian Perez de Castro
Hello, On Fri, 12 Jul 2019 12:37:43 -0700, Tim Horton wrote: > > On Jul 12, 2019, at 12:18 PM, Jonathan Bedard wrote: > > > > Hello WebKit developers, > > > > Now that the Catalina developer seeds are available, it is official that > > the new Mac developer tools come with Python 3. As a

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Jonathan Bedard
> On Jul 12, 2019, at 12:45 PM, Robert Ma wrote: > > Any thoughts on bytes and Unicode strings, especially the string literals in > the code base? My experience with this has been you mostly have to pay attention to where your code interfaces with other processes. In webkitpy, I suspect that

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Michael Catanzaro
On Fri, Jul 12, 2019 at 2:18 PM, Jonathan Bedard wrote: The trouble I foresee us encountering with any scheme which attempts a conversion which retains both Python 2.7 and Python 3 compatibility is code like this: Is python2 support required for a well-motivated transitional purpose? I had

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Robert Ma
Any thoughts on bytes and Unicode strings, especially the string literals in the code base? On Fri, Jul 12, 2019 at 3:38 PM Tim Horton wrote: > > > On Jul 12, 2019, at 12:18 PM, Jonathan Bedard wrote: > > Hello WebKit developers, > > Now that the Catalina developer seeds are available, it is

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Don . Olmstead
, July 12, 2019 12:38 PM To: Jonathan Bedard Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Moving to Python 3 On Jul 12, 2019, at 12:18 PM, Jonathan Bedard mailto:jbed...@apple.com>> wrote: Hello WebKit developers, Now that the Catalina developer seeds are available, it is of

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Tim Horton
> On Jul 12, 2019, at 12:18 PM, Jonathan Bedard wrote: > > Hello WebKit developers, > > Now that the Catalina developer seeds are available, it is official that the > new Mac developer tools come with Python 3. As a result, we need to continue > the ongoing discussion about migrating our

[webkit-dev] Moving to Python 3

2019-07-12 Thread Jonathan Bedard
Hello WebKit developers, Now that the Catalina developer seeds are available, it is official that the new Mac developer tools come with Python 3. As a result, we need to continue the ongoing discussion about migrating our Python 2.7 scripts to Python 3. I propose that, over the next 9 months,