Re: [webkit-dev] New simplified patch review interface for bugs.webkit.org
On Oct 3, 2008, at 5:08 PM, Darin Adler wrote: On Oct 3, 2008, at 2:06 PM, Maciej Stachowiak wrote: My suggestion: I think the Edit link should be scrapped or reduced to only the few things you can't do from Review Patch, to reduce confusion. Related: There are edit links in both bug discussions and the review query that would be better if they led to Review Patch instead. Probably review requested emails should link to Review Patch as well. I filed these bugs to cover the requests I've heard so far: https://bugs.webkit.org/show_bug.cgi?id=21399 Edit links for patches are confusing/mostly redundant given Review Patch https://bugs.webkit.org/show_bug.cgi?id=21400 Edit links for patches in comments, review queue, review emails should be replaced by Review Patch links https://bugs.webkit.org/show_bug.cgi?id=21401 Comments field on Review Patch page should be initially filled with quoted patch -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] New simplified patch review interface for bugs.webkit.org
On Oct 2, 2008, at 3:13 PM, Adam Roben wrote: Hi all- Earlier today I landed a patch to add a new, simplified patch review interface to bugs.webkit.org. Looks very cool. My suggestion: I think the Edit link should be scrapped or reduced to only the few things you can't do from Review Patch, to reduce confusion. Regards, Maciej For each patch attached to a bugs, there is a new Review Patch link: Picture 42.png Clicking it will take you to a simple page with the patch on top and a comment form on the bottom: Picture 43.png Let me know if you have any problems or ideas for improvement (or file a bug on bugs.webkit.org about it)! -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] New simplified patch review interface for bugs.webkit.org
On Oct 3, 2008, at 2:06 PM, Maciej Stachowiak wrote: My suggestion: I think the Edit link should be scrapped or reduced to only the few things you can't do from Review Patch, to reduce confusion. Related: There are edit links in both bug discussions and the review query that would be better if they led to Review Patch instead. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] New simplified patch review interface for bugs.webkit.org
This is a huge improvement -- thanks Adam! John ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
