Re: [webkit-dev] PSA: COMPILE_ASSERT_MATCHING_ENUM is a bad idea

2014-02-21 Thread Enrique Ocaña González
El Miércoles, 29 de enero de 2014 08:28:39 carlo...@webkit.org escribió: > > https://bugs.webkit.org/show_bug.cgi?id=127800 WebKitGTK+ should stop > > using COMPILE_ASSERT_MATCHING_ENUM macros > Ok, let's fix this sooner rather than later, then. My apologies. It was more later rather than sooner,

Re: [webkit-dev] PSA: COMPILE_ASSERT_MATCHING_ENUM is a bad idea

2014-01-28 Thread Carlos Garcia Campos
El mar, 28-01-2014 a las 14:32 -0800, Anders Carlsson escribió: > Hi floks! > > I noticed that both the EFL port and GTK+ port use a > COMPILE_ASSERT_MATCHING_ENUM macro to make sure that WebCore enum values map > to API enum values correctly, for example: > > COMPILE_ASSERT_MATCHING_ENUM(WEBK

[webkit-dev] PSA: COMPILE_ASSERT_MATCHING_ENUM is a bad idea

2014-01-28 Thread Anders Carlsson
Hi floks! I noticed that both the EFL port and GTK+ port use a COMPILE_ASSERT_MATCHING_ENUM macro to make sure that WebCore enum values map to API enum values correctly, for example: COMPILE_ASSERT_MATCHING_ENUM(WEBKIT_WEB_NAVIGATION_REASON_LINK_CLICKED, NavigationTypeLinkClicked); This means