Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-27 Thread Glenn Adams
On Fri, Mar 22, 2013 at 3:24 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi all, I've made a change to NRWT in http://trac.webkit.org/changeset/146657 so that it always generate pixel results in retries even when pixel tests are disabled by default (on all but Chromium ports). We now enable

Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-27 Thread Glenn Adams
On Wed, Mar 27, 2013 at 9:16 AM, Glenn Adams gl...@skynav.com wrote: On Fri, Mar 22, 2013 at 3:24 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi all, I've made a change to NRWT in http://trac.webkit.org/changeset/146657 so that it always generate pixel results in retries even when pixel tests

Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-27 Thread Glenn Adams
On Wed, Mar 27, 2013 at 11:46 AM, Glenn Adams gl...@skynav.com wrote: On Wed, Mar 27, 2013 at 9:16 AM, Glenn Adams gl...@skynav.com wrote: On Fri, Mar 22, 2013 at 3:24 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi all, I've made a change to NRWT in http://trac.webkit.org/changeset/146657so

Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-24 Thread Ryosuke Niwa
On Sat, Mar 23, 2013 at 10:25 PM, Robert Hogan li...@roberthogan.netwrote: This will allow us to rebaseline BOTH test and image expected results PRIOR to landing patches. You're welcome. Great stuff. Thanks for doing this! A question for the Qt/gtk/efl ports: do you plan to put some

Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-24 Thread Zeno Albisser
As far as I am informed we (Qt) are not running tests on EWS, due to limited resources. Therefore you would still not be able to receive the -expected.png files before landing your patch. But just right afterwards with the first bot failing. May be we need to consider changing our Qt-EWS? - Zeno

Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-24 Thread Ryosuke Niwa
On Sun, Mar 24, 2013 at 2:06 AM, Zeno Albisser z...@webkit.org wrote: As far as I am informed we (Qt) are not running tests on EWS, due to limited resources. Therefore you would still not be able to receive the -expected.png files before landing your patch. But just right afterwards with the

Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-23 Thread Robert Hogan
This will allow us to rebaseline BOTH test and image expected results PRIOR to landing patches. You're welcome. Great stuff. Thanks for doing this! A question for the Qt/gtk/efl ports: do you plan to put some testers on the EWS queue? If not, I think you should shout if you do not want

[webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-22 Thread Ryosuke Niwa
Hi all, I've made a change to NRWT in http://trac.webkit.org/changeset/146657 so that it always generate pixel results in retries even when pixel tests are disabled by default (on all but Chromium ports). We now enable pixel tests while we're retrying tests and generate -expected.png results.