Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

[Adam Barth]

On Fri, Mar 2, 2012 at 3:10 PM, Adam Barth  wrote:
> I've just started investigating that issue (which is why the patch is
> labeled "work-in-progress").  Is there a reason SQLDatabase is special
> cased in PageCache?  Most features interact with the PageCache via
> ActiveDOMObject::canSuspend().  In that bug, I'm investigating why
> SQLDatabase doesn't just use the same general mechanism as other
> features.

So, it turns out there is a good reason, which I've documented at
https://bugs.webkit.org/show_bug.cgi?id=80193#c4 if you're interested.

Thanks everyone,
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

[Adam Barth]

2012/3/5 Alexey Proskuryakov :
> 05.03.2012, в 11:29, Adam Barth написал(а):
>> For better or worse, Geolocation doesn't support suspend/resume
>> (yet?)
>
>  Pages that use Geolocation 
> should be able to use the page cache

Thanks.  I'll add a link in a FIXME comment.  This patch should make
adding that feature easier in the future.

Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

[Alexey Proskuryakov]

05.03.2012, в 11:29, Adam Barth написал(а):

> For better or worse, Geolocation doesn't support suspend/resume
> (yet?)

 Pages that use Geolocation 
should be able to use the page cache

- WBR, Alexey Proskuryakov

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

[Adam Barth]

On Mon, Mar 5, 2012 at 8:47 AM, Brady Eidson  wrote:
> On Mar 2, 2012, at 3:10 PM, Adam Barth  wrote:
>> 2012/3/2 Alexey Proskuryakov :
>>> It seems that we have some agreement on what to modularize, but not 
>>> necessarily agreement on what the modularization should encompass.
>>>
>>> For example, I think that  
>>> that moves some knowledge of what makes a page uncacheable out of 
>>> PageCache::canCachePageContainingThisFrame makes the code less hackable, 
>>> and is likely to become a disadvantage.
>>
>> I've just started investigating that issue (which is why the patch is
>> labeled "work-in-progress").  Is there a reason SQLDatabase is special
>> cased in PageCache?  Most features interact with the PageCache via
>> ActiveDOMObject::canSuspend().  In that bug, I'm investigating why
>> SQLDatabase doesn't just use the same general mechanism as other
>> features.
>
> There's no great mystery.  SQLDatabase was added before we had the 
> ActiveDOMObject mechanism.

Makes sense.

2012/3/5 Alexey Proskuryakov :
> It's difficult to make something an ActiveDOMObjects without introducing 
> subtle bugs. The automatic invocation of suspend/resume functions it provides 
> comes at the cost of unpredictable order they are invoked in, and of very 
> strict limitations on what these functions can do.

For better or worse, Geolocation doesn't support suspend/resume
(yet?), so this isn't much of a concern for this patch.

Thanks,
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

[Alexey Proskuryakov]

02.03.2012, в 15:10, Adam Barth написал(а):

>> For example, I think that  
>> that moves some knowledge of what makes a page uncacheable out of 
>> PageCache::canCachePageContainingThisFrame makes the code less hackable, and 
>> is likely to become a disadvantage.
> 
> I've just started investigating that issue (which is why the patch is
> labeled "work-in-progress").  

That's understood. Do you find it inappropriate to make comments about patches 
in Bugzilla that are work in progress?

> Is there a reason SQLDatabase is special
> cased in PageCache?  Most features interact with the PageCache via
> ActiveDOMObject::canSuspend().  In that bug, I'm investigating why
> SQLDatabase doesn't just use the same general mechanism as other
> features.

It's difficult to make something an ActiveDOMObjects without introducing subtle 
bugs. The automatic invocation of suspend/resume functions it provides comes at 
the cost of unpredictable order they are invoked in, and of very strict 
limitations on what these functions can do.

- WBR, Alexey Proskuryakov

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

[Brady Eidson]

On Mar 2, 2012, at 3:10 PM, Adam Barth  wrote:

> 2012/3/2 Alexey Proskuryakov :
>> It seems that we have some agreement on what to modularize, but not 
>> necessarily agreement on what the modularization should encompass.
>> 
>> For example, I think that  
>> that moves some knowledge of what makes a page uncacheable out of 
>> PageCache::canCachePageContainingThisFrame makes the code less hackable, and 
>> is likely to become a disadvantage.
> 
> I've just started investigating that issue (which is why the patch is
> labeled "work-in-progress").  Is there a reason SQLDatabase is special
> cased in PageCache?  Most features interact with the PageCache via
> ActiveDOMObject::canSuspend().  In that bug, I'm investigating why
> SQLDatabase doesn't just use the same general mechanism as other
> features.

There's no great mystery.  SQLDatabase was added before we had the 
ActiveDOMObject mechanism.

Thanks,
~Brady

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

[Adam Barth]

2012/3/2 Alexey Proskuryakov :
> It seems that we have some agreement on what to modularize, but not 
> necessarily agreement on what the modularization should encompass.
>
> For example, I think that  
> that moves some knowledge of what makes a page uncacheable out of 
> PageCache::canCachePageContainingThisFrame makes the code less hackable, and 
> is likely to become a disadvantage.

I've just started investigating that issue (which is why the patch is
labeled "work-in-progress").  Is there a reason SQLDatabase is special
cased in PageCache?  Most features interact with the PageCache via
ActiveDOMObject::canSuspend().  In that bug, I'm investigating why
SQLDatabase doesn't just use the same general mechanism as other
features.

Thanks,
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev