Re: [webkit-dev] Please do NOT call Position::Position(node, offset) or Position::node()

I thought this will add unnecessary noise to svn log but I changed my mind because I find it really hard to locate all call sites of Position::node(). https://bugs.webkit.org/show_bug.cgi?id=54622 https://bugs.webkit.org/show_bug.cgi?id=54622- Ryosuke On Thu, Jan 20, 2011 at 11:17 AM, Adam

[webkit-dev] Please do NOT call Position::Position(node, offset) or Position::node()

Hi everyone, Please DO NOT instantiate a Position object by Position::Position(PassRefPtr Node anchorNode, int offset) or call Position::node(). The above constructor creates a legacy editing position, which we're trying to get rid of [1]. Please use Position(PassRefPtrNode anchorNode, int

Re: [webkit-dev] Please do NOT call Position::Position(node, offset) or Position::node()

One approach we've used in other code is to put the word deprecated in the name of the function in question. That makes these issues very visible in code reviews. For a constructor, you can require an enum value with depreciated in its name. Adam On Wed, Jan 19, 2011 at 6:11 PM, Ryosuke Niwa