Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Sat, Mar 23, 2013 at 7:34 AM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:43 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer silvi...@chromium.orgwrote: On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak m...@apple.comwrote: On Mar 21, 2013, at 5:38 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Well, it's been working for me. The fact you appears to be contributing patches without appropriate rebaselines seems to indicate that it's not working for us. Oh, please point out a case of without appropriate rebaseline. Please point out in the documentation where appropriate rebaseline is defined. I think you are making unwarranted assumptions here. If you can't define or understand a process where I can contribute using a MBP Retina, then I think you are imposing an arbitrary, unwarranted restriction on the community. I have been contributing successfully, ergo, it is working. Many are contributing WebCore layout and rendering patches using a wide variety of platforms, not all of which match your platform assumptions. It is not reasonable to claim they aren't contributing positively or that their contributions don't work. We should definitely make it possible to contribute using a Retina system. Apple's flagship laptops offer Retina displays, and it would be crazy to rule them out as development machines. I'd imagine one day we may want the canonical Mac pixel results to be *only* retina. Yes, we should but it isn't today. Perhaps one possibility is to make it possible to generate non-Retina pixel results on a Retina system. That seems eminently doable to me, unless there's something I am missing. Yeah, Alexey and I were talking about this earlier. We need a some way to force CAGraphics, etc… to behave as if we're in non-Retina MBP. We definitely don't want to check in Retina pixel results. Where can I sign up to make this a higher priority. ;-) Post a patch on https://bugs.webkit.org/show_bug.cgi?id=93673. Tim (thorton) kindly took time to fix this problem in http://trac.webkit.org/changeset/146650 at least for render tree dumps. Pixel tests still do fail for obvious reasons but this is a huge improvement nonetheless. Thanks to both of you! That's awesome!! Silvia. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 6:43 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer silvi...@chromium.orgwrote: On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak m...@apple.comwrote: On Mar 21, 2013, at 5:38 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Well, it's been working for me. The fact you appears to be contributing patches without appropriate rebaselines seems to indicate that it's not working for us. Oh, please point out a case of without appropriate rebaseline. Please point out in the documentation where appropriate rebaseline is defined. I think you are making unwarranted assumptions here. If you can't define or understand a process where I can contribute using a MBP Retina, then I think you are imposing an arbitrary, unwarranted restriction on the community. I have been contributing successfully, ergo, it is working. Many are contributing WebCore layout and rendering patches using a wide variety of platforms, not all of which match your platform assumptions. It is not reasonable to claim they aren't contributing positively or that their contributions don't work. We should definitely make it possible to contribute using a Retina system. Apple's flagship laptops offer Retina displays, and it would be crazy to rule them out as development machines. I'd imagine one day we may want the canonical Mac pixel results to be *only* retina. Yes, we should but it isn't today. Perhaps one possibility is to make it possible to generate non-Retina pixel results on a Retina system. That seems eminently doable to me, unless there's something I am missing. Yeah, Alexey and I were talking about this earlier. We need a some way to force CAGraphics, etc… to behave as if we're in non-Retina MBP. We definitely don't want to check in Retina pixel results. Where can I sign up to make this a higher priority. ;-) Post a patch on https://bugs.webkit.org/show_bug.cgi?id=93673. Tim (thorton) kindly took time to fix this problem in http://trac.webkit.org/changeset/146650 at least for render tree dumps. Pixel tests still do fail for obvious reasons but this is a huge improvement nonetheless. Thanks Tim! - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Mar 22, 2013, at 1:34 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:43 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer silvi...@chromium.org wrote: On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 21, 2013, at 5:38 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Well, it's been working for me. The fact you appears to be contributing patches without appropriate rebaselines seems to indicate that it's not working for us. Oh, please point out a case of without appropriate rebaseline. Please point out in the documentation where appropriate rebaseline is defined. I think you are making unwarranted assumptions here. If you can't define or understand a process where I can contribute using a MBP Retina, then I think you are imposing an arbitrary, unwarranted restriction on the community. I have been contributing successfully, ergo, it is working. Many are contributing WebCore layout and rendering patches using a wide variety of platforms, not all of which match your platform assumptions. It is not reasonable to claim they aren't contributing positively or that their contributions don't work. We should definitely make it possible to contribute using a Retina system. Apple's flagship laptops offer Retina displays, and it would be crazy to rule them out as development machines. I'd imagine one day we may want the canonical Mac pixel results to be *only* retina. Yes, we should but it isn't today. Perhaps one possibility is to make it possible to generate non-Retina pixel results on a Retina system. That seems eminently doable to me, unless there's something I am missing. Yeah, Alexey and I were talking about this earlier. We need a some way to force CAGraphics, etc… to behave as if we're in non-Retina MBP. We definitely don't want to check in Retina pixel results. Where can I sign up to make this a higher priority. ;-) Post a patch on https://bugs.webkit.org/show_bug.cgi?id=93673. Tim (thorton) kindly took time to fix this problem in http://trac.webkit.org/changeset/146650 at least for render tree dumps. Pixel tests still do fail for obvious reasons but this is a huge improvement nonetheless. Obvious reasons == they fail on 1x machines too, right? Thanks Tim! Sure! - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Please don't land patches without rebaselining tests for at least one platform
Lately, I've encountering changesets that only add lines to TestExpectations and then never baseline tests for any platform. This makes it impossible to figure out what the expected results is for other platforms the patch author doesn't contribute to / care about. Furthermore, I don't know how reviewers are reviewing those patches given that they can't see new expected results on Bugzilla. Maybe they're reviewing patches in person? - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa rn...@webkit.org wrote: Lately, I've encountering changesets that only add lines to TestExpectations and then never baseline tests for any platform. This (never rebaseline tests for any platform in that changeset) may not be possible depending on circumstances. For example, I do my dev work on MBP Retina, which produces different baselines than the platforms used for mac test bots. As a result, I sometimes have no choice but to land a changeset without a new baseline and then use garden-o-matic after-the-fact to land a new baseline. Or do you have an alternative in mind that would work in my case? Note that it really isn't practical for me to ask another dev to build my patch before landing in order to provide me a new baseline that i can add to the patch. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa rn...@webkit.org wrote: Lately, I've encountering changesets that only add lines to TestExpectations and then never baseline tests for any platform. This (never rebaseline tests for any platform in that changeset) may not be possible depending on circumstances. For example, I do my dev work on MBP Retina, which produces different baselines than the platforms used for mac test bots. As a result, I sometimes have no choice but to land a changeset without a new baseline and then use garden-o-matic after-the-fact to land a new baseline. Then how are you verifying that your patch is correct? How are reviewers supposed to review such a patch? Uploading a rendering engine patch without first verifying that tests are still passing and new tests are generating results as expected sounds like a bad idea to me. Or do you have an alternative in mind that would work in my case? Note that it really isn't practical for me to ask another dev to build my patch before landing in order to provide me a new baseline that i can add to the patch. As I've announced on another thread, EWS now uploads actual results on Bugzilla so this shouldn't be an issue anymore. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa rn...@webkit.org wrote: Lately, I've encountering changesets that only add lines to TestExpectations and then never baseline tests for any platform. This (never rebaseline tests for any platform in that changeset) may not be possible depending on circumstances. For example, I do my dev work on MBP Retina, which produces different baselines than the platforms used for mac test bots. As a result, I sometimes have no choice but to land a changeset without a new baseline and then use garden-o-matic after-the-fact to land a new baseline. Then how are you verifying that your patch is correct? How are reviewers supposed to review such a patch? Uploading a rendering engine patch without first verifying that tests are still passing and new tests are generating results as expected sounds like a bad idea to me. Of course I am verifying that tests are still passing and that new tests are generating results as expected. I do this by running NRWT without the patch, running it with the patch, then comparing results. This generally allows me to see new failures, which I manually review to determine the nature of the difference. If the difference is simply minor pixel positioning deltas (in text or image output), then I operate on the tentative hypothesis that a rebaseline is needed for the given test, unless I happen to be making a change that could be attributed to cause the delta. I'm also relying upon EWS to catch a regression before asking for a review. Or do you have an alternative in mind that would work in my case? Note that it really isn't practical for me to ask another dev to build my patch before landing in order to provide me a new baseline that i can add to the patch. As I've announced on another thread, EWS now uploads actual results on Bugzilla so this shouldn't be an issue anymore. But EWS is only testing on a couple of platform/ports yes? Presumably this will still impact qt/gtk/efl and perhaps others where EWS is just building and not testing? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 4:36 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa rn...@webkit.org wrote: Lately, I've encountering changesets that only add lines to TestExpectations and then never baseline tests for any platform. This (never rebaseline tests for any platform in that changeset) may not be possible depending on circumstances. For example, I do my dev work on MBP Retina, which produces different baselines than the platforms used for mac test bots. As a result, I sometimes have no choice but to land a changeset without a new baseline and then use garden-o-matic after-the-fact to land a new baseline. Then how are you verifying that your patch is correct? How are reviewers supposed to review such a patch? Uploading a rendering engine patch without first verifying that tests are still passing and new tests are generating results as expected sounds like a bad idea to me. Of course I am verifying that tests are still passing and that new tests are generating results as expected. I do this by running NRWT without the patch, running it with the patch, then comparing results. This generally allows me to see new failures, which I manually review to determine the nature of the difference. If the difference is simply minor pixel positioning deltas (in text or image output), then I operate on the tentative hypothesis that a rebaseline is needed for the given test, unless I happen to be making a change that could be attributed to cause the delta. That sounds like a dangerous assumption to make. Due to the DPI differences, things like anti-aliasing will behave quite differently on Retina MBP. In general, I don't recommend people running and relying on layout tests on Retina MBP especially if you work on the rendering engine at this time. Or do you have an alternative in mind that would work in my case? Note that it really isn't practical for me to ask another dev to build my patch before landing in order to provide me a new baseline that i can add to the patch. As I've announced on another thread, EWS now uploads actual results on Bugzilla so this shouldn't be an issue anymore. But EWS is only testing on a couple of platform/ports yes? Presumably this will still impact qt/gtk/efl and perhaps others where EWS is just building and not testing? That's fine. I'm asking that you include rebaselines for at least one platform in the case that wasn't clear. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:36 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa rn...@webkit.orgwrote: Lately, I've encountering changesets that only add lines to TestExpectations and then never baseline tests for any platform. This (never rebaseline tests for any platform in that changeset) may not be possible depending on circumstances. For example, I do my dev work on MBP Retina, which produces different baselines than the platforms used for mac test bots. As a result, I sometimes have no choice but to land a changeset without a new baseline and then use garden-o-matic after-the-fact to land a new baseline. Then how are you verifying that your patch is correct? How are reviewers supposed to review such a patch? Uploading a rendering engine patch without first verifying that tests are still passing and new tests are generating results as expected sounds like a bad idea to me. Of course I am verifying that tests are still passing and that new tests are generating results as expected. I do this by running NRWT without the patch, running it with the patch, then comparing results. This generally allows me to see new failures, which I manually review to determine the nature of the difference. If the difference is simply minor pixel positioning deltas (in text or image output), then I operate on the tentative hypothesis that a rebaseline is needed for the given test, unless I happen to be making a change that could be attributed to cause the delta. That sounds like a dangerous assumption to make. Due to the DPI differences, things like anti-aliasing will behave quite differently on Retina MBP. A hypothesis is not an assumption. It needs to be tested further. Be sure I am not making any unwarranted assumption. In general, I don't recommend people running and relying on layout tests on Retina MBP especially if you work on the rendering engine at this time. That's my platform, so I have to manage with it. Or do you have an alternative in mind that would work in my case? Note that it really isn't practical for me to ask another dev to build my patch before landing in order to provide me a new baseline that i can add to the patch. As I've announced on another thread, EWS now uploads actual results on Bugzilla so this shouldn't be an issue anymore. But EWS is only testing on a couple of platform/ports yes? Presumably this will still impact qt/gtk/efl and perhaps others where EWS is just building and not testing? That's fine. I'm asking that you include rebaselines for at least one platform in the case that wasn't clear. I will if possible, but I'm just saying it may not be possible on the initial landing in all cases. If it isn't then I expect to have to add rebaseline expectations and then take responsibility for following up on them ASAP. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:36 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa rn...@webkit.orgwrote: Lately, I've encountering changesets that only add lines to TestExpectations and then never baseline tests for any platform. This (never rebaseline tests for any platform in that changeset) may not be possible depending on circumstances. For example, I do my dev work on MBP Retina, which produces different baselines than the platforms used for mac test bots. As a result, I sometimes have no choice but to land a changeset without a new baseline and then use garden-o-matic after-the-fact to land a new baseline. Then how are you verifying that your patch is correct? How are reviewers supposed to review such a patch? Uploading a rendering engine patch without first verifying that tests are still passing and new tests are generating results as expected sounds like a bad idea to me. Of course I am verifying that tests are still passing and that new tests are generating results as expected. I do this by running NRWT without the patch, running it with the patch, then comparing results. This generally allows me to see new failures, which I manually review to determine the nature of the difference. If the difference is simply minor pixel positioning deltas (in text or image output), then I operate on the tentative hypothesis that a rebaseline is needed for the given test, unless I happen to be making a change that could be attributed to cause the delta. That sounds like a dangerous assumption to make. Due to the DPI differences, things like anti-aliasing will behave quite differently on Retina MBP. A hypothesis is not an assumption. It needs to be tested further. Be sure I am not making any unwarranted assumption. I don't think operating based on a hypothesis is a good idea either. In general, I don't recommend people running and relying on layout tests on Retina MBP especially if you work on the rendering engine at this time. That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. As I've announced on another thread, EWS now uploads actual results on Bugzilla so this shouldn't be an issue anymore. But EWS is only testing on a couple of platform/ports yes? Presumably this will still impact qt/gtk/efl and perhaps others where EWS is just building and not testing? That's fine. I'm asking that you include rebaselines for at least one platform in the case that wasn't clear. I will if possible, but I'm just saying it may not be possible on the initial landing in all cases. If it isn't then I expect to have to add rebaseline expectations and then take responsibility for following up on them ASAP. What are cases where this is not possible? We need to fix that. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Fri, Mar 22, 2013 at 10:55 AM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa rn...@webkit.org wrote: In general, I don't recommend people running and relying on layout tests on Retina MBP especially if you work on the rendering engine at this time. That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Why is that the case? Why can't we start creating pixel test expectation for Retina MBPs? Silvia. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 5:04 PM, Silvia Pfeiffer silvi...@chromium.orgwrote: On Fri, Mar 22, 2013 at 10:55 AM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa rn...@webkit.org wrote: In general, I don't recommend people running and relying on layout tests on Retina MBP especially if you work on the rendering engine at this time. That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Why is that the case? Why can't we start creating pixel test expectation for Retina MBPs? Because run-webkit-tests doesn't support it. We don't even have a way of whether we're running on Retina MBP or not. If implemented correctly, retina will be a new dimension relative to platform and WK2. There will be a combinatorial explosion though because any given platform (e.g. Mountain Lion) could have combinations of WK1/WK2 and Retina/non-Retina. I have been discussing this matter with my colleagues but we haven't gotten around to implement it. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Well, it's been working for me. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Well, it's been working for me. The fact you appears to be contributing patches without appropriate rebaselines seems to indicate that it's not working for us. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Well, it's been working for me. The fact you appears to be contributing patches without appropriate rebaselines seems to indicate that it's not working for us. Oh, please point out a case of without appropriate rebaseline. Please point out in the documentation where appropriate rebaseline is defined. I think you are making unwarranted assumptions here. If you can't define or understand a process where I can contribute using a MBP Retina, then I think you are imposing an arbitrary, unwarranted restriction on the community. I have been contributing successfully, ergo, it is working. Many are contributing WebCore layout and rendering patches using a wide variety of platforms, not all of which match your platform assumptions. It is not reasonable to claim they aren't contributing positively or that their contributions don't work. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Mar 21, 2013, at 5:38 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Well, it's been working for me. The fact you appears to be contributing patches without appropriate rebaselines seems to indicate that it's not working for us. Oh, please point out a case of without appropriate rebaseline. Please point out in the documentation where appropriate rebaseline is defined. I think you are making unwarranted assumptions here. If you can't define or understand a process where I can contribute using a MBP Retina, then I think you are imposing an arbitrary, unwarranted restriction on the community. I have been contributing successfully, ergo, it is working. Many are contributing WebCore layout and rendering patches using a wide variety of platforms, not all of which match your platform assumptions. It is not reasonable to claim they aren't contributing positively or that their contributions don't work. We should definitely make it possible to contribute using a Retina system. Apple's flagship laptops offer Retina displays, and it would be crazy to rule them out as development machines. I'd imagine one day we may want the canonical Mac pixel results to be *only* retina. Perhaps one possibility is to make it possible to generate non-Retina pixel results on a Retina system. That seems eminently doable to me, unless there's something I am missing. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 21, 2013, at 5:38 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Well, it's been working for me. The fact you appears to be contributing patches without appropriate rebaselines seems to indicate that it's not working for us. Oh, please point out a case of without appropriate rebaseline. Please point out in the documentation where appropriate rebaseline is defined. I think you are making unwarranted assumptions here. If you can't define or understand a process where I can contribute using a MBP Retina, then I think you are imposing an arbitrary, unwarranted restriction on the community. I have been contributing successfully, ergo, it is working. Many are contributing WebCore layout and rendering patches using a wide variety of platforms, not all of which match your platform assumptions. It is not reasonable to claim they aren't contributing positively or that their contributions don't work. We should definitely make it possible to contribute using a Retina system. Apple's flagship laptops offer Retina displays, and it would be crazy to rule them out as development machines. I'd imagine one day we may want the canonical Mac pixel results to be *only* retina. Yes, we should but it isn't today. Perhaps one possibility is to make it possible to generate non-Retina pixel results on a Retina system. That seems eminently doable to me, unless there's something I am missing. Yeah, Alexey and I were talking about this earlier. We need a some way to force CAGraphics, etc… to behave as if we're in non-Retina MBP. We definitely don't want to check in Retina pixel results. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 21, 2013, at 5:38 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Well, it's been working for me. The fact you appears to be contributing patches without appropriate rebaselines seems to indicate that it's not working for us. Oh, please point out a case of without appropriate rebaseline. Please point out in the documentation where appropriate rebaseline is defined. I think you are making unwarranted assumptions here. If you can't define or understand a process where I can contribute using a MBP Retina, then I think you are imposing an arbitrary, unwarranted restriction on the community. I have been contributing successfully, ergo, it is working. Many are contributing WebCore layout and rendering patches using a wide variety of platforms, not all of which match your platform assumptions. It is not reasonable to claim they aren't contributing positively or that their contributions don't work. We should definitely make it possible to contribute using a Retina system. Apple's flagship laptops offer Retina displays, and it would be crazy to rule them out as development machines. I'd imagine one day we may want the canonical Mac pixel results to be *only* retina. Yes, we should but it isn't today. Perhaps one possibility is to make it possible to generate non-Retina pixel results on a Retina system. That seems eminently doable to me, unless there's something I am missing. Yeah, Alexey and I were talking about this earlier. We need a some way to force CAGraphics, etc… to behave as if we're in non-Retina MBP. We definitely don't want to check in Retina pixel results. Where can I sign up to make this a higher priority. ;-) Developing on the Retina MBP is a real joy because of its speed and beautiful display - it is faster than the old Mac Pro I had. I was bummed to find out that I couldn't create pixel results on it nor properly run layout tests. Now I have a separate Linux machine for layout testing. Silvia. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform
On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer silvi...@chromium.orgwrote: On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 21, 2013, at 5:38 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because of this issue. It's expected that every contributor has access to a machine where he/she can run layout tests. Retina MBP is not such a machine. Well, it's been working for me. The fact you appears to be contributing patches without appropriate rebaselines seems to indicate that it's not working for us. Oh, please point out a case of without appropriate rebaseline. Please point out in the documentation where appropriate rebaseline is defined. I think you are making unwarranted assumptions here. If you can't define or understand a process where I can contribute using a MBP Retina, then I think you are imposing an arbitrary, unwarranted restriction on the community. I have been contributing successfully, ergo, it is working. Many are contributing WebCore layout and rendering patches using a wide variety of platforms, not all of which match your platform assumptions. It is not reasonable to claim they aren't contributing positively or that their contributions don't work. We should definitely make it possible to contribute using a Retina system. Apple's flagship laptops offer Retina displays, and it would be crazy to rule them out as development machines. I'd imagine one day we may want the canonical Mac pixel results to be *only* retina. Yes, we should but it isn't today. Perhaps one possibility is to make it possible to generate non-Retina pixel results on a Retina system. That seems eminently doable to me, unless there's something I am missing. Yeah, Alexey and I were talking about this earlier. We need a some way to force CAGraphics, etc… to behave as if we're in non-Retina MBP. We definitely don't want to check in Retina pixel results. Where can I sign up to make this a higher priority. ;-) Post a patch on https://bugs.webkit.org/show_bug.cgi?id=93673. Developing on the Retina MBP is a real joy because of its speed and beautiful display - it is faster than the old Mac Pro I had. I was bummed to find out that I couldn't create pixel results on it nor properly run layout tests. Now I have a separate Linux machine for layout testing. Yes, I would love to be able to do that. Today, unfortunately, we can't :( - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
