Re: [webkit-dev] Problem with a crash using JSC code

2015-01-27 Thread Benjamin Poulain
There is not formal size limit for any patch, some changes are inherently big. Experience shows that big patch tends to have more hidden bugs and poorer code coverage. It is better to go forward by little step while having huge test coverage at every step.

Re: [webkit-dev] Problem with a crash using JSC code

2015-01-26 Thread youenn fablet
The latest patch at https://bugs.webkit.org/show_bug.cgi?id=138967 resolves the crash (some JSC::Strong were missing). I fear that the patch may be a bit too big to get a thorough review though. The patch could be split into meaningful but not testable sub-patches (module stuff, JS integration

[webkit-dev] Problem with a crash using JSC code

2015-01-21 Thread Xabier Rodríguez Calvar
Hi! I am now implementing with Youenn the Streams API standard [1] in WebKit. You can find the first patch at [2] (it's r? now). While we get that patch reviewed and landed we are adding more tests and working out the problems. One of them is one crash that I cannot hunt, with the