Re: [webkit-dev] Process for making changes that affect layout test results

2012-04-12 Thread Tony Payne
On Wed, Apr 11, 2012 at 4:58 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Apr 11, 2012 at 4:56 PM, Tony Payne tpa...@chromium.org wrote: Some of these test result changes turn out to be the effect of incorrect test cases. For example,

[webkit-dev] Process for making changes that affect layout test results

2012-04-11 Thread Tony Payne
Given the recent discussion on test_expectations.txt, perhaps the answer to my question is still up in the air. I'm working on a change that I expect to require changing the expectations for about 75 tests on chromium win and linux. https://trac.webkit.org/wiki/Rebaseline seems to only cover the

Re: [webkit-dev] Process for making changes that affect layout test results

2012-04-11 Thread Ryosuke Niwa
On Wed, Apr 11, 2012 at 1:57 PM, Tony Payne tpa...@chromium.org wrote: Given the recent discussion on test_expectations.txt, perhaps the answer to my question is still up in the air. I'm working on a change that I expect to require changing the expectations for about 75 tests on chromium win

Re: [webkit-dev] Process for making changes that affect layout test results

2012-04-11 Thread Tony Payne
All code I'm changing is inside of #if PLATFORM(CHROMIUM) blocks. Thanks for the quick answer. Tony On Wed, Apr 11, 2012 at 2:03 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Apr 11, 2012 at 1:57 PM, Tony Payne tpa...@chromium.org wrote: Given the recent discussion on

Re: [webkit-dev] Process for making changes that affect layout test results

2012-04-11 Thread Ojan Vafai
Typically, if you're working on Chromium Linux or Win, you'd include the new expected results for that platform in your initial commit/code-review as well. On Wed, Apr 11, 2012 at 2:09 PM, Tony Payne tpa...@chromium.org wrote: All code I'm changing is inside of #if PLATFORM(CHROMIUM) blocks.

Re: [webkit-dev] Process for making changes that affect layout test results

2012-04-11 Thread Tony Payne
Is the best way to do that to use run_webkit_tests to generate a new baseline or does Tools/Scripts/webkitpy/tool/commands/rebaseline.py support pulling new baselines from the trybots? Thanks, Tony On Wed, Apr 11, 2012 at 2:13 PM, Ojan Vafai o...@chromium.org wrote: Typically, if you're

Re: [webkit-dev] Process for making changes that affect layout test results

2012-04-11 Thread Dirk Pranke
use run-webkit-tests (or attempt to pull the results from the trybots by hand). You cannot pull new baselines from the try bots using rebaseline.py. -- Dirk On Wed, Apr 11, 2012 at 3:26 PM, Tony Payne tpa...@chromium.org wrote: Is the best way to do that to use run_webkit_tests to generate a

Re: [webkit-dev] Process for making changes that affect layout test results

2012-04-11 Thread Dirk Pranke
On Wed, Apr 11, 2012 at 4:56 PM, Tony Payne tpa...@chromium.org wrote: Some of these test result changes turn out to be the effect of incorrect test cases. For example, compositing/color-matching/image-color-matching.html compares an image without a color profile with an image tagged with