Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

Thanks for gathering this data! >> What are some notable cases of recent regressions that have landed because >> of non-use of commit queue and caused serious problems? > > Some recent examples of regressions that would have been prevented by > mandatory commit/merge-queue as proposed: > > htt

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

> On Jun 3, 2022, at 7:59 AM, Geoffrey Garen wrote: > >>> What is the goal of this proposal? >> >> The goal is to increase the stability of the build > > Is this goal distinct from preventing regressions from landing? If so, how? > >> , speed up EWS by preventing regressions from landing >

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

>> What is the goal of this proposal? > > The goal is to increase the stability of the build Is this goal distinct from preventing regressions from landing? If so, how? > , speed up EWS by preventing regressions from landing What are some notable cases of recent regressions that have landed bec

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

> On Jun 2, 2022, at 4:41 PM, Geoffrey Garen wrote: > >  >> As we move to GitHub, I would like to propose we strengthen our protections >> on `main` by making MergeQueue and CommitQueue mandatory. > > > What is the goal of this proposal? The goal is to increase the stability of the build,

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

> On Jun 2, 2022, at 6:29 PM, Michael Catanzaro wrote: > > > > On Thu, Jun 2 2022 at 04:06:42 PM -0700, Chris Dumez via webkit-dev > wrote: >> I am concerned by this proposal given how slow EWS and the merge queue are >> these days. > > Hopefully Jonathan's three proposed blockers will ad

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

On Thu, Jun 2 2022 at 04:06:42 PM -0700, Chris Dumez via webkit-dev wrote: I am concerned by this proposal given how slow EWS and the merge queue are these days. Hopefully Jonathan's three proposed blockers will address this: - run-webkit-tests consulting results.webkit.org to avoid ret

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

I am concerned by this proposal given how slow EWS and the merge queue are these days. I think the issue is likely related to failures on the bots and the retries needed to determine if those failures are new. We’ve never had this restriction before. Seems we are becoming overly strict with t

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

> As we move to GitHub, I would like to propose we strengthen our protections > on `main` by making MergeQueue and CommitQueue mandatory. What is the goal of this proposal? What problem are you trying to solve, and with what level of urgency? Thanks, Geoff > On Jun 2, 2022, at 2:35 PM, Jona

[webkit-dev] Proposal: Mandatory Commit and Merge Queue

As we move to GitHub, I would like to propose we strengthen our protections on `main` by making MergeQueue and CommitQueue mandatory. This would mean that with a few exceptions, all changes would need to be built and run layout tests before they are landed. To spell out what the exceptions I had