Re: [webkit-dev] Qt compilation problem
The reason I used this mailing list is because this is a clear regression not just a build problem on my side. If proven otherwise, I am sorry. Qt-specific stuff can be asked in the webkit-qt lists as well. Regards, -- Ariya Hidayat http://www.linkedin.com/in/ariyahidayat ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Qt compilation problem
Hi; On Fri, Feb 5, 2010 at 1:35 PM, İsmail Dönmez ism...@namtrac.org wrote: Hi Darin; On Fri, Feb 5, 2010 at 1:32 PM, Darin Adler da...@apple.com wrote: This is a question for the webkit-help mailing list or a Qt-specific one, not webkit-dev. The webkit-dev mailing list is for discussion of WebKit development, not building or using it. See http://webkit.org/contact.html. The reason I used this mailing list is because this is a clear regression not just a build problem on my side. If proven otherwise, I am sorry. Looks like nmake messes up when the filenames match. Following patch fixes this (of course after doing a git mv), can someone comment? diff --git a/WebCore/WebCore.pro b/WebCore/WebCore.pro index 4d2c597..0b062d0 100644 --- a/WebCore/WebCore.pro +++ b/WebCore/WebCore.pro @@ -1999,7 +1999,7 @@ SOURCES += \ platform/qt/FileSystemQt.cpp \ platform/qt/SharedBufferQt.cpp \ platform/graphics/qt/FontCacheQt.cpp \ -platform/graphics/qt/FontCustomPlatformData.cpp \ +platform/graphics/qt/FontCustomPlatformDataQt.cpp \ platform/graphics/qt/GlyphPageTreeNodeQt.cpp \ platform/graphics/qt/SimpleFontDataQt.cpp \ platform/qt/KURLQt.cpp \ Thanks, İsmail ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Qt compilation problem
Hi Ismail, thanks for investigating this issue and for finding a possible fix. I can't comment on the specifics, but usually the best way to deal with issues like this is to file a bug report: http://webkit.org/quality/reporting.html The bugs database has a comment feature to allow for back-and-forth discussion there. And if this a Qt-specific issue, you can give it a title that begins [Qt] Finally, if you'd like to submit a formal patch for the issue, you can follow the instructions here: http://webkit.org/coding/contributing.html Otherwise, you can simply include your suggested fix below and someone else can take it from there. Thanks a lot, --Chris On Sat, Feb 6, 2010 at 6:29 PM, İsmail Dönmez ism...@namtrac.org wrote: Hi; On Fri, Feb 5, 2010 at 1:35 PM, İsmail Dönmez ism...@namtrac.org wrote: Hi Darin; On Fri, Feb 5, 2010 at 1:32 PM, Darin Adler da...@apple.com wrote: This is a question for the webkit-help mailing list or a Qt-specific one, not webkit-dev. The webkit-dev mailing list is for discussion of WebKit development, not building or using it. See http://webkit.org/contact.html. The reason I used this mailing list is because this is a clear regression not just a build problem on my side. If proven otherwise, I am sorry. Looks like nmake messes up when the filenames match. Following patch fixes this (of course after doing a git mv), can someone comment? diff --git a/WebCore/WebCore.pro b/WebCore/WebCore.pro index 4d2c597..0b062d0 100644 --- a/WebCore/WebCore.pro +++ b/WebCore/WebCore.pro @@ -1999,7 +1999,7 @@ SOURCES += \ platform/qt/FileSystemQt.cpp \ platform/qt/SharedBufferQt.cpp \ platform/graphics/qt/FontCacheQt.cpp \ - platform/graphics/qt/FontCustomPlatformData.cpp \ + platform/graphics/qt/FontCustomPlatformDataQt.cpp \ platform/graphics/qt/GlyphPageTreeNodeQt.cpp \ platform/graphics/qt/SimpleFontDataQt.cpp \ platform/qt/KURLQt.cpp \ Thanks, İsmail ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Qt compilation problem
Hi Chris; On Sat, Feb 6, 2010 at 7:01 PM, Chris Jerdonek cjerdo...@webkit.org wrote: Hi Ismail, thanks for investigating this issue and for finding a possible fix. I can't comment on the specifics, but usually the best way to deal with issues like this is to file a bug report: http://webkit.org/quality/reporting.html The bugs database has a comment feature to allow for back-and-forth discussion there. And if this a Qt-specific issue, you can give it a title that begins [Qt] Finally, if you'd like to submit a formal patch for the issue, you can follow the instructions here: http://webkit.org/coding/contributing.html Otherwise, you can simply include your suggested fix below and someone else can take it from there. I will submit a patch to bugzilla. Just wanted to make sure the fix is correct. Regards, İsmail ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Qt compilation problem
Hi; I build WebKit with build-webkit --qt --minimal and end up with the following error : FontCustomPlatformData.cpp ..\..\..\JavaScriptCore\wtf/RetainPtr.h(26) : fatal error C1083: Cannot open include file: 'CoreFoundation/CoreFoundation.h': No such file or directory Looks like its picking up ./WebCore/platform/graphics/win/FontCustomPlatformData.cpp instead of ./WebCore/platform/graphics/qt/FontCustomPlatformData.cpp as expected. Any ideas? Regards, İsmail ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Qt compilation problem
This is a question for the webkit-help mailing list or a Qt-specific one, not webkit-dev. The webkit-dev mailing list is for discussion of WebKit development, not building or using it. See http://webkit.org/contact.html. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Qt compilation problem
Hi Darin; On Fri, Feb 5, 2010 at 1:32 PM, Darin Adler da...@apple.com wrote: This is a question for the webkit-help mailing list or a Qt-specific one, not webkit-dev. The webkit-dev mailing list is for discussion of WebKit development, not building or using it. See http://webkit.org/contact.html. The reason I used this mailing list is because this is a clear regression not just a build problem on my side. If proven otherwise, I am sorry. Regards, İsmail ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
