Re: [webkit-dev] Question regarding build flags for the features

2010-03-24 Thread Eli Fidler
Of Maciej Stachowiak Sent: Tuesday, March 23, 2010 8:35 PM To: Dmitry Titov Cc: WebKit-Dev Development Subject: Re: [webkit-dev] Question regarding build flags for the features On Mar 23, 2010, at 1:22 PM, Dmitry Titov wrote: If we had a single flag for all those (ENABLE_FILE_API

[webkit-dev] Question regarding build flags for the features

2010-03-23 Thread Jian Li
Hi, I've introduced a build flag ENABLE(BLOB_SLICE) for the Blob.slice feature. To continue implementing other File API features, we probably need a couple more build flags, like ENABLE(FILE_URN) and ENABLE(FILE_READER). When the embedder implements the necessary support, these flags can be

Re: [webkit-dev] Question regarding build flags for the features

2010-03-23 Thread Dmitry Titov
If we had a single flag for all those (ENABLE_FILE_API ?) then a port would have to implement all features at once to be able to enable it. It might be inconvenient. If the code is not shared and those flags can be enabled in any combination, why not keep them separate? On a related note, it'd be

Re: [webkit-dev] Question regarding build flags for the features

2010-03-23 Thread Maciej Stachowiak
On Mar 23, 2010, at 1:22 PM, Dmitry Titov wrote: If we had a single flag for all those (ENABLE_FILE_API ?) then a port would have to implement all features at once to be able to enable it. It might be inconvenient. If the code is not shared and those flags can be enabled in any