Re: [webkit-dev] REQUEST_ANIMATION_FRAME on all ports?

2017-01-16 Thread Joseph Pecoraro
I also like the idea that we should remove flags for core web features that 
have been stable for a while.

There were no objections raise on this thread to remove the 
REQUEST_ANIMATION_FRAME flag.

Patch up on:
https://bugs.webkit.org/show_bug.cgi?id=156980 


- Joe
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] REQUEST_ANIMATION_FRAME on all ports?

2016-06-08 Thread Anders Carlsson

> On Jun 8, 2016, at 2:37 PM, Dean Jackson  wrote:
> 
> 
>> On Jun 8, 2016, at 2:23 PM, Konstantin Tokarev  wrote:
>> 
>> 
>> 
>> 08.06.2016, 23:59, "Dean Jackson" :
>>> Do the EFL and GTK ports always enable this feature? If so, I'm going to 
>>> remove the compile flag.
>> 
>> While I'm not opposed to this change, it looks like its maintenance cost is 
>> near zero.
> 
> I think we should remove guards for features that are (now) core to the Web.
> 
> Dean

I agree. Fewer flags in the code means fewer cases we have to think about.

- Anders

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] REQUEST_ANIMATION_FRAME on all ports?

2016-06-08 Thread Dean Jackson

> On Jun 8, 2016, at 2:23 PM, Konstantin Tokarev  wrote:
> 
> 
> 
> 08.06.2016, 23:59, "Dean Jackson" :
>> Do the EFL and GTK ports always enable this feature? If so, I'm going to 
>> remove the compile flag.
> 
> While I'm not opposed to this change, it looks like its maintenance cost is 
> near zero.

I think we should remove guards for features that are (now) core to the Web.

Dean

> Last time I was building with it disabled it was not broken, though it didn't 
> receive any compilation fixes for at least 2 years!
> 
> https://bugs.webkit.org/show_bug.cgi?id=155882
> https://lists.webkit.org/pipermail/webkit-dev/2014-March/026366.html
> 
> -- 
> Regards,
> Konstantin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] REQUEST_ANIMATION_FRAME on all ports?

2016-06-08 Thread Michael Catanzaro
On Wed, 2016-06-08 at 13:59 -0700, Dean Jackson wrote:
> Do the EFL and GTK ports always enable this feature?

Yes
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] REQUEST_ANIMATION_FRAME on all ports?

2016-06-08 Thread Konstantin Tokarev


08.06.2016, 23:59, "Dean Jackson" :
> Do the EFL and GTK ports always enable this feature? If so, I'm going to 
> remove the compile flag.

While I'm not opposed to this change, it looks like its maintenance cost is 
near zero. Last time I was building with it disabled it was not broken, though 
it didn't receive any compilation fixes for at least 2 years!

https://bugs.webkit.org/show_bug.cgi?id=155882
https://lists.webkit.org/pipermail/webkit-dev/2014-March/026366.html

-- 
Regards,
Konstantin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] REQUEST_ANIMATION_FRAME on all ports?

2016-06-08 Thread Dean Jackson
Do the EFL and GTK ports always enable this feature? If so, I'm going to remove 
the compile flag.

Dean

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev