Re: [webkit-dev] Remove CSS_IMAGE_ORIENTATION Feature Guard
Hi Gyuyoung, Since you completed work on Bug 92330, I think we now do wish to keep the ENABLE_CSS_IMAGE_ORIENTATION Flag. Can you please confirm? Thanks, -Brent On Jul 2, 2013, at 6:00 PM, Gyuyoung Kim gyuyoung@webkit.org wrote: Hi Brent, Sorry for no activity on this. This work was pushed back on the my priority list. Thus, I agree to remove this feature if nobody(including me) submits meaningful patch until July 17th. Gyuyoung. On Wed, Jul 3, 2013 at 3:05 AM, Brent Fulgham bfulg...@apple.com mailto:bfulg...@apple.com wrote: Hi Everyone, I haven't seen any action on https://bugs.webkit.org/show_bug.cgi?id=116555 https://bugs.webkit.org/show_bug.cgi?id=116555 (or https://bugs.webkit.org/show_bug.cgi?id=92330 https://bugs.webkit.org/show_bug.cgi?id=92330) in the past month. I'd like to remove this logic unless there is some activity here. We can always add it back in from SVN history if someone does want to work on it. I'll submit a patch to remove this code on July 17th unless something changes. Thanks, -Brent On Jun 4, 2013, at 10:15 PM, Gyuyoung Kim wrote: Hi, I'm interested in this feature. So, I took Bug 92330 over. Though I rebased the feature according to review comments, this feature doesn't work yet. So, I have investigated why it doesn't work. However, unfortunately, I need to have time a little further. If there is no big reason this patch should be removed, I'd like to support this feature. Gyuyoung. On Jun 5, 2013 9:45 AM, Mike Lawther mikelawt...@google.com mailto:mikelawt...@google.com wrote: Fwiw, the original author is no longer working on Blink, and the code has been removed from there. mike On Jun 5, 2013 1:24 AM, Brent Fulgham bfulg...@apple.com wrote: We have code in WebKit that is protected by the ENABLE(CSS_IMAGE_ORIENTATION) guard, but no active WebKit ports seem to enable this feature. Is anyone currently working on (or planning to work on) this feature? Since this CSS feature is currently in an early draft form, and is likely to change, we may not want to retain this dead code as it will most likely become obsolete very quickly. If no one wants to claim ownership of this feature in the next few days, I will submit a patch to remove the dead code. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org mailto:webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Remove CSS_IMAGE_ORIENTATION Feature Guard
Hi Everyone, I haven't seen any action on https://bugs.webkit.org/show_bug.cgi?id=116555 (or https://bugs.webkit.org/show_bug.cgi?id=92330) in the past month. I'd like to remove this logic unless there is some activity here. We can always add it back in from SVN history if someone does want to work on it. I'll submit a patch to remove this code on July 17th unless something changes. Thanks, -Brent On Jun 4, 2013, at 10:15 PM, Gyuyoung Kim wrote: Hi, I'm interested in this feature. So, I took Bug 92330 over. Though I rebased the feature according to review comments, this feature doesn't work yet. So, I have investigated why it doesn't work. However, unfortunately, I need to have time a little further. If there is no big reason this patch should be removed, I'd like to support this feature. Gyuyoung. On Jun 5, 2013 9:45 AM, Mike Lawther mikelawt...@google.com wrote: Fwiw, the original author is no longer working on Blink, and the code has been removed from there. mike On Jun 5, 2013 1:24 AM, Brent Fulgham bfulg...@apple.com wrote: We have code in WebKit that is protected by the ENABLE(CSS_IMAGE_ORIENTATION) guard, but no active WebKit ports seem to enable this feature. Is anyone currently working on (or planning to work on) this feature? Since this CSS feature is currently in an early draft form, and is likely to change, we may not want to retain this dead code as it will most likely become obsolete very quickly. If no one wants to claim ownership of this feature in the next few days, I will submit a patch to remove the dead code. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Remove CSS_IMAGE_ORIENTATION Feature Guard
Hi Gyuyoung, On Jun 4, 2013, at 10:15 PM, Gyuyoung Kim gyuyoung@webkit.org wrote: I'm interested in this feature. So, I took Bug 92330 over. Though I rebased the feature according to review comments, this feature doesn't work yet. So, I have investigated why it doesn't work. However, unfortunately, I need to have time a little further. If there is no big reason this patch should be removed, I'd like to support this feature Great! We'll leave it in then. -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Remove CSS_IMAGE_ORIENTATION Feature Guard
We have code in WebKit that is protected by the ENABLE(CSS_IMAGE_ORIENTATION) guard, but no active WebKit ports seem to enable this feature. Is anyone currently working on (or planning to work on) this feature? Since this CSS feature is currently in an early draft form, and is likely to change, we may not want to retain this dead code as it will most likely become obsolete very quickly. If no one wants to claim ownership of this feature in the next few days, I will submit a patch to remove the dead code. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Remove CSS_IMAGE_ORIENTATION Feature Guard
Hi, I'm interested in this feature. So, I took Bug 92330 over. Though I rebased the feature according to review comments, this feature doesn't work yet. So, I have investigated why it doesn't work. However, unfortunately, I need to have time a little further. If there is no big reason this patch should be removed, I'd like to support this feature. Gyuyoung. On Jun 5, 2013 9:45 AM, Mike Lawther mikelawt...@google.com wrote: Fwiw, the original author is no longer working on Blink, and the code has been removed from there. mike On Jun 5, 2013 1:24 AM, Brent Fulgham bfulg...@apple.com wrote: We have code in WebKit that is protected by the ENABLE(CSS_IMAGE_ORIENTATION) guard, but no active WebKit ports seem to enable this feature. Is anyone currently working on (or planning to work on) this feature? Since this CSS feature is currently in an early draft form, and is likely to change, we may not want to retain this dead code as it will most likely become obsolete very quickly. If no one wants to claim ownership of this feature in the next few days, I will submit a patch to remove the dead code. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
