Re: [webkit-dev] Remove webkitDashArray attribute from CanvasRenderingContext2d

2013-01-29 Thread Dirk Schulze

On Jan 30, 2013, at 1:12 PM, Dean Jackson  wrote:

> 
> On 30/01/2013, at 12:46 PM, Dirk Schulze  wrote:
> 
>> Would it be possible to clean up the code a bit more and remove the prefixed 
>> attributes?
> 
> I don't think they should be removed yet. As you mentioned, it's been 16 
> months which is at least one Safari release cycle. I'd prefer that we give a 
> console warning for now.

This sounds reasonable for me. Just as a note, if the next Safari release for 
iOS and Mac do not add this console warning, it may take another year before 
the code can be cleaned up. The impact is minimal so.

Greetings,
Dirk

> 
> Dean
> 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Remove webkitDashArray attribute from CanvasRenderingContext2d

2013-01-29 Thread Dean Jackson

On 30/01/2013, at 12:46 PM, Dirk Schulze  wrote:

> Would it be possible to clean up the code a bit more and remove the prefixed 
> attributes?

I don't think they should be removed yet. As you mentioned, it's been 16 months 
which is at least one Safari release cycle. I'd prefer that we give a console 
warning for now.

Dean


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Remove webkitDashArray attribute from CanvasRenderingContext2d

2013-01-29 Thread Adam Barth
Our general approach to deprecating features is outlined on this wiki page:

http://trac.webkit.org/wiki/DeprecatingFeatures

It sounds like you're advocating the "cold turkey" approach here with
a "clear path forward" for developers.

Adam


On Tue, Jan 29, 2013 at 5:46 PM, Dirk Schulze  wrote:
> Hi WebKit folks,
>
> I would like to know if we can remove the following API's in the 
> CanvasRenderingContext2d interface:
>
> webkitDashArray
> webkitLineDashOffset
>
> Both were implemented 16 months ago and replaced by the following 
> standardized, unprefixed operations and attributes 5 months ago:
>
> setLineDash
> getLineDash
> lineDashOffset
>
> Note that the webkit prefixed attributes were just implemented in 
> JavaScriptCore, no support for V8. Some of the main reason for supporting 
> these attributes 16 months ago were:
>
> - Firefox  supported them
> - PDF.js needed them for draw PDFs.
>
> PDF.js checks for the existence of the standardized operations and attributes 
> now and uses them if supported.
>
> Would it be possible to clean up the code a bit more and remove the prefixed 
> attributes?
>
> Greetings,
> Dirk
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Remove webkitDashArray attribute from CanvasRenderingContext2d

2013-01-29 Thread Dirk Schulze
Hi WebKit folks,

I would like to know if we can remove the following API's in the 
CanvasRenderingContext2d interface:

webkitDashArray
webkitLineDashOffset

Both were implemented 16 months ago and replaced by the following standardized, 
unprefixed operations and attributes 5 months ago:

setLineDash
getLineDash
lineDashOffset

Note that the webkit prefixed attributes were just implemented in 
JavaScriptCore, no support for V8. Some of the main reason for supporting these 
attributes 16 months ago were:

- Firefox  supported them
- PDF.js needed them for draw PDFs.

PDF.js checks for the existence of the standardized operations and attributes 
now and uses them if supported.

Would it be possible to clean up the code a bit more and remove the prefixed 
attributes?

Greetings,
Dirk
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev