Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
> On May 10, 2017, at 2:51 AM, Konstantin Tokarev wrote: > > > > 10.05.2017, 12:42, "Ryosuke Niwa" >: > On Wed, May > 10, 2017 at 2:14 AM, Ryosuke Niwa < > rn...@webkit.org > > wrote: >>> On Wed,

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Konstantin Tokarev
10.05.2017, 12:42, "Ryosuke Niwa" : > On Wed, May 10, 2017 at 2:14 AM, Ryosuke Niwa wrote: >>  On Wed, May 10, 2017 at 12:02 AM, Maciej Stachowiak wrote: >>>  IntegrationTests doesn't distinguish them from performance tests, or API >>>  

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Ryosuke Niwa
On Wed, May 10, 2017 at 2:14 AM, Ryosuke Niwa wrote: > On Wed, May 10, 2017 at 12:02 AM, Maciej Stachowiak wrote: >> >> IntegrationTests doesn't distinguish them from performance tests, or API >> tests. And most test integration only incidentally.

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Ryosuke Niwa
On Wed, May 10, 2017 at 12:02 AM, Maciej Stachowiak wrote: > > IntegrationTests doesn't distinguish them from performance tests, or API > tests. And most test integration only incidentally. FunctionalTests doesn't > distinguish them from any of the other kinds of tests besides

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
A few more coats of paint for the bike shed: > On May 9, 2017, at 10:45 PM, Ryosuke Niwa wrote: > > On Tue, May 9, 2017 at 10:23 PM, Maciej Stachowiak > wrote: > > On May 9, 2017, at 9:07 PM, Michael Catanzaro > <

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
> On May 9, 2017, at 10:43 PM, Dan Bernstein wrote: > > >> On May 9, 2017, at 10:23 PM, Maciej Stachowiak > > wrote: >> >>> JSTests, and >> >> Could go under JavaScriptCore, since these by design don't test anything >> outside of

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Ryosuke Niwa
On Tue, May 9, 2017 at 10:23 PM, Maciej Stachowiak wrote: > > >> On May 9, 2017, at 9:07 PM, Michael Catanzaro wrote: >> >> On Tue, May 9, 2017 at 11:01 PM, Maciej Stachowiak wrote: >>> How about just Tests? >>> Or alternately,

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Dan Bernstein
> On May 9, 2017, at 10:23 PM, Maciej Stachowiak wrote: > >> JSTests, and > > Could go under JavaScriptCore, since these by design don't test anything > outside of JavaScriptCore. There is an advantage to Apple’s internal production build system in keeping large amounts of

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Manuel Rego Casasnovas
On 10/05/17 04:23, Ryosuke Niwa wrote: > Continuing the tradition of a massive rename in > https://lists.webkit.org/pipermail/webkit-dev/2012-August/021746.html, > I suggest we rename the top-level LayoutTests directory to something > more descriptive of the current state. > > Some ideas: >

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 9:07 PM, Michael Catanzaro wrote: > > On Tue, May 9, 2017 at 11:01 PM, Maciej Stachowiak wrote: >> How about just Tests? >> Or alternately, RegressionTests. But I like just plain Tests. > > Then we should move ManualTests I'd be in

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Michael Catanzaro
On Tue, May 9, 2017 at 11:01 PM, Maciej Stachowiak wrote: How about just Tests? Or alternately, RegressionTests. But I like just plain Tests. Then we should move ManualTests, PerformanceTests, JSTests, and TestWebKitAPI underneath it, because it would be weird to have tests

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Ryosuke Niwa
On Tue, May 9, 2017 at 9:01 PM, Maciej Stachowiak wrote: > How about just Tests? > > Or alternately, RegressionTests. But I like just plain Tests. But we also have JSTests, ManualTests, and PerformanceTests so I think it's nice to convey that what they're testing. e.g.

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Maciej Stachowiak
How about just Tests? Or alternately, RegressionTests. But I like just plain Tests. > On May 9, 2017, at 8:51 PM, Michael Catanzaro wrote: > >> On Tue, May 9, 2017 at 9:23 PM, Ryosuke Niwa wrote: >> AutomatedTests - As opposed to ManualTests. > > The

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Michael Catanzaro
On Tue, May 9, 2017 at 9:23 PM, Ryosuke Niwa wrote: AutomatedTests - As opposed to ManualTests. The API tests under Tools/TestWebKitAPI (which never seemed to me like a good location for tests) are also automated, so this doesn't seem like the best name unless we want to

[webkit-dev] Rename LayoutTests

2017-05-09 Thread Ryosuke Niwa
Hi, Continuing the tradition of a massive rename in https://lists.webkit.org/pipermail/webkit-dev/2012-August/021746.html, I suggest we rename the top-level LayoutTests directory to something more descriptive of the current state. Some ideas: IntegrationTests - Represents what they are for