[webkit-dev] RenderLayer::isStackingContext() confusion

2013-04-03 Thread Shawn Singh
Background: According to CSS 2.1 spec, an element becomes a stacking context when: - it is positioned (relative, absolute, or fixed) - and it has a non-auto z-index Spec also mentions that there's room for expanding this definition; the examples I know about are fixed-position elements and

Re: [webkit-dev] RenderLayer::isStackingContext() confusion

2013-04-03 Thread Elliott Sprehn
The function does what it says, it's just not obvious why: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/WebCore/css/StyleResolver.cppsq=package:chromiumtype=csq=adjustRenderStylel=1469 First we set the z-index to be auto for static position elements. Next

Re: [webkit-dev] RenderLayer::isStackingContext() confusion

2013-04-03 Thread Shawn Singh
Thanks for the explanation. I submitted a patch, just in case reviewers agree that a comment is appropriate there. But I won't argue strongly either way. https://bugs.webkit.org/show_bug.cgi?id=113909 On Wed, Apr 3, 2013 at 1:18 PM, Elliott Sprehn espr...@chromium.org wrote: The function