[webkit-dev] Rounding issues on different platforms
Hi, If you maintain some bots, and you saw rounding issues which makes 1px difference on let's say 32 and 64 bit environments for several layout tests, you may interested in this bug: https://bugs.webkit.org/show_bug.cgi?id=62204 I try to explain what exactly happens there, and it could be used as a master bug for tracking these issues. Regards, Zoltan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Rounding issues on different platforms
On Tue, Jun 7, 2011 at 5:34 AM, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: If you maintain some bots, and you saw rounding issues which makes 1px difference on let's say 32 and 64 bit environments for several layout tests, you may interested in this bug: https://bugs.webkit.org/show_bug.cgi?id=62204 Years ago someone tracked down a layout test failure to optimizations on a particular file in WebKit. http://code.google.com/p/chromium/issues/detail?id=8475 The extra precision is causing a problem in: third_party/WebKit/WebCore/platform/graphics/Color.cpp which can be fixed by compiling with -ffloat-store. However, that was long enough ago the error may no longer exist in that file. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Rounding issues on different platforms
On Tue, Jun 7, 2011 at 9:33 AM, Evan Martin e...@chromium.org wrote: On Tue, Jun 7, 2011 at 5:34 AM, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: If you maintain some bots, and you saw rounding issues which makes 1px difference on let's say 32 and 64 bit environments for several layout tests, you may interested in this bug: https://bugs.webkit.org/show_bug.cgi?id=62204 Years ago someone tracked down a layout test failure to optimizations on a particular file in WebKit. http://code.google.com/p/chromium/issues/detail?id=8475 The extra precision is causing a problem in: third_party/WebKit/WebCore/platform/graphics/Color.cpp which can be fixed by compiling with -ffloat-store. However, that was long enough ago the error may no longer exist in that file. I believe I may have found at least one source of rounding issues [1], but I simply have not had time to look into it further. [1] https://bugs.webkit.org/show_bug.cgi?id=54474#c18 --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
