Re: [webkit-dev] Suggesting to enable paint timing by default

2020-08-20 Thread Noam Rosenthal
On Thu, 20 Aug 2020 at 6:26 Maciej Stachowiak wrote: > > > On Jul 17, 2020, at 12:12 AM, Noam Rosenthal wrote: > > > > On Thu, Jul 16, 2020 at 11:03 PM Keith Miller > wrote: > >> Results appear to be neutral on the page load time benchmark, so you >> should be good on that front. I don’t know

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-08-19 Thread Maciej Stachowiak
> On Jul 17, 2020, at 12:12 AM, Noam Rosenthal wrote: > > > > On Thu, Jul 16, 2020 at 11:03 PM Keith Miller > wrote: > Results appear to be neutral on the page load time benchmark, so you should > be good on that front. I don’t know who the best person to vet

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-07-17 Thread Noam Rosenthal
On Thu, Jul 16, 2020 at 11:03 PM Keith Miller wrote: > Results appear to be neutral on the page load time benchmark, so you > should be good on that front. I don’t know who the best person to vet the > maturity of the code is though, sorry. > Thanks a lot Keith, I appreciate it! @Maciej

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-07-16 Thread Keith Miller
Results appear to be neutral on the page load time benchmark, so you should be good on that front. I don’t know who the best person to vet the maturity of the code is though, sorry. Cheers, Keith > On Jul 13, 2020, at 11:38 AM, Noam Rosenthal wrote: > > > > On Mon, Jul 13, 2020 at 9:15 PM

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-07-13 Thread Noam Rosenthal
On Mon, Jul 13, 2020 at 9:15 PM Keith Miller wrote: > If you tell me how to enable paint timing by default, I can start an A/B > task for you. I’m probably not qualified to review it for code maturity > though. > Awesome, thanks! It's an experimental runtime flag calledPaintTimingEnabled I have

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-07-13 Thread Keith Miller
If you tell me how to enable paint timing by default, I can start an A/B task for you. I’m probably not qualified to review it for code maturity though. Cheers, Keith > On Jul 13, 2020, at 3:02 AM, Noam Rosenthal wrote: > > > > On Wed, May 27, 2020 at 12:04 PM Yoav Weiss

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-07-13 Thread Noam Rosenthal
On Wed, May 27, 2020 at 12:04 PM Yoav Weiss wrote: > +Ryosuke Niwa +Alex Christensen > who were involved in the spec discussions. > > On Wed, May 27, 2020 at 10:29 AM Noam Rosenthal wrote: > >> >> >> Following up on this. >> >>> FOn Tue, May 12, 2020 at 10:28 AM Maciej Stachowiak >>> wrote:

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-27 Thread Yoav Weiss
+Ryosuke Niwa +Alex Christensen who were involved in the spec discussions. On Wed, May 27, 2020 at 10:29 AM Noam Rosenthal wrote: > > > Following up on this. > >> FOn Tue, May 12, 2020 at 10:28 AM Maciej Stachowiak >> wrote: >> >>> >>> >>> On May 11, 2020, at 9:53 PM, Noam Rosenthal wrote:

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-27 Thread Noam Rosenthal
Following up on this. > FOn Tue, May 12, 2020 at 10:28 AM Maciej Stachowiak wrote: > >> >> >> On May 11, 2020, at 9:53 PM, Noam Rosenthal wrote: >> >> >> >> On Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak wrote: >> >>> >>> I noticed from comments in one of the Radars that the patch may

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-12 Thread Noam Rosenthal
On Tue, May 12, 2020 at 10:28 AM Maciej Stachowiak wrote: > > > On May 11, 2020, at 9:53 PM, Noam Rosenthal wrote: > > > > On Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak wrote: > >> >> I noticed from comments in one of the Radars that the patch may result in >> an additional “fake paint”,

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-12 Thread Maciej Stachowiak
> On May 11, 2020, at 9:53 PM, Noam Rosenthal wrote: > > > > On Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak > wrote: > > I noticed from comments in one of the Radars that the patch may result in an > additional “fake paint”, so it should probably be performance

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-11 Thread Noam Rosenthal
On Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak wrote: > > I noticed from comments in one of the Radars that the patch may result in > an additional “fake paint”, so it should probably be performance tested. > Have you done any testing? > I've tested it locally, I haven't noticed any

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-05-11 Thread Maciej Stachowiak
I noticed from comments in one of the Radars that the patch may result in an additional “fake paint”, so it should probably be performance tested. Have you done any testing? We’ll likely want to A/B some of Apple’s page load speed benchmarks. I’d like to hear from others on maturity of the

[webkit-dev] Suggesting to enable paint timing by default

2020-05-11 Thread Noam Rosenthal
Following the discussion with Simon in https://bugs.webkit.org/show_bug.cgi?id=78011 Since we have a pretty stable spec (https://w3c.github.io/paint-timing/), lots of passing web platform tests, other browser vendor support and a working implementation of first contentful paint, I am planning to