[webkit-dev] TARGET_OS_EMBEDDED

2009-12-04 Thread Zoltan Herczeg
Hi,

it would be a great to have a macro in WebKit, which would be enabled on
embedded systems. We could replace macros like PLATFORM(SYMBIAN) in
TextCodecQt.cpp to this new macro. However, TARGET_OS_EMBEDDED macro
enables WTF_PLATFORM_IPHONE. Well, not only symbian and iPhone exist in
embedded domain. What is your suggestion?

Zoltan


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] TARGET_OS_EMBEDDED

2009-12-04 Thread Adam Treat
I think this would suffer from lack of clarity.  Not all embedded systems are 
alike and not all will wish to be treated in the same way.

On Friday 04 December 2009 08:51:12 am Zoltan Herczeg wrote:
 Hi,

 it would be a great to have a macro in WebKit, which would be enabled on
 embedded systems. We could replace macros like PLATFORM(SYMBIAN) in
 TextCodecQt.cpp to this new macro. However, TARGET_OS_EMBEDDED macro
 enables WTF_PLATFORM_IPHONE. Well, not only symbian and iPhone exist in
 embedded domain. What is your suggestion?

 Zoltan


 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] TARGET_OS_EMBEDDED

2009-12-04 Thread Maciej Stachowiak


On Dec 4, 2009, at 5:51 AM, Zoltan Herczeg wrote:


Hi,

it would be a great to have a macro in WebKit, which would be  
enabled on

embedded systems. We could replace macros like PLATFORM(SYMBIAN) in
TextCodecQt.cpp to this new macro. However, TARGET_OS_EMBEDDED macro
enables WTF_PLATFORM_IPHONE. Well, not only symbian and iPhone exist  
in

embedded domain. What is your suggestion?


I think we should probably phase out TARGET_OS_EMBEDDED, as it seems  
too general to be useful.


Regards,
Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev