Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Zoltan Horvath
I opened a bug for the issue https://bugs.webkit.org/show_bug.cgi?id=115114. To be continued there. Cheers, Zoltan On Tue, Apr 23, 2013 at 11:45 AM, Zoltan Horvath zol...@webkit.org wrote: Yes, that be would the cleanest solution. If there is no concerns against it, I'm going to file a bug.

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Darin Adler
On Apr 23, 2013, at 11:36 AM, Benjamin Poulain benja...@webkit.org wrote: The current mode works fine for some ref-tests but is really annoying for others. I would love to have a way to compare the entire page instead of the viewport. Maybe it could just be an API on testrunner? Like:

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Benjamin Poulain
On Wed, Apr 24, 2013 at 9:55 AM, Darin Adler da...@apple.com wrote: On Apr 23, 2013, at 11:36 AM, Benjamin Poulain benja...@webkit.org wrote: The current mode works fine for some ref-tests but is really annoying for others. I would love to have a way to compare the entire page instead of

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread L. David Baron
On Wednesday 2013-04-24 09:55 -0700, Darin Adler wrote: On Apr 23, 2013, at 11:36 AM, Benjamin Poulain benja...@webkit.org wrote: The current mode works fine for some ref-tests but is really annoying for others. I would love to have a way to compare the entire page instead of the

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Dirk Pranke
On Wed, Apr 24, 2013 at 10:30 AM, L. David Baron dba...@dbaron.org wrote: On Wednesday 2013-04-24 09:55 -0700, Darin Adler wrote: On Apr 23, 2013, at 11:36 AM, Benjamin Poulain benja...@webkit.org wrote: The current mode works fine for some ref-tests but is really annoying for others. I

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Elliott Sprehn
On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.org wrote: ... I think this raises two related questions, both of which would be helped by concrete examples: 1) What sort of test are you writing where 800x600 isn't big enough to test what you need to test? 2) What sort

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Dirk Pranke
On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.orgwrote: ... I think this raises two related questions, both of which would be helped by concrete examples: 1) What sort of test are you writing

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Elliott Sprehn
On Wed, Apr 24, 2013 at 3:31 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.orgwrote: ... I think this raises two related questions, both of which

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Ryosuke Niwa
On Wed, Apr 24, 2013 at 3:31 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.orgwrote: ... I think this raises two related questions, both of which would

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Dirk Pranke
On Wed, Apr 24, 2013 at 3:35 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 3:31 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Darin Adler
On Apr 24, 2013, at 3:45 PM, Dirk Pranke dpra...@chromium.org wrote: in the absence of tests that *need* bigger viewports, I'd side w/ David and say that we should fix tests to fit within 800x600 so that they are portable to other browsers and meet the W3C's criteria. Makes sense. I

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Ryosuke Niwa
Definitely. If we had a test that needs to be only compared for what’s visible in its viewport, we can probably just use an iframe that’s 800x600 in most cases I can think of. Also, we can always add a new testRunner or internals method clip the output if we really need such a functionality. - R.

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Dirk Pranke
On Wed, Apr 24, 2013 at 3:49 PM, Darin Adler da...@apple.com wrote: On Apr 24, 2013, at 3:45 PM, Dirk Pranke dpra...@chromium.org wrote: in the absence of tests that *need* bigger viewports, I'd side w/ David and say that we should fix tests to fit within 800x600 so that they are portable

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Darin Adler
On Apr 24, 2013, at 3:52 PM, Dirk Pranke dpra...@chromium.org wrote: You mean it's easy to write a test that is bigger than 800x600, and perhaps we should generate some sort of warning for this? It’s easy to write a test where part of what we’re trying to test is outside 800x600, right. And

Re: [webkit-dev] Test frame size for reftests

2013-04-24 Thread Dirk Pranke
On Wed, Apr 24, 2013 at 4:00 PM, Darin Adler da...@apple.com wrote: On Apr 24, 2013, at 3:52 PM, Dirk Pranke dpra...@chromium.org wrote: You mean it's easy to write a test that is bigger than 800x600, and perhaps we should generate some sort of warning for this? It’s easy to write a test

[webkit-dev] Test frame size for reftests

2013-04-23 Thread Zoltan Horvath
Hey there, I was debugging a test which was passing in the testrunner, but failing in the testbrowser. It was because the reftests compare only in a 800*600px frame, although we have many tests which are taller than this frame. If there was a mismatch to the expected result outside that frame and

Re: [webkit-dev] Test frame size for reftests

2013-04-23 Thread Zoltan Horvath
Yes, that be would the cleanest solution. If there is no concerns against it, I'm going to file a bug. Zoltan On Tue, Apr 23, 2013 at 11:36 AM, Benjamin Poulain benja...@webkit.orgwrote: Hi, On Tue, Apr 23, 2013 at 11:26 AM, Zoltan Horvath zol...@webkit.orgwrote: I was debugging a test