[webkit-dev] The mysterious IconDatabase

2007-09-18 Thread Patrick Hanna
I am having trouble using the IconDatabase successfully. I was wondering if I am either using it incorrectly or if Safari is doing some extra work to get the correct favicon for a given site. Here is the scenario. I am going to assume that each icon is retained at least once so that icons

Re: [webkit-dev] The mysterious IconDatabase

2007-09-18 Thread Brady Eidson
Hi Patrick, Could you give a little more context? Are you using ToT WebKit? On Sep 18, 2007, at 9:27 AM, Patrick Hanna wrote: Load www.google.com, FrameLoaderClient::dispatchDidReceiveIcon is called. IconDatabase::iconForPageURL returns an icon, this is perfect. Right Load

Re: [webkit-dev] The mysterious IconDatabase

2007-09-18 Thread John Sullivan
Safari has no logic of its own about which icon goes with which site; it relies on the icon database for this knowledge. Safari does have a little logic to pevent the icon in the URL field from flashing back and forth between a generic and non-generic icon as you type in a URL. John On

Re: [webkit-dev] The mysterious IconDatabase

2007-09-18 Thread Patrick Hanna
I have discovered that I have an IconDatabase that is older than the new multi-thread database if that is any help. If Safari has no extra knowledge, how does it decide to display the google icon for www.google.com/search before visiting the site but after visiting www.google.com? The same

Re: [webkit-dev] The mysterious IconDatabase

2007-09-18 Thread Patrick Hanna
It looks like you have to completely delete the address in the Address bar to get the icon to go away. If you don't delete the whole thing, the icon stays there. That looks like what you mentioned earlier about not flashing between the default icon and the custom icon while typing. Maybe I

Re: [webkit-dev] The mysterious IconDatabase

2007-09-18 Thread John Sullivan
On Sep 18, 2007, at 10:25 AM, Patrick Hanna wrote: I have discovered that I have an IconDatabase that is older than the new multi-thread database if that is any help. If Safari has no extra knowledge, how does it decide to display the google icon for www.google.com/search before visiting