[webkit-dev] Trouble with updating Chromium' slayout test expectations

2011-02-22 Thread Hajime Morita
Hi Chromium WebKit folks, I'm looking for a help to retrieve the latest expectation files for Chromium Mac LayoutTest. At the weekend there was a change that triggers massive amount of pixel test failures that requires rebaselining. (https://bugs.webkit.org/b/54736) But the buildbot doesn't have

Re: [webkit-dev] Trouble with updating Chromium' slayout test expectations

2011-02-22 Thread Mihai Parparita
It looks like Drew checked in baselines with http://trac.webkit.org/changeset/79034 (which may be why rebaseline-chromium-webkit-tests isn't doing anything, since it already has correct pixel baselines), but given http://trac.webkit.org/changeset/79088 it didn't seem to work. Drew, any ideas why?

Re: [webkit-dev] Trouble with updating Chromium' slayout test expectations

2011-02-22 Thread Drew Wilson
Yeah, it's weird. I rebaselined those tests, but the chromium canaries still showed them as red. Now, however, the canaries are showing many of them passing. I was planning to remove the lines from test_expectations today to see if they stay green. -atw On Tue, Feb 22, 2011 at 6:46 AM, Mihai

Re: [webkit-dev] Trouble with updating Chromium' slayout test expectations

2011-02-22 Thread Mikhail Naganov
I have a suspicion that the cause of canaries failures is described here: https://groups.google.com/a/google.com/group/chrome-webkit-gardening/browse_thread/thread/d3b3a4fc647e804d In short, bots can run tests prematurely, emitting false failures. I observed this during my gardening, and I think

Re: [webkit-dev] Trouble with updating Chromium' slayout test expectations

2011-02-22 Thread Mihai Parparita
But these were rebaselines, which don't depend on any code changes. Mihai On Tue, Feb 22, 2011 at 10:35 AM, Mikhail Naganov mnaga...@chromium.org wrote: I have a suspicion that the cause of canaries failures is described here:

Re: [webkit-dev] Trouble with updating Chromium' slayout test expectations

2011-02-22 Thread Mikhail Naganov
Ah, true. The code changes were long ago. On Tue, Feb 22, 2011 at 21:40, Mihai Parparita mih...@chromium.org wrote: But these were rebaselines, which don't depend on any code changes. Mihai On Tue, Feb 22, 2011 at 10:35 AM, Mikhail Naganov mnaga...@chromium.org wrote: I have a suspicion

Re: [webkit-dev] Trouble with updating Chromium' slayout test expectations

2011-02-22 Thread Drew Wilson
That's an interesting thread. I had always assumed that either the testers always synced to the same rev as the builders, or at least that they pulled the layout test files/expectations from the builders along with the executables. Not doing this just seems inherently broken, but I understand why