Re: [webkit-dev] Unified source builds and adding or removing files...

2019-03-20 Thread Don . Olmstead
if things compile. From: webkit-dev On Behalf Of Tim Horton Sent: Tuesday, March 19, 2019 4:02 PM To: Said Abou-Hallawa Cc: WebKit Development Mailing List Subject: Re: [webkit-dev] Unified source builds and adding or removing files... We already had this discussion; see the thread titled "Un

Re: [webkit-dev] Unified source builds and adding or removing files...

2019-03-19 Thread Tim Horton
We already had this discussion; see the thread titled "Unified sources have broken our #include hygiene" > On Mar 19, 2019, at 3:48 PM, Said Abou-Hallawa wrote: > > I have been working on patches that require adding and removing cpp files > from WebCore/Sources.txt. Almost every time I add or

[webkit-dev] Unified source builds and adding or removing files...

2019-03-19 Thread Said Abou-Hallawa
I have been working on patches that require adding and removing cpp files from WebCore/Sources.txt. Almost every time I add or remove a file, I hit undefined symbol compilation error in some unrelated source or header file. Because a group of source files are compiled in one unified source