Re: [webkit-dev] WebKit2 build system
Hi, I was looking at a patch (https://bugs.webkit.org/show_bug.cgi?id=57535) in which it uses the OS() macro in some headers (to add a conditional include to define time_t). Unfortunately, when these headers are included from WebKit2 files, the build breaks (on various platforms) because OS() isn't defined. Typically OS() is defined by including config.h but that file doesn't seem to be in the cpp files for WebKit2. What is the proper way of fixing this? - include wtf/Platform.h directly in the header files affected (which seem wrong to me). - include config.h in WebKit2 files (but this appears not to be done). - other? Thanks, dave On Mon, Nov 29, 2010 at 1:20 PM, laszlo.1.gom...@nokia.com wrote: Hi, I'd like to warm up this old thread. Dependency on prefix header support seems to be a problem for ARM compiler (ARMCC/RVCT) builds as well (e.g. Symbian build). I've filed a bug to see if we can eliminate this build system dependency - https://bugs.webkit.org/show_bug.cgi?id=50174. We're considering posting a patch that explicitly includes the prefix header in all WebKit2 cpp files (just like config.h) - as suggested earlier. Concerns/better suggestions are welcome (before we touch 200+ files). Thanks, Laszlo -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto: webkit-dev-boun...@lists.webkit.org] On Behalf Of ext Kenneth Christiansen Sent: Wednesday, July 07, 2010 2:36 PM To: Sam Weinig Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] WebKit2 build system Currently it seems that at least icecc does not. Also, qmake which is the build system for the Qt port does not support prefix headers directly and we thus have to emulate it using the precompiled header support. Kenneth On Wed, Jul 7, 2010 at 2:27 PM, Sam Weinig sam.wei...@gmail.com wrote: It should not be necessary to use WebKitPrefix.h as a precompiled header, it is only necessary for it to be used a prefix header. Does discc also not support prefix headers? ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit2 build system
Question answered (in irc): WebKit2 files should have config.h Thanks! On Mon, Apr 11, 2011 at 9:58 AM, David Levin le...@google.com wrote: Hi, I was looking at a patch (https://bugs.webkit.org/show_bug.cgi?id=57535) in which it uses the OS() macro in some headers (to add a conditional include to define time_t). Unfortunately, when these headers are included from WebKit2 files, the build breaks (on various platforms) because OS() isn't defined. Typically OS() is defined by including config.h but that file doesn't seem to be in the cpp files for WebKit2. What is the proper way of fixing this? - include wtf/Platform.h directly in the header files affected (which seem wrong to me). - include config.h in WebKit2 files (but this appears not to be done). - other? ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit2 build system
Hi, I'd like to warm up this old thread. Dependency on prefix header support seems to be a problem for ARM compiler (ARMCC/RVCT) builds as well (e.g. Symbian build). I've filed a bug to see if we can eliminate this build system dependency - https://bugs.webkit.org/show_bug.cgi?id=50174. We're considering posting a patch that explicitly includes the prefix header in all WebKit2 cpp files (just like config.h) - as suggested earlier. Concerns/better suggestions are welcome (before we touch 200+ files). Thanks, Laszlo -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of ext Kenneth Christiansen Sent: Wednesday, July 07, 2010 2:36 PM To: Sam Weinig Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] WebKit2 build system Currently it seems that at least icecc does not. Also, qmake which is the build system for the Qt port does not support prefix headers directly and we thus have to emulate it using the precompiled header support. Kenneth On Wed, Jul 7, 2010 at 2:27 PM, Sam Weinig sam.wei...@gmail.com wrote: It should not be necessary to use WebKitPrefix.h as a precompiled header, it is only necessary for it to be used a prefix header. Does discc also not support prefix headers? ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit2 build system
On 07/07/2010 07:27 PM, Sam Weinig wrote: Hi. On Wed, Jul 7, 2010 at 7:02 AM, Balazs Kelemen k...@inf.u-szeged.hu mailto:k...@inf.u-szeged.hu wrote: Hi folks! While I worked on the Qt port of WebKit2, I faced with some build issues. To solve these problems it seems like common parts of WebKit2 should change, that is why I thought that discussing them in the list would be useful. There are two main problem I see: * Usage of precompiled header. Without using WebKitPrefix.h as a precompiled header it seems like includes are broken. The reason why I dislike precompiled header is that distcc does not support it. It should not be necessary to use WebKitPrefix.h as a precompiled header, it is only necessary for it to be used a prefix header. Does discc also not support prefix headers? The config.h in JavaScriptCore and WebCore is there for similar purposes as this prefix header. Why don't we use this one in the same way? This would solve our problems with distcc and icecc. * Include paths. The common files in WebKit2 includes headers in the form #include WebKit2/xyz.h while the real place of the file is for example WebKit2/UIProcess/API/C/xyz.h. We can workaround the problem by copying headers into the build dir and set the includepath to contain it, but I do not think it is a good practice. We should probably change the mac to have forwarding headers (as we do with WebCore for JavaScriptCore) to avoid this. That would be great. I have started to create them. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] WebKit2 build system
Hi folks! While I worked on the Qt port of WebKit2, I faced with some build issues. To solve these problems it seems like common parts of WebKit2 should change, that is why I thought that discussing them in the list would be useful. There are two main problem I see: * Usage of precompiled header. Without using WebKitPrefix.h as a precompiled header it seems like includes are broken. The reason why I dislike precompiled header is that distcc does not support it. * Include paths. The common files in WebKit2 includes headers in the form #include WebKit2/xyz.h while the real place of the file is for example WebKit2/UIProcess/API/C/xyz.h. We can workaround the problem by copying headers into the build dir and set the includepath to contain it, but I do not think it is a good practice. I think WebKit2 would be more portable if we could solve these problems. Please share your thoughts with me! ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit2 build system
Hi. On Wed, Jul 7, 2010 at 7:02 AM, Balazs Kelemen k...@inf.u-szeged.hu wrote: Hi folks! While I worked on the Qt port of WebKit2, I faced with some build issues. To solve these problems it seems like common parts of WebKit2 should change, that is why I thought that discussing them in the list would be useful. There are two main problem I see: * Usage of precompiled header. Without using WebKitPrefix.h as a precompiled header it seems like includes are broken. The reason why I dislike precompiled header is that distcc does not support it. It should not be necessary to use WebKitPrefix.h as a precompiled header, it is only necessary for it to be used a prefix header. Does discc also not support prefix headers? * Include paths. The common files in WebKit2 includes headers in the form #include WebKit2/xyz.h while the real place of the file is for example WebKit2/UIProcess/API/C/xyz.h. We can workaround the problem by copying headers into the build dir and set the includepath to contain it, but I do not think it is a good practice. We should probably change the mac to have forwarding headers (as we do with WebCore for JavaScriptCore) to avoid this. -Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit2 build system
Currently it seems that at least icecc does not. Also, qmake which is the build system for the Qt port does not support prefix headers directly and we thus have to emulate it using the precompiled header support. Kenneth On Wed, Jul 7, 2010 at 2:27 PM, Sam Weinig sam.wei...@gmail.com wrote: It should not be necessary to use WebKitPrefix.h as a precompiled header, it is only necessary for it to be used a prefix header. Does discc also not support prefix headers? ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
