Re: [webkit-dev] What's up with the CHECK_CONSISTENCY macro?

2014-04-25 Thread Benjamin Poulain 

Hi Andrei,

On 4/24/14, 11:18 PM, Andrei Bucur wrote:

I’m trying to add some line boxes sanity checks and I’ve noticed there’s
a CHECK_CONSISTENCY macro guarding some consistency validation code (go
figure!) but that’s never defined in WebKit/Source. Anybody has an idea
how that macro is used?


The consistency checks in WebCore and WTF are for Debug code that is 
useful for debugging, but too slow to be enabled by default in debug builds.


You just add #define FOOBAR_CONSISTENCY 1 when needed.

From a quick check at CHECK_CONSISTENCY, it looks like they were 
disabled a long time ago 
(https://bugs.webkit.org/show_bug.cgi?id=14981). Maybe it is dead code 
now...?


Cheers,
Benjamin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] What's up with the CHECK_CONSISTENCY macro?

2014-04-24 Thread Andrei Bucur 
Hello Webkittens,

I'm trying to add some line boxes sanity checks and I've noticed there's a 
CHECK_CONSISTENCY macro guarding some consistency validation code (go figure!) 
but that's never defined in WebKit/Source. Anybody has an idea how that macro 
is used?

Andrei.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev