On Tue, Mar 9, 2010 at 11:45 PM, Zoltan Herczeg zherc...@inf.u-szeged.huwrote:
It's also a big help when peers (which aren't necessarily WebKit
reviewers)
look over it and give review-style feedback as well. Especially when
said
peers know more about that code than any of the official
On Tue, Mar 9, 2010 at 1:17 PM, David Hyatt hy...@apple.com wrote:
On Mar 9, 2010, at 1:45 PM, Adam Barth wrote:
(1) The patch needs to be reviewed by David Hyatt. David Hyatt
appears to be a bottleneck in the project because he's an expert on a
number of components that no one else
Over the past 24 hours, I've been aggressively reviewing patches in
pending-review http://webkit.org/pending-review that have been
sitting around for over a month. My approach as been to review the
patches in order from oldest to newest with a the buck stops here
perspective. That means I'm
On Mar 9, 2010, at 1:45 PM, Adam Barth wrote:
(1) The patch needs to be reviewed by David Hyatt. David Hyatt
appears to be a bottleneck in the project because he's an expert on a
number of components that no one else understands as well but he
doesn't spend as much time reviewing
(3) Someone reviewed an earlier version of the patch but then didn't
follow up. I think having a partial review by one person encourages
other people to assume that person will finish the review. That cause
the patch to float upwards in pending-review until it gets lost in the
sea of
On Tue, Mar 9, 2010 at 9:39 PM, David Levin le...@chromium.org wrote:
(3) Someone reviewed an earlier version of the patch but then didn't
follow up. I think having a partial review by one person encourages
other people to assume that person will finish the review. That cause
the patch to
On Tue, Mar 9, 2010 at 11:45 AM, Adam Barth aba...@webkit.org wrote:
Q: Why are you doing this? You should stick to reviewing code in your own
area.
A: The pending-review queue is out of control. It's past the tipping
point where there are too many patches for someone to reasonably look
at
Hi,
It's also a big help when peers (which aren't necessarily WebKit
reviewers)
look over it and give review-style feedback as well. Especially when said
peers know more about that code than any of the official reviewers.
Is that really help? Sometimes when a patch looks good to me, it
8 matches
Mail list logo
