Re: [webkit-dev] bmalloc design question about relation with std malloc
Thanks, it sounds reasonable :) On Tue, May 1, 2018 at 1:47 Geoffrey Garen wrote: > If we have just a few allocations, we should use the mmap based allocator. > This preserves the invariant that bmalloc can be used as a general-purpose > malloc implementation. > > If we have lots of small allocations, we should probably reconsider the > design. > > I’m not familiar with the new uses of std::vector inside bmalloc. That’s > not something I would recommend. > > Geoff > > > On Apr 30, 2018, at 3:35 AM, Yusuke SUZUKI > wrote: > > > > Hi, WebKittens, > > > > IIRC, bmalloc uses mmap based page allocator for internal memory use. > For example, bmalloc::Vector uses it instead of calling malloc. > > But recent changes start using std::vector, which means it uses std > malloc under the hood. > > > > So my question is, if we want some internal memory allocation in > bmalloc, shoud we use std::malloc? Or should we use mmap based allocator? > > > > Best regards, > > Yusuke Suzuki > > -- > > Regards, > > Yusuke Suzuki > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > https://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] bmalloc design question about relation with std malloc
If we have just a few allocations, we should use the mmap based allocator. This preserves the invariant that bmalloc can be used as a general-purpose malloc implementation. If we have lots of small allocations, we should probably reconsider the design. I’m not familiar with the new uses of std::vector inside bmalloc. That’s not something I would recommend. Geoff > On Apr 30, 2018, at 3:35 AM, Yusuke SUZUKI wrote: > > Hi, WebKittens, > > IIRC, bmalloc uses mmap based page allocator for internal memory use. For > example, bmalloc::Vector uses it instead of calling malloc. > But recent changes start using std::vector, which means it uses std malloc > under the hood. > > So my question is, if we want some internal memory allocation in bmalloc, > shoud we use std::malloc? Or should we use mmap based allocator? > > Best regards, > Yusuke Suzuki > -- > Regards, > Yusuke Suzuki > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] bmalloc design question about relation with std malloc
Ideally we would use the mmap allocator. But I wouldn’t do that if it causes a space usage regression, for example if we allocate a lot of small vectors. -Filip > On Apr 30, 2018, at 3:35 AM, Yusuke SUZUKI wrote: > > Hi, WebKittens, > > IIRC, bmalloc uses mmap based page allocator for internal memory use. For > example, bmalloc::Vector uses it instead of calling malloc. > But recent changes start using std::vector, which means it uses std malloc > under the hood. > > So my question is, if we want some internal memory allocation in bmalloc, > shoud we use std::malloc? Or should we use mmap based allocator? > > Best regards, > Yusuke Suzuki > -- > Regards, > Yusuke Suzuki > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] bmalloc design question about relation with std malloc
Hi, WebKittens, IIRC, bmalloc uses mmap based page allocator for internal memory use. For example, bmalloc::Vector uses it instead of calling malloc. But recent changes start using std::vector, which means it uses std malloc under the hood. So my question is, if we want some internal memory allocation in bmalloc, shoud we use std::malloc? Or should we use mmap based allocator? Best regards, Yusuke Suzuki -- Regards, Yusuke Suzuki ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
