Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-14 Thread Tony Gentilcore
> The e-mail notification for CC field changes is (among others) configurable > in everyone's Bugzilla preferences. By default, only bug originator and > assignee get an e-mail for that. > > I think that originators generally appreciate any kind of activity on their > bugs, even as small as some

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-14 Thread Alexey Proskuryakov
14.06.2011, в 01:55, Tony Gentilcore написал(а): > I'd like a way to CC myself on a bug without spamming everyone on the > bug. Some other bug trackers offer a checkbox that can disable email > update. Would anyone else find something like that useful? The e-mail notification for CC field chang

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-14 Thread Tony Gentilcore
Hopefully not too off-topic, but along lines of bugs UI housekeeping... I'd like a way to CC myself on a bug without spamming everyone on the bug. Some other bug trackers offer a checkbox that can disable email update. Would anyone else find something like that useful? -Tony _

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread SuperKim
On Jun 12, 2011 8:31 PM, "Adam Barth" wrote: > The following text appears next to every patch in bugs.webkit.org: > > Review Patch | Details | Formatted Diff | Diff > > Does anyone click the "Diff" link? I clicked by accident the other > day and my eyes were scared. Should we remove it? > > Simila

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread Ojan Vafai
There's nothing blocking doing two separate submits. We already do the submit from JavaScript, so it wouldn't require refactoring anything. You'd get two emails from bugzilla, but that's no different than the current state of affairs. I'm happy to walk someone through adding this to the review pag

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread Eric Seidel
Speaking of the "review patch" link. I really want a way to CC people from there... I don't think that's easy to do, since it uses the "details" view to actually do the submit, but it would be nice to have. :) On Mon, Jun 13, 2011 at 1:19 PM, Adam Barth wrote: > On Mon, Jun 13, 2011 at 12:15 PM

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread Adam Barth
On Mon, Jun 13, 2011 at 12:15 PM, Ojan Vafai wrote: > On Mon, Jun 13, 2011 at 12:00 PM, Ryosuke Niwa wrote: >> On Mon, Jun 13, 2011 at 11:55 AM, Adam Barth wrote: >>> >>> It would be nice to be able to select the code without selecting the >>> line numbers.  (I always need to edit them out manua

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread Ojan Vafai
On Mon, Jun 13, 2011 at 12:00 PM, Ryosuke Niwa wrote: > On Mon, Jun 13, 2011 at 11:55 AM, Adam Barth wrote: > >> It would be nice to be able to select the code without selecting the >> line numbers. (I always need to edit them out manually when I paste >> anyway.) I suspect that's going to be

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread Ryosuke Niwa
On Mon, Jun 13, 2011 at 11:55 AM, Adam Barth wrote: > It would be nice to be able to select the code without selecting the > line numbers. (I always need to edit them out manually when I paste > anyway.) I suspect that's going to be somewhat tricky because you'll > need to restructure the DOM.

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread Adam Barth
It would be nice to be able to select the code without selecting the line numbers. (I always need to edit them out manually when I paste anyway.) I suspect that's going to be somewhat tricky because you'll need to restructure the DOM. Maybe there's a fancy way to do that with CSS instead? Adam

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread Wyatt Carss
The suggestion of removing 'Formatted Diff' seems like the most reasonable - but Ryosuke brings up a good point about highlighting. While it's cool that a triple click+drag fixes his problem, a dev shouldn't have to know that to get the desired functionality out of the review tool. If the Formatte

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread Adam Barth
On Mon, Jun 13, 2011 at 11:11 AM, Wyatt Carss wrote: > Adam, you should write down a list of obscure-ui you use every day and post > it to hackernews or something :P :) > As a newb looking at the webkit page, the difference between 'Review Patch' > and 'Formatted Diff' was just confusing -- thei

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-13 Thread Wyatt Carss
Adam, you should write down a list of obscure-ui you use every day and post it to hackernews or something :P As a newb looking at the webkit page, the difference between 'Review Patch' and 'Formatted Diff' was just confusing -- their urls aren't even very distinct: 'review patch' => 'review' while

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Darin Adler
On Jun 12, 2011, at 8:10 PM, Ojan Vafai wrote: > On Sun, Jun 12, 2011 at 1:30 PM, Adam Barth wrote: > >> Does anyone click the "Preview" button? If not, we should probably remove >> it. I often use the Preview button to look over my individual comments and decide whether review+ or review- i

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Ojan Vafai
On Sun, Jun 12, 2011 at 1:30 PM, Adam Barth wrote: > The following text appears next to every patch in bugs.webkit.org: > >Review Patch | Details | Formatted Diff | Diff > > Does anyone click the "Diff" link? I clicked by accident the other > day and my eyes were scared. Should we remove it

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Adam Barth
On Sun, Jun 12, 2011 at 3:07 PM, Ryosuke Niwa wrote: > On Sun, Jun 12, 2011 at 3:02 PM, Adam Barth wrote: >> Why can't you select lines by mouse drag? > > Because it's tricky to select the first line's indentation properly if don't > mouse-down on the line number, at which point review tool start

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Ryosuke Niwa
On Sun, Jun 12, 2011 at 3:02 PM, Adam Barth wrote: > > Why can't you select lines by mouse drag? > Because it's tricky to select the first line's indentation properly if don't mouse-down on the line number, at which point review tool starts selecting lines for commenting. - Ryosuke _

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Adam Barth
On Sun, Jun 12, 2011 at 2:42 PM, Ryosuke Niwa wrote: > On Sun, Jun 12, 2011 at 1:30 PM, Adam Barth wrote: >> >> The following text appears next to every patch in bugs.webkit.org: >> >>    Review Patch | Details | Formatted Diff | Diff >> >> Does anyone click the "Diff" link?  I clicked by acciden

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Ryosuke Niwa
On Sun, Jun 12, 2011 at 1:30 PM, Adam Barth wrote: > The following text appears next to every patch in bugs.webkit.org: > >Review Patch | Details | Formatted Diff | Diff > > Does anyone click the "Diff" link? I clicked by accident the other > day and my eyes were scared. Should we remove it

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Adam Barth
On Sun, Jun 12, 2011 at 1:48 PM, Nikolas Zimmermann wrote: > Am 12.06.2011 um 22:36 schrieb Eric Seidel: >> I would go so far as to suggest removing both Diff and Formatted Diff. >> I guess I'm more excited about removing Formatted Diff than I am >> Diff, since Diff actually has some built in bugz

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Nikolas Zimmermann
Am 12.06.2011 um 22:36 schrieb Eric Seidel: > I would go so far as to suggest removing both Diff and Formatted Diff. > I guess I'm more excited about removing Formatted Diff than I am > Diff, since Diff actually has some built in bugzilla crazy features > (like diffing between attachments!?!) but

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Dirk Pranke
On Sun, Jun 12, 2011 at 1:36 PM, Eric Seidel wrote: > I would go so far as to suggest removing both Diff and Formatted Diff. >  I guess I'm more excited about removing Formatted Diff than I am > Diff, since Diff actually has some built in bugzilla crazy features > (like diffing between attachments

Re: [webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Eric Seidel
I would go so far as to suggest removing both Diff and Formatted Diff. I guess I'm more excited about removing Formatted Diff than I am Diff, since Diff actually has some built in bugzilla crazy features (like diffing between attachments!?!) but Formatted Dfif is just a lame version of Review Patc

[webkit-dev] bugs.webkit.org UI housekeeping

2011-06-12 Thread Adam Barth
The following text appears next to every patch in bugs.webkit.org: Review Patch | Details | Formatted Diff | Diff Does anyone click the "Diff" link? I clicked by accident the other day and my eyes were scared. Should we remove it? Similarly, the Review Patch page has these buttons on the b