Re: [webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Toshiyasu Morita
Thanks guys. One request - please write more comments in the code to clarify situations like this. Toshi --- On Thu, 6/4/09, Darin Adler wrote: From: Darin Adler Subject: Re: [webkit-dev] cti_op_call_ArityCheck question To: "Toshiyasu Morita" Cc: webkit-dev@lists.webkit.org Date

Re: [webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 1:50 PM, Toshiyasu Morita wrote: I don't understand this code in JITStubs::cti_op_call_arityCheck(): ASSERT(argCount != newCodeBlock->m_numParameters); It's ensuring that the argument count does not equal the number of parameters expected by the newCodeBlock. I could u

Re: [webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Gavin Barraclough
We check in JIT code for cases where arity match, and skip the call to the stub; this function is only called if there is a mismatch to be resolved. The function would probably be better named something like 'cti_op_call_handleArityMismatch'. cheers, G. On Jun 4, 2009, at 1:50 PM, Toshiya

[webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Toshiyasu Morita
I don't understand this code in JITStubs::cti_op_call_arityCheck():     ASSERT(argCount != newCodeBlock->m_numParameters); It's ensuring that the argument count does not equal the number of parameters expected by the newCodeBlock. I could understand if it was ensuring the argCount was the same, b